Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDPR get data takes host type as a parameter #3140

Merged
merged 2 commits into from
Jun 1, 2021
Merged

Conversation

NelsonVides
Copy link
Collaborator

This will be needed in order to correctly query the correct pools where is needed. We can see that it was already done for mod_mam in #3123, which in-place queries the host_type. We can just use it as a parameter to the function.

@codecov
Copy link

codecov bot commented May 31, 2021

Codecov Report

Merging #3140 (7458c1b) into master (6433bca) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3140      +/-   ##
==========================================
- Coverage   79.47%   79.46%   -0.01%     
==========================================
  Files         396      396              
  Lines       32419    32418       -1     
==========================================
- Hits        25764    25760       -4     
- Misses       6655     6658       +3     
Impacted Files Coverage Δ
src/inbox/mod_inbox.erl 90.14% <ø> (ø)
src/mam/mod_mam.erl 89.53% <ø> (-0.05%) ⬇️
src/mod_muc.erl 76.20% <ø> (ø)
src/mod_private.erl 84.21% <ø> (ø)
src/mod_roster.erl 76.85% <ø> (ø)
src/mod_vcard.erl 76.95% <ø> (ø)
src/offline/mod_offline.erl 77.47% <ø> (ø)
src/pubsub/mod_pubsub.erl 71.88% <ø> (ø)
src/mam/mod_mam_muc.erl 74.75% <100.00%> (ø)
src/mod_muc_room.erl 77.06% <100.00%> (+0.17%) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6433bca...7458c1b. Read the comment docs.

Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@chrzaszcz chrzaszcz merged commit 4970cc0 into master Jun 1, 2021
@chrzaszcz chrzaszcz deleted the multitenancy/gdpr branch June 1, 2021 10:50
@Premwoik Premwoik added this to the 5.0.0 milestone Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants