Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multitenancy/inbox #3141

Merged
merged 4 commits into from
Jun 1, 2021
Merged

Multitenancy/inbox #3141

merged 4 commits into from
Jun 1, 2021

Conversation

NelsonVides
Copy link
Collaborator

This PR most importantly enables (and fixes) muc/muclight tests for inbox and dynamic domains.

It also migrates inbox's backend to HostTypes in an orderly manner, following the pattern of the auth modules. As a side-note, some functions started taking too many parameters, so I made a type {LUser, LServer, RemBareJid}, which replicates the primary key that identifies inbox entries.

@codecov
Copy link

codecov bot commented May 31, 2021

Codecov Report

Merging #3141 (1f63c7b) into master (4970cc0) will increase coverage by 0.01%.
The diff coverage is 98.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3141      +/-   ##
==========================================
+ Coverage   79.49%   79.51%   +0.01%     
==========================================
  Files         397      397              
  Lines       32324    32320       -4     
==========================================
+ Hits        25695    25698       +3     
+ Misses       6629     6622       -7     
Impacted Files Coverage Δ
src/mod_muc.erl 76.32% <ø> (ø)
src/muc_light/mod_muc_light.erl 85.87% <ø> (ø)
src/inbox/mod_inbox.erl 89.70% <92.30%> (+0.05%) ⬆️
src/inbox/mod_inbox_entries.erl 98.36% <100.00%> (+0.02%) ⬆️
src/inbox/mod_inbox_muc.erl 91.17% <100.00%> (+0.26%) ⬆️
src/inbox/mod_inbox_muclight.erl 98.03% <100.00%> (+1.88%) ⬆️
src/inbox/mod_inbox_one2one.erl 100.00% <100.00%> (ø)
src/inbox/mod_inbox_rdbms.erl 92.50% <100.00%> (+1.64%) ⬆️
src/inbox/mod_inbox_utils.erl 94.28% <100.00%> (+1.23%) ⬆️
src/ejabberd_sm.erl 83.27% <0.00%> (-0.99%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4970cc0...1f63c7b. Read the comment docs.

Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good changes! I have a few comments.

big_tests/dynamic_domains.spec Show resolved Hide resolved
src/inbox/mod_inbox_muc.erl Outdated Show resolved Hide resolved
src/inbox/mod_inbox_muc.erl Outdated Show resolved Hide resolved
src/inbox/mod_inbox.erl Outdated Show resolved Hide resolved
Base automatically changed from multitenancy/gdpr to master June 1, 2021 10:50
@chrzaszcz chrzaszcz merged commit df42d26 into master Jun 1, 2021
@chrzaszcz chrzaszcz deleted the multitenancy/inbox branch June 1, 2021 11:53
@Premwoik Premwoik added this to the 5.0.0 milestone Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants