Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding offline_stub_SUITE #3142

Merged
merged 6 commits into from
Jun 1, 2021
Merged

Conversation

DenysGonchar
Copy link
Collaborator

mod_offline_stub doesn't require any conversion to support dynamic domains. Just added some simple offline_stub_SUITE to ensure that it's working correctly w/o any changes.

@codecov
Copy link

codecov bot commented Jun 1, 2021

Codecov Report

Merging #3142 (c492cf0) into master (df42d26) will decrease coverage by 0.03%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3142      +/-   ##
==========================================
- Coverage   79.52%   79.49%   -0.04%     
==========================================
  Files         397      397              
  Lines       32320    32321       +1     
==========================================
- Hits        25704    25695       -9     
- Misses       6616     6626      +10     
Impacted Files Coverage Δ
src/offline/mod_offline_stub.erl 88.88% <66.66%> (-11.12%) ⬇️
src/ejabberd_sm.erl 83.60% <100.00%> (+0.32%) ⬆️
src/mam/mod_mam_rdbms_async_pool_writer.erl 61.81% <0.00%> (-3.64%) ⬇️
...c/global_distrib/mod_global_distrib_server_mgr.erl 75.14% <0.00%> (-2.26%) ⬇️
src/cassandra/mongoose_cassandra_worker.erl 73.11% <0.00%> (-1.89%) ⬇️
src/global_distrib/mod_global_distrib_utils.erl 64.48% <0.00%> (-0.94%) ⬇️
src/muc_light/mod_muc_light.erl 85.13% <0.00%> (-0.75%) ⬇️
src/ejabberd_s2s_out.erl 60.36% <0.00%> (+0.22%) ⬆️
src/wpool/mongoose_wpool.erl 85.00% <0.00%> (+1.00%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df42d26...c492cf0. Read the comment docs.

Copy link
Collaborator

@NelsonVides NelsonVides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of comments, ready otherwise.

big_tests/tests/offline_stub_SUITE.erl Outdated Show resolved Hide resolved
big_tests/tests/offline_stub_SUITE.erl Outdated Show resolved Hide resolved
Copy link
Contributor

@arcusfelis arcusfelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

big_tests/tests/offline_stub_SUITE.erl Outdated Show resolved Hide resolved
@DenysGonchar DenysGonchar force-pushed the updating-mod_offline_stub-module branch from f9b10ed to 502f8a1 Compare June 1, 2021 07:34
Copy link
Collaborator

@NelsonVides NelsonVides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@DenysGonchar DenysGonchar force-pushed the updating-mod_offline_stub-module branch from 502f8a1 to 7fcc1e7 Compare June 1, 2021 07:40
Copy link
Collaborator

@NelsonVides NelsonVides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still 👍🏽 🙂

Copy link
Collaborator

@NelsonVides NelsonVides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, just waiting for CI now.

Copy link
Collaborator

@NelsonVides NelsonVides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@NelsonVides NelsonVides merged commit 85e657c into master Jun 1, 2021
@NelsonVides NelsonVides deleted the updating-mod_offline_stub-module branch June 1, 2021 13:17
@Premwoik Premwoik added this to the 5.0.0 milestone Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants