Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix metrics in mam suite #3143

Merged
merged 1 commit into from
Jun 1, 2021
Merged

Fix metrics in mam suite #3143

merged 1 commit into from
Jun 1, 2021

Conversation

gustawlippa
Copy link
Contributor

@gustawlippa gustawlippa commented Jun 1, 2021

This should fix the tests using metrics. Because we allow any string to be a host type, and in testing its <<"test type">> one has to ensure that the metrics are checked against a sanitised host type prefix, because metrics cannot contain spaces in their names.

@codecov
Copy link

codecov bot commented Jun 1, 2021

Codecov Report

Merging #3143 (1160df6) into master (6433bca) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3143      +/-   ##
==========================================
+ Coverage   79.47%   79.50%   +0.03%     
==========================================
  Files         396      396              
  Lines       32419    32419              
==========================================
+ Hits        25764    25774      +10     
+ Misses       6655     6645      -10     
Impacted Files Coverage Δ
src/event_pusher/mod_event_pusher_sns.erl 83.56% <0.00%> (-5.48%) ⬇️
src/mam/mod_mam_rdbms_async_pool_writer.erl 61.81% <0.00%> (-3.64%) ⬇️
...c/global_distrib/mod_global_distrib_server_mgr.erl 76.83% <0.00%> (-0.57%) ⬇️
src/mod_muc_log.erl 77.72% <0.00%> (ø)
src/mod_muc_room.erl 77.06% <0.00%> (+0.17%) ⬆️
src/ejabberd_c2s.erl 89.28% <0.00%> (+0.29%) ⬆️
src/ejabberd_sm.erl 84.59% <0.00%> (+0.65%) ⬆️
src/global_distrib/mod_global_distrib_utils.erl 65.42% <0.00%> (+0.93%) ⬆️
src/muc_light/mod_muc_light_utils.erl 90.81% <0.00%> (+1.02%) ⬆️
src/mam/mod_mam_elasticsearch_arch.erl 88.39% <0.00%> (+1.78%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6433bca...1160df6. Read the comment docs.

@gustawlippa gustawlippa marked this pull request as ready for review June 1, 2021 09:17
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@chrzaszcz chrzaszcz merged commit cdd2560 into master Jun 1, 2021
@chrzaszcz chrzaszcz deleted the metrics-in-suites branch June 1, 2021 09:25
@Premwoik Premwoik added this to the 5.0.0 milestone Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants