Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disco for MAM MIM-1412 #3155

Merged
merged 1 commit into from
Jun 16, 2021
Merged

Conversation

arcusfelis
Copy link
Contributor

@arcusfelis arcusfelis commented Jun 15, 2021

This PR addresses MIM-1412 "not working disco for mod_mam".

Proposed changes include:

  • just use HostType.

@arcusfelis arcusfelis changed the title Fix disco for MAM Fix disco for MAM MIM-1412 Jun 15, 2021
@codecov
Copy link

codecov bot commented Jun 15, 2021

Codecov Report

Merging #3155 (3e58495) into master (bc02e78) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3155      +/-   ##
==========================================
- Coverage   79.85%   79.83%   -0.03%     
==========================================
  Files         396      396              
  Lines       32343    32343              
==========================================
- Hits        25829    25820       -9     
- Misses       6514     6523       +9     
Impacted Files Coverage Δ
src/mam/mod_mam.erl 88.88% <100.00%> (ø)
src/mam/mod_mam_muc.erl 73.63% <100.00%> (ø)
src/mam/mod_mam_utils.erl 89.89% <100.00%> (ø)
src/pubsub/node_hometree.erl 77.77% <0.00%> (-5.56%) ⬇️
src/ejabberd_s2s_out.erl 60.13% <0.00%> (-1.83%) ⬇️
src/ejabberd_c2s.erl 89.06% <0.00%> (-0.52%) ⬇️
src/mod_muc_room.erl 77.10% <0.00%> (+0.17%) ⬆️
src/ejabberd_sm.erl 84.59% <0.00%> (+0.32%) ⬆️
src/pubsub/mod_pubsub_db_mnesia.erl 92.82% <0.00%> (+0.42%) ⬆️
src/ejabberd.erl 55.00% <0.00%> (+10.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc02e78...3e58495. Read the comment docs.

Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Base automatically changed from disco-with-dynamic-domains to master June 15, 2021 16:28
@arcusfelis arcusfelis force-pushed the mu-disco-with-dynamic-domains-fix-mam branch from 7cafc1a to 3e58495 Compare June 15, 2021 16:30
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@chrzaszcz chrzaszcz merged commit 0d82dc9 into master Jun 16, 2021
@chrzaszcz chrzaszcz deleted the mu-disco-with-dynamic-domains-fix-mam branch June 16, 2021 08:37
@Premwoik Premwoik added this to the 5.0.0 milestone Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants