Support dynamic domains in mod_offline #3164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3164 +/- ##
==========================================
+ Coverage 77.41% 80.20% +2.78%
==========================================
Files 396 396
Lines 32306 32316 +10
==========================================
+ Hits 25010 25918 +908
+ Misses 7296 6398 -898
Continue to review full report at Codecov.
|
chrzaszcz
force-pushed
the
offline-with-dynamic-domains
branch
4 times, most recently
from
1af8fec
to
6de2566
Compare
Update the backend callbacks. The tests will not pass until the backend modules are also updated. Also: clean up comments and type specs.
- Add type specs to callbacks - Let the remove_*_messages functions remove only the messages for the provided LServer, not for all domains. This is done in a simple way, it can be optimized later if needed.
- Add type specs to callbacks - Let the remove_*_messages functions remove only the messages for the provided LServer, not for all domains. This is done in a simple way, it can be optimized later if needed.
Enable it conditionally in the config template.
Also:
- Rearrange newlines to make both the templates and the resulting files
more readable.
The only inconsitency is the indentation in case of multiple
options.
It's a corner case not occuring atm and it will not affect
the default config visible to the end user - only the dev config
for mim1.
There will be a PR in the future which will unify the templating
for all modules.
- Do not set options with values same as the default ones.
Also: - Add specs - Simplify calling resend_offline_messages_hook
chrzaszcz
force-pushed
the
offline-with-dynamic-domains
branch
from
129ed2a
to
aad2505
Compare
NelsonVides
reviewed
Jul 7, 2021
Comment on lines
+224
to
+226
| {{#mod_cache_users}} | ||
| [modules.mod_cache_users] | ||
| {{{mod_cache_users}}} |
There was a problem hiding this comment.
This disables this module in the prod config.
There was a problem hiding this comment.
It is only a whitespace change, it cannot disable anything.
There was a problem hiding this comment.
It was disabled before and remains unchanged. Let's change this in a separate PR.
NelsonVides
reviewed
Jul 7, 2021
arcusfelis
reviewed
Jul 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes:
mod_offlineand its backends.Side changes:
remove_*_messagesto only remove messages for the domain that was provided. The backends were behaving inconsistently before (it worked as expected only for Riak).Not included in this PR:
mod_offline_chatmarkers. This is an undocumented module which is disabled by default.okis returned. I didn't want to change too much and these issues don't seem to be critical. It's a bit out of scope as well.