Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hooks rework #3174

Merged
merged 14 commits into from
Jul 16, 2021
Merged

Hooks rework #3174

merged 14 commits into from
Jul 16, 2021

Conversation

DenysGonchar
Copy link
Collaborator

@DenysGonchar DenysGonchar commented Jul 6, 2021

This PR introduces initial rework of the hooks framework

The key changes:

  • hook handler functions now have fixed number of arguments:
    • Acc - the same meaning as before
    • Parameters map - input parameters are now provided in a form of map instead of variable number of handler function arguments
    • Extra map - every hook handler now can have a static context, in the same way as packet handlers. This map is automatically extended with hook_name and hook_tag (global or HostType) parameters on hook registration, so there is no need to add HostType into Parameters map any more.
  • the old format of hook handlers is still supported (until the full conversion of all the hook handlers is done)
  • conversion of the hooks can be done hook by hook, the following steps must be done to convert the hook:
    • convert hook execution function at mongoose_hooks module.
    • convert all the handlers of the hook (they must be registered using gen_hook interface instead of ejabberd_hook).
    • also, it's possible to mix old & new hook handlers formats (see example at mongoose_hooks:push_notifications/4).
  • note that gen_hook accepts only external function references (in format fun Module:Function/Arity, e.g. fun erlang:is_function/1) as hook handler function parameter.

@mongoose-im

This comment has been minimized.

@codecov
Copy link

codecov bot commented Jul 6, 2021

Codecov Report

Merging #3174 (9463958) into master (fbac330) will decrease coverage by 0.03%.
The diff coverage is 93.10%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3174      +/-   ##
==========================================
- Coverage   80.32%   80.29%   -0.04%     
==========================================
  Files         396      397       +1     
  Lines       32348    32395      +47     
==========================================
+ Hits        25984    26010      +26     
- Misses       6364     6385      +21     
Impacted Files Coverage Δ
src/ejabberd_sup.erl 85.71% <ø> (ø)
src/gen_hook.erl 86.48% <86.48%> (ø)
src/mongoose_hooks.erl 95.10% <96.02%> (+0.14%) ⬆️
src/ejabberd_hooks.erl 100.00% <100.00%> (+13.84%) ⬆️
src/mod_roster_riak.erl 81.53% <0.00%> (-15.39%) ⬇️
src/elasticsearch/mongoose_elasticsearch.erl 76.92% <0.00%> (-7.70%) ⬇️
src/pubsub/node_hometree.erl 77.77% <0.00%> (-5.56%) ⬇️
src/jingle_sip/mod_jingle_sip_backend.erl 80.00% <0.00%> (-5.00%) ⬇️
src/mam/mod_mam_elasticsearch_arch.erl 86.60% <0.00%> (-1.79%) ⬇️
src/ejabberd_s2s_out.erl 60.82% <0.00%> (-1.60%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbac330...9463958. Read the comment docs.

@mongoose-im

This comment has been minimized.

@mongoose-im

This comment has been minimized.

@mongoose-im

This comment has been minimized.

for OTP versions prior to 23, local function references in format like fun some_fun/2 behave in the same way as anonymous functions. different places in code generate different references. in addition to that local fun references are not code-reload safe, so it’s better to use external fun references only.

It's still a good idea to use function references, because it allows dialyzer to check the handler function specs.
@mongoose-im
Copy link
Collaborator

mongoose-im commented Jul 13, 2021

small_tests_21_3 / small_tests / 75b93b1
Reports root / small


small_tests_22 / small_tests / 75b93b1
Reports root / small


dynamic_domains / pgsql_mnesia / 75b93b1
Reports root/ big
OK: 1565 / Failed: 0 / User-skipped: 121 / Auto-skipped: 0


small_tests_23 / small_tests / 75b93b1
Reports root / small


ldap_mnesia_21 / ldap_mnesia / 75b93b1
Reports root/ big
OK: 1514 / Failed: 0 / User-skipped: 359 / Auto-skipped: 0


ldap_mnesia_23 / ldap_mnesia / 75b93b1
Reports root/ big
OK: 1514 / Failed: 0 / User-skipped: 359 / Auto-skipped: 0


ldap_mnesia_22 / ldap_mnesia / 75b93b1
Reports root/ big
OK: 1514 / Failed: 0 / User-skipped: 359 / Auto-skipped: 0


internal_mnesia / internal_mnesia / 75b93b1
Reports root/ big
OK: 1587 / Failed: 0 / User-skipped: 286 / Auto-skipped: 0


pgsql_mnesia / pgsql_mnesia / 75b93b1
Reports root/ big
OK: 3084 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


elasticsearch_and_cassandra / elasticsearch_and_cassandra_mnesia / 75b93b1
Reports root/ big
OK: 1890 / Failed: 0 / User-skipped: 282 / Auto-skipped: 0


mysql_redis / mysql_redis / 75b93b1
Reports root/ big
OK: 3067 / Failed: 0 / User-skipped: 201 / Auto-skipped: 0


mssql_mnesia / odbc_mssql_mnesia / 75b93b1
Reports root/ big
OK: 3083 / Failed: 0 / User-skipped: 184 / Auto-skipped: 1


riak_mnesia / riak_mnesia / 75b93b1
Reports root/ big
OK: 1737 / Failed: 0 / User-skipped: 285 / Auto-skipped: 0

@mongoose-im
Copy link
Collaborator

mongoose-im commented Jul 13, 2021

small_tests_22 / small_tests / 2ec4c5d
Reports root / small


dynamic_domains / pgsql_mnesia / 2ec4c5d
Reports root/ big
OK: 1565 / Failed: 0 / User-skipped: 121 / Auto-skipped: 0


small_tests_23 / small_tests / 2ec4c5d
Reports root / small


small_tests_21_3 / small_tests / 2ec4c5d
Reports root / small


ldap_mnesia_22 / ldap_mnesia / 2ec4c5d
Reports root/ big
OK: 1514 / Failed: 0 / User-skipped: 359 / Auto-skipped: 0


ldap_mnesia_23 / ldap_mnesia / 2ec4c5d
Reports root/ big
OK: 1514 / Failed: 0 / User-skipped: 359 / Auto-skipped: 0


internal_mnesia / internal_mnesia / 2ec4c5d
Reports root/ big
OK: 1587 / Failed: 0 / User-skipped: 286 / Auto-skipped: 0


ldap_mnesia_21 / ldap_mnesia / 2ec4c5d
Reports root/ big
OK: 1532 / Failed: 1 / User-skipped: 359 / Auto-skipped: 0

jingle_SUITE:all:resp_4xx_from_sip_proxy_results_in_session_terminate
{error,
  {{assertion_failed,assert,is_iq_result,
     {xmlel,<<"iq">>,
       [{<<"from">>,<<"error.480@localhost">>},
        {<<"to">>,
         <<"alice_resp_4xx_from_sip_proxy_results_in_session_terminate_13.712116@localhost/res1">>},
        {<<"id">>,<<"b0333d76-ab80-4bd4-a8d9-5e5f6fa57803">>},
        {<<"type">>,<<"set">>}],
       [{xmlel,<<"jingle">>,
          [{<<"xmlns">>,<<"urn:xmpp:jingle:1">>},
           {<<"action">>,<<"session-terminate">>},
           {<<"sid">>,<<"db8874a5-150f-452c-9323-c8de2ea3ee11">>}],
          [{xmlel,<<"reason">>,[],
             [{xmlel,<<"general-error">>,[],[]},
            {xmlel,<<"sip-error">>,
              [{<<"code">>,<<"480">>}],
              [{xmlcdata,<<"Temporarily Unavailable">>}]}]}]}]},
     "<iq from='error.480@localhost' to='alice_resp_4xx_from_sip_proxy_results_in_session_terminate_13.712116@localhost/res1' id='b0333d76-ab80-4bd4-a8d9-5e5f6fa57803' type='set'><jingle xmlns='urn:xmpp:jingle:1' action='session-terminate' sid='db8874a5-150f-452c-9323-c8de2ea3ee11'><reason><general-error/><sip-error code='480'>Temporarily Unavailable</sip-error></reason></jingle></iq>"},
   [{escalus_new_assert,assert_true,2,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
       {line,84}]},
    {jingle_SUITE,send_initiate_and_wait_for_first_iq_set,2,
      [{file,"/home/circleci/app/big_tests/tests/jingle_SUITE.erl"},
       {line,393}]},
    {jingle_SUITE,
      '-res...

Report log


mysql_redis / mysql_redis / 2ec4c5d
Reports root/ big
OK: 3067 / Failed: 0 / User-skipped: 201 / Auto-skipped: 0


elasticsearch_and_cassandra / elasticsearch_and_cassandra_mnesia / 2ec4c5d
Reports root/ big
OK: 1890 / Failed: 0 / User-skipped: 282 / Auto-skipped: 0


pgsql_mnesia / pgsql_mnesia / 2ec4c5d
Reports root/ big
OK: 3084 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


mssql_mnesia / odbc_mssql_mnesia / 2ec4c5d
Reports root/ big
OK: 3096 / Failed: 7 / User-skipped: 184 / Auto-skipped: 0

inbox_SUITE:one_to_one:reset_unread_counter_and_show_only_unread
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"mike_reset_unread_counter_and_show_only_unread_57.440722@localhost/res1">>,
          escalus_tcp,<0.17867.0>,
          [{event_manager,<0.17778.0>},
           {server,<<"localhost">>},
           {username,
             <<"mike_reset_unread_counter_and_show_only_unread_57.440722">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.17778.0>},
            {server,<<"localhost">>},
            {username,
              <<"mike_reset_unread_counter_and_show_only_unread_57.440722">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"mike_reset_unread_counter_and_show_only_unread_57.440722">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,
             <<"mike_reset_unread_counter_and_show_only_unread_57.440722">>},
           {server,<<"localhost">>},
           {password,<<"nicniema">>},
           {stream_id,<<"b2a4e009808c78a2">>}]},
        5000],
       [{file,
          "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {inbox_helper,send_msg,3,
       [{file,"/home/circleci/app/big_tests/tests/inbox_helper.erl"},
        {line,700}]},
     {inbox_SUITE,'-r...

Report log

inbox_SUITE:one_to_one:check_total_unread_count_and_active_conv_count
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"mike_check_total_unread_count_and_active_conv_count_57.438276@localhost/res1">>,
          escalus_tcp,<0.17854.0>,
          [{event_manager,<0.17771.0>},
           {server,<<"localhost">>},
           {username,
             <<"mike_check_total_unread_count_and_active_conv_count_57.438276">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.17771.0>},
            {server,<<"localhost">>},
            {username,
              <<"mike_check_total_unread_count_and_active_conv_count_57.438276">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"mike_check_total_unread_count_and_active_conv_count_57.438276">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,
             <<"mike_check_total_unread_count_and_active_conv_count_57.438276">>},
           {server,<<"localhost">>},
           {password,<<"nicniema">>},
           {stream_id,<<"bfcaf8dc42c0dbe5">>}]},
        5000],
       [{file,
          "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {inbox_helper,send_msg,3,
       [{file,"/home/circleci/app/big_tests/tests/inbox_helper.erl"},
        {line,700}...

Report log

inbox_SUITE:one_to_one:user_has_only_unread_messages_or_only_read
{error,{{badmatch,0},
    [{escalus_story,drop_presences,2,
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,191}]},
     {escalus_story,'-start_ready_clients/2-fun-0-',3,
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,135}]},
     {lists,foldl,3,[{file,"lists.erl"},{line,1263}]},
     {escalus_story,start_ready_clients,2,
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,128}]},
     {lists,flatmap,2,[{file,"lists.erl"},{line,1250}]},
     {lists,flatmap,2,[{file,"lists.erl"},{line,1250}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,69}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1754}]}]}}

Report log

inbox_SUITE:one_to_one:non_reset_marker_should_not_affect_inbox
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"kate_non_reset_marker_should_not_affect_inbox_57.459208@localhost/res1">>,
          escalus_tcp,<0.17835.0>,
          [{event_manager,<0.17806.0>},
           {server,<<"localhost">>},
           {username,
             <<"kate_non_reset_marker_should_not_affect_inbox_57.459208">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.17806.0>},
            {server,<<"localhost">>},
            {username,
              <<"kate_non_reset_marker_should_not_affect_inbox_57.459208">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"kate_non_reset_marker_should_not_affect_inbox_57.459208">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,
             <<"kate_non_reset_marker_should_not_affect_inbox_57.459208">>},
           {server,<<"localhost">>},
           {password,<<"makrowe;p">>},
           {stream_id,<<"8f6fac4b20097080">>}]},
        5000],
       [{file,
          "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {inbox_helper,get_inbox,3,
       [{file,"/home/circleci/app/big_tests/tests/inbox_helper.erl"},
        {line,219}]},
     {inbox_helper,check...

Report log

inbox_SUITE:one_to_one:carbons_are_not_stored
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"bOb_carbons_are_not_stored_57.400720@localhost/res1">>,
          escalus_tcp,<0.17857.0>,
          [{event_manager,<0.17708.0>},
           {server,<<"localhost">>},
           {username,<<"bOb_carbons_are_not_stored_57.400720">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.17708.0>},
            {server,<<"localhost">>},
            {username,<<"bOb_carbons_are_not_stored_57.400720">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"bOb_carbons_are_not_stored_57.400720">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,<<"bOb_carbons_are_not_stored_57.400720">>},
           {server,<<"localhost">>},
           {password,<<"makrolika">>},
           {stream_id,<<"79c89cf4b5bc2a15">>}]},
        5000],
       [{file,
          "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {inbox_helper,'-given_conversations_between/2-fun-1-',4,
       [{file,"/home/circleci/app/big_tests/tests/inbox_helper.erl"},
        {line,418}]},
     {lists,foldl,3,[{file,"lists.erl"},{line,1263}]},
     {inbox_SUITE,'-carbons_are_not_stored/1-fun-0-',4,
       [{file,"/home/circleci/app/b...

Report log

inbox_SUITE:one_to_one:other_resources_do_not_interfere
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"mike_other_resources_do_not_interfere_57.433533@localhost/res1">>,
          escalus_tcp,<0.17901.0>,
          [{event_manager,<0.17764.0>},
           {server,<<"localhost">>},
           {username,
             <<"mike_other_resources_do_not_interfere_57.433533">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.17764.0>},
            {server,<<"localhost">>},
            {username,
              <<"mike_other_resources_do_not_interfere_57.433533">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"mike_other_resources_do_not_interfere_57.433533">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,
             <<"mike_other_resources_do_not_interfere_57.433533">>},
           {server,<<"localhost">>},
           {password,<<"nicniema">>},
           {stream_id,<<"f074f25c849bd33d">>}]},
        5000],
       [{file,
          "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {inbox_helper,send_msg,3,
       [{file,"/home/circleci/app/big_tests/tests/inbox_helper.erl"},
        {line,700}]},
     {inbox_SUITE,'-other_resources_do_not_interfere/1-fun-2-',3,
...

Report log

inbox_SUITE:one_to_one:user_has_two_conversations
{error,{badarg,[{erlang,binary_to_integer,[undefined],[]},
        {inbox_helper,get_result_el,2,
                [{file,"/home/circleci/app/big_tests/tests/inbox_helper.erl"},
                 {line,234}]},
        {inbox_helper,'-check_result/2-fun-0-',3,
                [{file,"/home/circleci/app/big_tests/tests/inbox_helper.erl"},
                 {line,239}]},
        {maps,filter_1,2,[{file,"maps.erl"},{line,206}]},
        {maps,filter,2,[{file,"maps.erl"},{line,197}]},
        {inbox_helper,get_inbox,3,
                [{file,"/home/circleci/app/big_tests/tests/inbox_helper.erl"},
                 {line,220}]},
        {inbox_helper,check_inbox,4,
                [{file,"/home/circleci/app/big_tests/tests/inbox_helper.erl"},
                 {line,165}]},
        {inbox_SUITE,'-user_has_two_conversations/1-fun-0-',3,
               [{file,"/home/circleci/app/big_tests/tests/inbox_SUITE.erl"},
                {line,483}]}]}}

Report log


riak_mnesia / riak_mnesia / 2ec4c5d
Reports root/ big
OK: 1737 / Failed: 0 / User-skipped: 285 / Auto-skipped: 0

@mongoose-im
Copy link
Collaborator

mongoose-im commented Jul 14, 2021

small_tests_21_3 / small_tests / 9e2d73c
Reports root / small


dynamic_domains / pgsql_mnesia / 9e2d73c
Reports root/ big
OK: 1565 / Failed: 0 / User-skipped: 121 / Auto-skipped: 0


small_tests_22 / small_tests / 9e2d73c
Reports root / small


small_tests_23 / small_tests / 9e2d73c
Reports root / small


ldap_mnesia_21 / ldap_mnesia / 9e2d73c
Reports root/ big
OK: 1514 / Failed: 0 / User-skipped: 359 / Auto-skipped: 0


ldap_mnesia_22 / ldap_mnesia / 9e2d73c
Reports root/ big
OK: 1514 / Failed: 0 / User-skipped: 359 / Auto-skipped: 0


internal_mnesia / internal_mnesia / 9e2d73c
Reports root/ big
OK: 1587 / Failed: 0 / User-skipped: 286 / Auto-skipped: 0


ldap_mnesia_23 / ldap_mnesia / 9e2d73c
Reports root/ big
OK: 1514 / Failed: 0 / User-skipped: 359 / Auto-skipped: 0


elasticsearch_and_cassandra / elasticsearch_and_cassandra_mnesia / 9e2d73c
Reports root/ big
OK: 1890 / Failed: 0 / User-skipped: 282 / Auto-skipped: 0


mysql_redis / mysql_redis / 9e2d73c
Reports root/ big
OK: 3067 / Failed: 0 / User-skipped: 201 / Auto-skipped: 0


pgsql_mnesia / pgsql_mnesia / 9e2d73c
Reports root/ big
OK: 3081 / Failed: 0 / User-skipped: 184 / Auto-skipped: 3


mssql_mnesia / odbc_mssql_mnesia / 9e2d73c
Reports root/ big
OK: 3067 / Failed: 16 / User-skipped: 184 / Auto-skipped: 1

inbox_extensions_SUITE:inbox_extensions:one_to_one:archive_archived_entry_gets_active_for_the_receiver_on_new_message
{error,{{badmatch,0},
    [{escalus_story,drop_presences,2,
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,191}]},
     {escalus_story,'-start_ready_clients/2-fun-0-',3,
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,135}]},
     {lists,foldl,3,[{file,"lists.erl"},{line,1263}]},
     {escalus_story,start_ready_clients,2,
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,128}]},
     {lists,flatmap,2,[{file,"lists.erl"},{line,1250}]},
     {lists,flatmap,2,[{file,"lists.erl"},{line,1250}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,69}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1754}]}]}}

Report log

inbox_extensions_SUITE:inbox_extensions:one_to_one:properties_can_be_get
{error,{{badmatch,0},
    [{escalus_story,drop_presences,2,
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,191}]},
     {escalus_story,'-start_ready_clients/2-fun-0-',3,
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,135}]},
     {lists,foldl,3,[{file,"lists.erl"},{line,1263}]},
     {escalus_story,start_ready_clients,2,
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,128}]},
     {lists,flatmap,2,[{file,"lists.erl"},{line,1250}]},
     {lists,flatmap,2,[{file,"lists.erl"},{line,1250}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,69}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1754}]}]}}

Report log

inbox_extensions_SUITE:inbox_extensions:one_to_one:timestamp_is_not_reset_with_setting_properties
{error,{{badmatch,0},
    [{escalus_story,drop_presences,2,
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,191}]},
     {escalus_story,'-start_ready_clients/2-fun-0-',3,
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,135}]},
     {lists,foldl,3,[{file,"lists.erl"},{line,1263}]},
     {escalus_story,start_ready_clients,2,
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,128}]},
     {lists,flatmap,2,[{file,"lists.erl"},{line,1250}]},
     {lists,flatmap,2,[{file,"lists.erl"},{line,1250}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,69}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1754}]}]}}

Report log

inbox_extensions_SUITE:inbox_extensions:one_to_one:mute_muted_conv_restarts_timestamp
{error,{{badmatch,0},
    [{escalus_story,drop_presences,2,
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,191}]},
     {escalus_story,'-start_ready_clients/2-fun-0-',3,
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,135}]},
     {lists,foldl,3,[{file,"lists.erl"},{line,1263}]},
     {escalus_story,start_ready_clients,2,
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,128}]},
     {lists,flatmap,2,[{file,"lists.erl"},{line,1250}]},
     {lists,flatmap,2,[{file,"lists.erl"},{line,1250}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,69}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1754}]}]}}

Report log

inbox_extensions_SUITE:inbox_extensions:one_to_one:archive_full_archive_can_be_fetched
{error,{{badmatch,0},
    [{escalus_story,drop_presences,2,
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,191}]},
     {escalus_story,'-start_ready_clients/2-fun-0-',3,
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,135}]},
     {lists,foldl,3,[{file,"lists.erl"},{line,1263}]},
     {escalus_story,start_ready_clients,2,
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,128}]},
     {lists,flatmap,2,[{file,"lists.erl"},{line,1250}]},
     {lists,flatmap,2,[{file,"lists.erl"},{line,1250}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,69}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1754}]}]}}

Report log

inbox_extensions_SUITE:inbox_extensions:one_to_one:archive_active_entry_gets_archived
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"bOb_archive_active_entry_gets_archived_71.764252@localhost/res1">>,
          escalus_tcp,<0.18969.0>,
          [{event_manager,<0.18838.0>},
           {server,<<"localhost">>},
           {username,
             <<"bOb_archive_active_entry_gets_archived_71.764252">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.18838.0>},
            {server,<<"localhost">>},
            {username,
              <<"bOb_archive_active_entry_gets_archived_71.764252">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"bOb_archive_active_entry_gets_archived_71.764252">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,
             <<"bOb_archive_active_entry_gets_archived_71.764252">>},
           {server,<<"localhost">>},
           {password,<<"makrolika">>},
           {stream_id,<<"9fc76806aa0f9bc4">>}]},
        5000],
       [{file,
          "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {inbox_helper,send_msg,3,
       [{file,"/home/circleci/app/big_tests/tests/inbox_helper.erl"},
        {line,700}]},
     {inbox_helper,send_and_mark_msg,3,
       [{file,"/home...

Report log

inbox_extensions_SUITE:inbox_extensions:one_to_one:archive_archived_entry_gets_active_on_request
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"bOb_archive_archived_entry_gets_active_on_request_71.766556@localhost/res1">>,
          escalus_tcp,<0.18968.0>,
          [{event_manager,<0.18859.0>},
           {server,<<"localhost">>},
           {username,
             <<"bOb_archive_archived_entry_gets_active_on_request_71.766556">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.18859.0>},
            {server,<<"localhost">>},
            {username,
              <<"bOb_archive_archived_entry_gets_active_on_request_71.766556">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"bOb_archive_archived_entry_gets_active_on_request_71.766556">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,
             <<"bOb_archive_archived_entry_gets_active_on_request_71.766556">>},
           {server,<<"localhost">>},
           {password,<<"makrolika">>},
           {stream_id,<<"239b74504e726b52">>}]},
        5000],
       [{file,
          "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {inbox_helper,send_msg,3,
       [{file,"/home/circleci/app/big_tests/tests/inbox_helper.erl"},
        {line,700}]},
     ...

Report log

inbox_extensions_SUITE:inbox_extensions:one_to_one:max_queries_can_be_limited
{error,{{badmatch,0},
    [{escalus_story,drop_presences,2,
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,191}]},
     {escalus_story,'-start_ready_clients/2-fun-0-',3,
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,135}]},
     {lists,foldl,3,[{file,"lists.erl"},{line,1263}]},
     {escalus_story,start_ready_clients,2,
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,128}]},
     {lists,flatmap,2,[{file,"lists.erl"},{line,1250}]},
     {lists,flatmap,2,[{file,"lists.erl"},{line,1250}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,69}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1754}]}]}}

Report log

inbox_extensions_SUITE:inbox_extensions:one_to_one:max_queries_can_fetch_ahead
{error,{{badmatch,0},
    [{escalus_story,drop_presences,2,
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,191}]},
     {escalus_story,'-start_ready_clients/2-fun-0-',3,
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,135}]},
     {lists,foldl,3,[{file,"lists.erl"},{line,1263}]},
     {escalus_story,start_ready_clients,2,
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,128}]},
     {lists,flatmap,2,[{file,"lists.erl"},{line,1250}]},
     {lists,flatmap,2,[{file,"lists.erl"},{line,1250}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,69}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1754}]}]}}

Report log

inbox_extensions_SUITE:inbox_extensions:one_to_one:properties_many_can_be_set
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"bOb_properties_many_can_be_set_71.792923@localhost/res1">>,
          escalus_tcp,<0.18986.0>,
          [{event_manager,<0.18908.0>},
           {server,<<"localhost">>},
           {username,<<"bOb_properties_many_can_be_set_71.792923">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.18908.0>},
            {server,<<"localhost">>},
            {username,
              <<"bOb_properties_many_can_be_set_71.792923">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"bOb_properties_many_can_be_set_71.792923">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,<<"bOb_properties_many_can_be_set_71.792923">>},
           {server,<<"localhost">>},
           {password,<<"makrolika">>},
           {stream_id,<<"382a667123ffeef8">>}]},
        5000],
       [{file,
          "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {inbox_helper,send_msg,3,
       [{file,"/home/circleci/app/big_tests/tests/inbox_helper.erl"},
        {line,700}]},
     {inbox_extensions_SUITE,'-properties_many_can_be_set/1-fun-1-',2,
       [{file,
          "/home/circleci/app/big_tests/tests/inbox_exte...

Report log

inbox_extensions_SUITE:inbox_extensions:one_to_one:archive_archived_entry_gets_active_for_the_sender_on_new_message
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"bOb_archive_archived_entry_gets_active_for_the_sender_on_new_message_71.762174@localhost/res1">>,
          escalus_tcp,<0.18965.0>,
          [{event_manager,<0.18852.0>},
           {server,<<"localhost">>},
           {username,
             <<"bOb_archive_archived_entry_gets_active_for_the_sender_on_new_message_71.762174">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.18852.0>},
            {server,<<"localhost">>},
            {username,
              <<"bOb_archive_archived_entry_gets_active_for_the_sender_on_new_message_71.762174">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"bOb_archive_archived_entry_gets_active_for_the_sender_on_new_message_71.762174">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,
             <<"bOb_archive_archived_entry_gets_active_for_the_sender_on_new_message_71.762174">>},
           {server,<<"localhost">>},
           {password,<<"makrolika">>},
           {stream_id,<<"c04eceba38829164">>}]},
        5000],
       [{file,
          "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {inbox_helper,send_msg,3,
  ...

Report log

inbox_extensions_SUITE:inbox_extensions:one_to_one:mute_unmuted_entry_gets_muted
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"bOb_mute_unmuted_entry_gets_muted_71.769603@localhost/res1">>,
          escalus_tcp,<0.18984.0>,
          [{event_manager,<0.18866.0>},
           {server,<<"localhost">>},
           {username,
             <<"bOb_mute_unmuted_entry_gets_muted_71.769603">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.18866.0>},
            {server,<<"localhost">>},
            {username,
              <<"bOb_mute_unmuted_entry_gets_muted_71.769603">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"bOb_mute_unmuted_entry_gets_muted_71.769603">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,
             <<"bOb_mute_unmuted_entry_gets_muted_71.769603">>},
           {server,<<"localhost">>},
           {password,<<"makrolika">>},
           {stream_id,<<"14137ed7c8d359a4">>}]},
        5000],
       [{file,
          "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {inbox_helper,send_msg,3,
       [{file,"/home/circleci/app/big_tests/tests/inbox_helper.erl"},
        {line,700}]},
     {inbox_helper,send_and_mark_msg,3,
       [{file,"/home/circleci/app/big_tests/t...

Report log

inbox_extensions_SUITE:inbox_extensions:one_to_one:archive_active_unread_entry_gets_archived_and_still_unread
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"bOb_archive_active_unread_entry_gets_archived_and_still_unread_71.786613@localhost/res1">>,
          escalus_tcp,<0.18971.0>,
          [{event_manager,<0.18889.0>},
           {server,<<"localhost">>},
           {username,
             <<"bOb_archive_active_unread_entry_gets_archived_and_still_unread_71.786613">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.18889.0>},
            {server,<<"localhost">>},
            {username,
              <<"bOb_archive_active_unread_entry_gets_archived_and_still_unread_71.786613">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"bOb_archive_active_unread_entry_gets_archived_and_still_unread_71.786613">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,
             <<"bOb_archive_active_unread_entry_gets_archived_and_still_unread_71.786613">>},
           {server,<<"localhost">>},
           {password,<<"makrolika">>},
           {stream_id,<<"b06dd94f1c333cb8">>}]},
        5000],
       [{file,
          "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {inbox_helper,send_msg,3,
       [{file,"/home/circleci/ap...

Report log

inbox_extensions_SUITE:inbox_extensions:one_to_one:mute_muted_entry_gets_unmuted
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"bOb_mute_muted_entry_gets_unmuted_71.779697@localhost/res1">>,
          escalus_tcp,<0.18980.0>,
          [{event_manager,<0.18873.0>},
           {server,<<"localhost">>},
           {username,
             <<"bOb_mute_muted_entry_gets_unmuted_71.779697">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.18873.0>},
            {server,<<"localhost">>},
            {username,
              <<"bOb_mute_muted_entry_gets_unmuted_71.779697">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"bOb_mute_muted_entry_gets_unmuted_71.779697">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,
             <<"bOb_mute_muted_entry_gets_unmuted_71.779697">>},
           {server,<<"localhost">>},
           {password,<<"makrolika">>},
           {stream_id,<<"db0df1a8b94524c2">>}]},
        5000],
       [{file,
          "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {inbox_helper,send_msg,3,
       [{file,"/home/circleci/app/big_tests/tests/inbox_helper.erl"},
        {line,700}]},
     {inbox_helper,send_and_mark_msg,3,
       [{file,"/home/circleci/app/big_tests/t...

Report log

inbox_extensions_SUITE:inbox_extensions:one_to_one:mute_after_timestamp_gets_unmuted
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"bOb_mute_after_timestamp_gets_unmuted_71.783456@localhost/res1">>,
          escalus_tcp,<0.18966.0>,
          [{event_manager,<0.18880.0>},
           {server,<<"localhost">>},
           {username,
             <<"bOb_mute_after_timestamp_gets_unmuted_71.783456">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.18880.0>},
            {server,<<"localhost">>},
            {username,
              <<"bOb_mute_after_timestamp_gets_unmuted_71.783456">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"bOb_mute_after_timestamp_gets_unmuted_71.783456">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,
             <<"bOb_mute_after_timestamp_gets_unmuted_71.783456">>},
           {server,<<"localhost">>},
           {password,<<"makrolika">>},
           {stream_id,<<"933375aa1d114f76">>}]},
        5000],
       [{file,
          "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {inbox_extensions_SUITE,check_message_with_properties,3,
       [{file,
          "/home/circleci/app/big_tests/tests/inbox_extensions_SUITE.erl"},
        {line,635}]},
     {inbox_e...

Report log

inbox_extensions_SUITE:inbox_extensions:one_to_one:read_unread_entry_with_two_messages_when_set_unread_then_unread_count_stays_in_two
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"bOb_read_unread_entry_with_two_messages_when_set_unread_then_unread_count_stays_in_two_71.755515@localhost/res1">>,
          escalus_tcp,<0.18963.0>,
          [{event_manager,<0.18831.0>},
           {server,<<"localhost">>},
           {username,
             <<"bOb_read_unread_entry_with_two_messages_when_set_unread_then_unread_count_stays_in_two_71.755515">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.18831.0>},
            {server,<<"localhost">>},
            {username,
              <<"bOb_read_unread_entry_with_two_messages_when_set_unread_then_unread_count_stays_in_two_71.755515">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"bOb_read_unread_entry_with_two_messages_when_set_unread_then_unread_count_stays_in_two_71.755515">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,
             <<"bOb_read_unread_entry_with_two_messages_when_set_unread_then_unread_count_stays_in_two_71.755515">>},
           {server,<<"localhost">>},
           {password,<<"makrolika">>},
           {stream_id,<<"b70178870f9ce5a5">>}]},
        5000],
       [{file,
          "/home/circleci/app/big_tests/_build/default/lib...

Report log


riak_mnesia / riak_mnesia / 9e2d73c
Reports root/ big
OK: 1740 / Failed: 1 / User-skipped: 285 / Auto-skipped: 0

mod_event_pusher_rabbit_SUITE:group_chat_message_publish:group_chat_message_received_event_properly_formatted
{error,
  {{assertMatch,
     [{module,mod_event_pusher_rabbit_SUITE},
      {line,435},
      {expression,
        "get_decoded_message_from_rabbit ( AliceGroupChatMsgRecvRK )"},
      {pattern,
        "# { << \"from_user_id\" >> := BobRoomJID , << \"to_user_id\" >> := AliceFullJID , << \"message\" >> := Message }"},
      {value,
        #{<<"from_user_id">> => <<"muc_publish@muc.localhost">>,
        <<"message">> => <<>>,
        <<"to_user_id">> =>
          <<"alice_unnamed_20.772310@localhost/res1">>}}]},
   [{mod_event_pusher_rabbit_SUITE,
      '-group_chat_message_received_event_properly_formatted/1-fun-0-',3,
      [{file,
         "/home/circleci/app/big_tests/tests/mod_event_pusher_rabbit_SUITE.erl"},
       {line,435}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1754}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1263}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1195}]}]}}

Report log

Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, thanks for the changes. I have a few minor comments.

big_tests/tests/sm_SUITE.erl Outdated Show resolved Hide resolved
big_tests/tests/sm_SUITE.erl Outdated Show resolved Hide resolved
src/ejabberd_hooks.erl Outdated Show resolved Hide resolved
src/gen_hook.erl Outdated Show resolved Hide resolved
src/gen_hook.erl Outdated Show resolved Hide resolved
src/gen_hook.erl Outdated Show resolved Hide resolved
src/gen_hook.erl Show resolved Hide resolved
src/gen_hook.erl Outdated Show resolved Hide resolved
src/mongoose_hooks.erl Show resolved Hide resolved
This branch introduces initial rework of the hooks framework

The key changes:
* hook handler functions now have fixed number of arguments:
   - Acc - the same meaning as before
   - Parameters map - input parameters are now provided in a form of map instead of variable number of handler function arguments
   - Extra map - every hook handler now can have a static context, in the same way as packet handlers. This map is automatically extended with 'hook_name' and 'hook_tag' ('global' or HostType) parameters on hook registration, so there is no need to add HostType into Parameters map any more.
* the old format of hook handlers is still supported (until the full conversion of all the hook handlers is done)
* conversion of the hooks can be done hook by hook, the following steps must be done to convert the hook:
   - convert hook execution function at 'mongoose_hooks' module.
   - convert all the handlers of the hook (they must be registered using gen_hook interface instead of ejabberd_hook).
   - also, it's possible to mix old & new hook handlers formats (see example at mongoose_hooks:push_notifications/4).
* note that 'gen_hook' accepts only external function references (in format "fun Module:Function/Arity', e.g. "fun erlang:is_function/1") as hook handler function parameter.
@mongoose-im
Copy link
Collaborator

mongoose-im commented Jul 16, 2021

small_tests_23 / small_tests / 43a4064
Reports root / small


small_tests_21_3 / small_tests / 43a4064
Reports root / small


small_tests_22 / small_tests / 43a4064
Reports root / small


dynamic_domains / pgsql_mnesia / 43a4064
Reports root/ big
OK: 1585 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


internal_mnesia / internal_mnesia / 43a4064
Reports root/ big
OK: 1587 / Failed: 0 / User-skipped: 286 / Auto-skipped: 0


ldap_mnesia_21 / ldap_mnesia / 43a4064
Reports root/ big
OK: 1514 / Failed: 0 / User-skipped: 359 / Auto-skipped: 0


ldap_mnesia_23 / ldap_mnesia / 43a4064
Reports root/ big
OK: 1514 / Failed: 0 / User-skipped: 359 / Auto-skipped: 0


ldap_mnesia_22 / ldap_mnesia / 43a4064
Reports root/ big
OK: 1514 / Failed: 0 / User-skipped: 359 / Auto-skipped: 0


pgsql_mnesia / pgsql_mnesia / 43a4064
Reports root/ big
OK: 3084 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


elasticsearch_and_cassandra / elasticsearch_and_cassandra_mnesia / 43a4064
Reports root/ big
OK: 1890 / Failed: 0 / User-skipped: 282 / Auto-skipped: 0


mysql_redis / mysql_redis / 43a4064
Reports root/ big
OK: 3073 / Failed: 1 / User-skipped: 201 / Auto-skipped: 0

mam_SUITE:rdbms_prefs_cases:prefs_set_request
{error,{test_case_failed,"ASSERT EQUAL\n\tExpected {prefs_result_iq,<<\"roster\">>,\n                  [<<\"romeo@montague.net\">>],\n                  [<<\"montague@montague.net\">>]}\n\tValue {prefs_result_iq,<<\"always\">>,\n                 [<<\"romeo@montague.net\">>],\n                 [<<\"montague@montague.net\">>]}\n"}}

Report log


mssql_mnesia / odbc_mssql_mnesia / 43a4064
Reports root/ big
OK: 3084 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


riak_mnesia / riak_mnesia / 43a4064
Reports root/ big
OK: 1737 / Failed: 1 / User-skipped: 285 / Auto-skipped: 0

s2s_SUITE:node1_tls_required_node2_tls_optional:simple_message
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,<<"alicE_simple_message_84.68768@localhost/res1">>,
          escalus_tcp,<0.18017.1>,
          [{event_manager,<0.18012.1>},
           {server,<<"localhost">>},
           {username,<<"alicE_simple_message_84.68768">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.18012.1>},
            {server,<<"localhost">>},
            {username,<<"alicE_simple_message_84.68768">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"alicE_simple_message_84.68768">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,<<"alicE_simple_message_84.68768">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"4a5251e19705f66c">>}]},
        10000],
       [{file,
          "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {s2s_SUITE,'-simple_message/1-fun-0-',2,
       [{file,"/home/circleci/app/big_tests/tests/s2s_SUITE.erl"},
        {line,131}]},
     {escalus_story,story,4,
       [{file,
          "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
        {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{...

Report log

@mongoose-im
Copy link
Collaborator

mongoose-im commented Jul 16, 2021

small_tests_23 / small_tests / 9463958
Reports root / small


small_tests_21_3 / small_tests / 9463958
Reports root / small


internal_mnesia / internal_mnesia / 9463958
Reports root/ big
OK: 1587 / Failed: 0 / User-skipped: 286 / Auto-skipped: 0


small_tests_22 / small_tests / 9463958
Reports root / small


dynamic_domains / pgsql_mnesia / 9463958
Reports root/ big
OK: 1585 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


ldap_mnesia_21 / ldap_mnesia / 9463958
Reports root/ big
OK: 1519 / Failed: 3 / User-skipped: 359 / Auto-skipped: 0

mod_event_pusher_rabbit_SUITE:group_chat_message_publish:group_chat_message_received_event_properly_formatted
{error,
  {{assertMatch,
     [{module,mod_event_pusher_rabbit_SUITE},
      {line,435},
      {expression,
        "get_decoded_message_from_rabbit ( AliceGroupChatMsgRecvRK )"},
      {pattern,
        "# { << \"from_user_id\" >> := BobRoomJID , << \"to_user_id\" >> := AliceFullJID , << \"message\" >> := Message }"},
      {value,
        #{<<"from_user_id">> =>
          <<"muc_publish@muc.localhost/bOb_unnamed_45.523070">>,
        <<"message">> => <<"Hi there!">>,
        <<"to_user_id">> =>
          <<"alice_unnamed_45.786442@localhost/res1">>}}]},
   [{mod_event_pusher_rabbit_SUITE,
      '-group_chat_message_received_event_properly_formatted/1-fun-0-',3,
      [{file,
         "/home/circleci/app/big_tests/tests/mod_event_pusher_rabbit_SUITE.erl"},
       {line,435}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1754}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1263}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1195}]}]}}

Report log

mod_event_pusher_rabbit_SUITE:group_chat_message_publish:group_chat_message_received_event_properly_formatted
{error,
  {{assertMatch,
     [{module,mod_event_pusher_rabbit_SUITE},
      {line,435},
      {expression,
        "get_decoded_message_from_rabbit ( AliceGroupChatMsgRecvRK )"},
      {pattern,
        "# { << \"from_user_id\" >> := BobRoomJID , << \"to_user_id\" >> := AliceFullJID , << \"message\" >> := Message }"},
      {value,
        #{<<"from_user_id">> =>
          <<"muc_publish@muc.localhost/bOb_unnamed_45.786442">>,
        <<"message">> => <<"Hi there!">>,
        <<"to_user_id">> =>
          <<"alice_unnamed_46.447340@localhost/res1">>}}]},
   [{mod_event_pusher_rabbit_SUITE,
      '-group_chat_message_received_event_properly_formatted/1-fun-0-',3,
      [{file,
         "/home/circleci/app/big_tests/tests/mod_event_pusher_rabbit_SUITE.erl"},
       {line,435}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1754}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1263}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1195}]}]}}

Report log

mod_event_pusher_rabbit_SUITE:group_chat_message_publish:group_chat_message_received_event_properly_formatted
{error,
  {{assertMatch,
     [{module,mod_event_pusher_rabbit_SUITE},
      {line,435},
      {expression,
        "get_decoded_message_from_rabbit ( AliceGroupChatMsgRecvRK )"},
      {pattern,
        "# { << \"from_user_id\" >> := BobRoomJID , << \"to_user_id\" >> := AliceFullJID , << \"message\" >> := Message }"},
      {value,
        #{<<"from_user_id">> =>
          <<"muc_publish@muc.localhost/bOb_unnamed_46.179274">>,
        <<"message">> => <<"Hi there!">>,
        <<"to_user_id">> =>
          <<"alice_unnamed_47.138265@localhost/res1">>}}]},
   [{mod_event_pusher_rabbit_SUITE,
      '-group_chat_message_received_event_properly_formatted/1-fun-0-',3,
      [{file,
         "/home/circleci/app/big_tests/tests/mod_event_pusher_rabbit_SUITE.erl"},
       {line,435}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1754}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1263}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1195}]}]}}

Report log


ldap_mnesia_22 / ldap_mnesia / 9463958
Reports root/ big
OK: 1514 / Failed: 0 / User-skipped: 359 / Auto-skipped: 0


ldap_mnesia_23 / ldap_mnesia / 9463958
Reports root/ big
OK: 1569 / Failed: 1 / User-skipped: 359 / Auto-skipped: 0

amp_big_SUITE:offline:offline_success:drop_deliver_to_offline_user_test
{error,
  {{assertion_failed,assert,is_presence,
     {xmlel,<<"stream:error">>,[],
       [{xmlel,<<"conflict">>,
          [{<<"xmlns">>,<<"urn:ietf:params:xml:ns:xmpp-streams">>}],
          []},
        {xmlel,<<"text">>,
          [{<<"xml:lang">>,<<"en">>},
           {<<"xmlns">>,<<"urn:ietf:params:xml:ns:xmpp-streams">>}],
          [{xmlcdata,<<"Replaced by new connection">>}]}]},
     "<stream:error><conflict xmlns='urn:ietf:params:xml:ns:xmpp-streams'/><text xml:lang='en' xmlns='urn:ietf:params:xml:ns:xmpp-streams'>Replaced by new connection</text></stream:error>"},
   [{escalus_new_assert,assert_true,2,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
       {line,84}]},
    {escalus_story,'-drop_presences/2-lc$^0/1-0-',1,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,190}]},
    {escalus_story,drop_presences,2,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,190}]},
    {escalus_story,'-start_ready_clients/2-fun-0-',3,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,135}]},
    {lists,foldl,3,[{file,"lists.erl"},{line,1263}]},
    {escalus_story,start_ready_clients,2,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,128}]},
   ...

Report log


pgsql_mnesia / pgsql_mnesia / 9463958
Reports root/ big
OK: 3084 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


mssql_mnesia / odbc_mssql_mnesia / 9463958
Reports root/ big
OK: 3084 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


mysql_redis / mysql_redis / 9463958
Reports root/ big
OK: 3073 / Failed: 1 / User-skipped: 201 / Auto-skipped: 0

mam_SUITE:rdbms_prefs_cases:messages_filtered_when_prefs_default_policy_is_never
{error,{test_case_failed,"ASSERT EQUAL\n\tExpected []\n\tValue [ok]\n"}}

Report log


elasticsearch_and_cassandra / elasticsearch_and_cassandra_mnesia / 9463958
Reports root/ big
OK: 1890 / Failed: 0 / User-skipped: 282 / Auto-skipped: 0


riak_mnesia / riak_mnesia / 9463958
Reports root/ big
OK: 1737 / Failed: 0 / User-skipped: 285 / Auto-skipped: 0


ldap_mnesia_21 / ldap_mnesia / 9463958
Reports root/ big
OK: 1514 / Failed: 0 / User-skipped: 359 / Auto-skipped: 0

Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@chrzaszcz chrzaszcz merged commit e57010d into master Jul 16, 2021
@chrzaszcz chrzaszcz deleted the hooks-rework branch July 16, 2021 15:59
@Premwoik Premwoik added this to the 5.0.0 milestone Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants