Remove 'travis*' prefix #3176
Remove 'travis*' prefix #3176
Conversation
tools/travis-setup-db.sh -> tools/setup-db.sh tools/travis-setup-ldap.sh -> tools/setup-ldap.sh tools/travis-setup-rmq.sh -> tools/setup-rmq.sh tools/travis-test.sh -> tools/test.sh tools/travis-build-tests.sh -> tools/build-tests.sh
* tools/travis-test.sh -> tools/test.sh * tools/travis-build-tests.sh -> tools/build-tests.sh * tools/travis-setup-db.sh -> tools/setup-db.sh
* tools/travis-test.sh -> tools/test.sh * TRAVIS_JOB_ID -> GITHUB_RUN_ID * travis_fold/2 -> github_actions_fold/2
* Travis -> GitHub Actions
…guration.md * TravisCI -> CI * travis -> CI
* tools/travis-setup-db.sh -> tools/setup-db.sh * tools/travis-test.sh -> tools/test.sh * Travis -> GitHub Actions
* ./tools/travis-test.sh -> ./tools/test.sh
* travis -> GitHub Actions
* TravisInfo -> CIInfo * travis_info -> ci_info
* Travis -> CI
* Travis -> CI
* Travis -> CI
* tools/travis-common-vars.sh -> tools/common-vars.sh
* tools/travis-common-vars.sh -> tools/common-vars.sh
* tools/travis-common-vars.sh -> tools/common-vars.sh
* tools/travis-common-vars.sh -> tools/common-vars.sh
* tools/travis-build-tests.sh -> tools/build-tests.sh * tools/travis-setup-db.sh -> tools/setup-db.sh * tools/travis-test.sh -> tools/test.sh
* tools/travis-common-vars.sh -> tools/common-vars.sh * TRAVIS_COMMIT_MESSAGE -> CI_COMMIT_MESSAGE
* TRAVIS_PULL_REQUEST -> CI_PULL_REQUEST * mongoose-travis-commenter -> mongoose-commenter * travis -> CI
* TRAVIS_BUILD_NUMBER -> GITHUB_RUN_NUMBER * TRAVIS_OTP_RELEASE -> CI_OTP_RELEASE * TRAVIS_BRANCH -> CI_BRANCH * TRAVIS_PULL_REQUEST -> CI_PULL_REQUEST
* tools/travis-helpers.sh -> tools/helpers.sh
* tools/travis-helpers.sh -> tools/helpers.sh * TRAVIS_PULL_REQUEST -> CI_PULL_REQUEST * TRAVIS_COMMIT -> GITHUB_SHA * TRAVIS_JOB_ID -> GITHUB_RUN_ID * TRAVIS_JOB_NUMBER -> GITHUB_JOB * JOB_URL="https://travis-ci.org/$TRAVIS_REPO_SLUG/jobs/$GITHUB_JOB" -> JOB_URL="https://github.com/esl/MongooseIM/actions/runs/$GITHUB_RUN_ID" * echo "export TRAVIS_BUILD_NUMBER=$TRAVIS_BUILD_NUMBER" -> removed * TRAVIS_REPO_SLUG -> GITHUB_REPOSITORY * TRAVIS_OTP_RELEASE -> CI_OTP_RELEASE * Travis -> GitHub Actions
* tools/travis-common-vars.sh -> tools/common-vars.sh * tools/travis-db-versions.sh -> tools/db-versions.sh
* tools/travis-common-vars.sh -> tools/common-vars.sh * tools/travis-db-versions.sh -> tools/db-versions.sh * Travis -> CI * travis-common-vars.sh -> common-vars.sh * tools/travis-setup-ldap.sh -> tools/setup-ldap.sh * tools/travis-setup-rmq.sh -> tools/setup-rmq.sh
* tools/travis-common-vars.sh -> tools/common-vars.sh
* tools/travis-common-vars.sh -> tools/common-vars.sh
* tools/travis-common-vars.sh -> tools/common-vars.sh * tools/travis-helpers.sh -> tools/helpers.sh
tools/travis-helpers.sh -> tools/helpers.sh
* tools/travis-helpers.sh -> tools/helpers.sh
* tools/travis-upload-to-s3.sh -> tools/upload-to-s3.sh * tools/travis-upload-to-gdrive.sh -> tools/upload-to-gdrive.sh * tools/travis-test.sh -> tools/test.sh * tools/travis-setup-rmq.sh -> tools/setup-rmq.sh * tools/travis-setup-ldap.sh -> tools/setup-ldap.sh * tools/travis-setup-humio.sh -> tools/setup-humio.sh * tools/travis-setup-db.sh -> tools/setup-db.sh * tools/travis-secure-erase.sh -> tools/secure-erase.sh * tools/travis-pull-db.sh -> tools/pull-db.sh * tools/travis-publish-github-comment.sh -> tools/publish-github-comment.sh * tools/travis-prepare-log-dir.sh -> tools/prepare-log-dir.sh * tools/travis-helpers.sh -> tools/helpers.sh * tools/travis-db-versions.sh -> tools/db-versions.sh * tools/travis-common-vars.sh -> tools/common-vars.sh * tools/travis-check-tests-branch.sh -> tools/check-tests-branch.sh * tools/travis-build-tests.sh -> tools/build-tests.sh
vkatsuba
requested review from
arcusfelis,
chrzaszcz,
DenysGonchar and
NelsonVides
Codecov Report
@@ Coverage Diff @@
## master #3176 +/- ##
==========================================
- Coverage 80.23% 80.23% -0.01%
==========================================
Files 396 396
Lines 32317 32317
==========================================
- Hits 25931 25928 -3
- Misses 6386 6389 +3
Continue to review full report at Codecov.
|
|
small_tests_21_3 / small_tests / 9ee015a dynamic_domains / pgsql_mnesia / 9ee015a small_tests_22 / small_tests / 9ee015a small_tests_23 / small_tests / 9ee015a ldap_mnesia_21 / ldap_mnesia / 9ee015a ldap_mnesia_22 / ldap_mnesia / 9ee015a internal_mnesia / internal_mnesia / 9ee015a ldap_mnesia_23 / ldap_mnesia / 9ee015a pgsql_mnesia / pgsql_mnesia / 9ee015a mssql_mnesia / odbc_mssql_mnesia / 9ee015a elasticsearch_and_cassandra / elasticsearch_and_cassandra_mnesia / 9ee015a mysql_redis / mysql_redis / 9ee015a riak_mnesia / riak_mnesia / 9ee015a |
|
This is a good idea, but it's not really the direction I was thinking of moving forwards. We've been using a paid account of CircleCI for almost a couple of years, and some long time ago, I was working on #3001, which was trying to move the CircleCI scripts from VM machines to docker containers. It had some advantages, like, in the VM erlang needs to be installed and that takes around 10min, while the container can simply be spawned as-is. Also, general execution time was faster, and it allows for some tricks with parallelism (we have unlimited parallel containers), etc etc. I had a challenge, and it's that our backends (pgsql, redis, ldap, etc), are started as separate containers that CircleCI doesn't allow you to provision them for security reasons, so the spawned containers had to be used as-they-are, and we were testing them with ssl. So I thought, that the ssl connection could be tested separately, we could have a VM job that would rotate the backends and run simple tests to check that they work, and a big bunch of docker jobs testing everything else. But I didn't have the capacity to reconfigure all of our scripts. This PR has some good ideas, but I don't know if Github actions have some limitations per organisation or so, or that of any other kind. Maybe it's a good discussion on how to move forwards, what use are we giving to each CI, would love to have a chat on this 😄 |
You see, the main idea of do those changes is remove prefix from all scripts what is used al in CI as in locally for build/run/prepare some stuff. In fact, dead scripts are also present here and it would be great if MIM team will provide info about scripts which not used at all as in CI as in locally, then we will remove it in scope of current PR. Regarding mentioning of GitHub Actions - we can replace to |
|
I think the main confusion comes from GH Action report for the last commit, but it was manually triggered. This PR doesn't enable automatic GH Actions execution for PRs, it still starts automatically for master branch changes only. indeed, after introduction of that CircleCI changes we won't use that container provisioning scripts for a docker based CircleCI env, but we still need them for testing SSL connection in CircleCI machine, GH Actions builds and local execution. |
There was a problem hiding this comment.
Right, I got it wrong, I thought that this PR was also enabling GH Actions on PRs, it was a manual run 🙂
I have an example of a file that could use some unification: tools/publish-github-comment.sh and tools/circle-publish-github-comment.sh. Just to mention an example, I don't really know all the so many files we have in the tools/ dir, but it's actually a good idea to have a cleanup soon.
But making our CI great is even more important 😁
Proposed changes include:
Remove
travis*prefix from all places.Roadmap of renaming:
tools/travis-upload-to-s3.shtools/upload-to-s3.shtools/travis-upload-to-gdrive.shtools/upload-to-gdrive.shtools/travis-test.shtools/test.shtools/travis-setup-rmq.shtools/setup-rmq.shtools/travis-setup-ldap.shtools/setup-ldap.shtools/travis-setup-humio.shtools/setup-humio.shtools/travis-setup-db.shtools/setup-db.shtools/travis-secure-erase.shtools/secure-erase.shtools/travis-pull-db.shtools/pull-db.shtools/travis-publish-github-comment.shtools/publish-github-comment.shtools/travis-prepare-log-dir.shtools/prepare-log-dir.shtools/travis-helpers.shtools/helpers.shtools/travis-db-versions.shtools/db-versions.shtools/travis-common-vars.shtools/common-vars.shtools/travis-check-tests-branch.shtools/check-tests-branch.shtools/travis-build-tests.shtools/build-tests.shTODO's: