Make xref works #3179
Make xref works #3179
Conversation
vkatsuba
requested review from
arcusfelis,
chrzaszcz,
DenysGonchar and
NelsonVides
vkatsuba
force-pushed
the
refactoring/xref
branch
3 times, most recently
from
7adfa00
to
0790218
Compare
Codecov Report
@@ Coverage Diff @@
## master #3179 +/- ##
==========================================
+ Coverage 80.23% 80.27% +0.04%
==========================================
Files 396 396
Lines 32348 32348
==========================================
+ Hits 25954 25968 +14
+ Misses 6394 6380 -14
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
|
I'd also put the new job in CircleCI, as a standalone docker container. Also, what is the goal of this PR, if it is ignoring all the xref errors? I guess that that way it would be clear what needs fixing, but, I'm not getting how this would be useful, is there any example of something xref marks as an error and that we can fix it as an example? |
No, not all
Well, first of all the
Yes, please follow of description and find section Please notes that the main point of this PR is provide a whole picture of places where need todo changes for future and also unblock projects where |
|
Right, it all seems fine to me this way. I look forward for fixing all these errors we're in the meantime ignoring. For now I think we should just add this new check to circleci's jobs. Also, some conflicts have been introduced with the latest merged PR that need solving now. |
vkatsuba
force-pushed
the
refactoring/xref
branch
2 times, most recently
from
1660b8b
to
a3a15f6
Compare
Fixed, thanks. |
vkatsuba
force-pushed
the
refactoring/xref
branch
from
a3a15f6
to
77b934d
Compare
Done. |
vkatsuba
force-pushed
the
refactoring/xref
branch
from
77b934d
to
e7afdc4
Compare
vkatsuba
force-pushed
the
refactoring/xref
branch
from
e7afdc4
to
a47d5e1
Compare
This comment has been minimized.
This comment has been minimized.
|
I had a quick look and the changes look ok. |
| @@ -49,6 +49,16 @@ | |||
| get_subnodes/3, create_node/6, | |||
| delete_node/2]). | |||
|
|
|||
| -define(MOD_PUBSUB_DB_BACKEND, mod_pubsub_db_backend). | |||
There was a problem hiding this comment.
I think this code would look better and be more 'greppable' if we skip this macro and use the module names directly. However, it's not a blocker, this is temporary anyway.
Expand warnings: ./rebar3 xref