Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix randomly failing service_domain_db tests #3181

Merged
merged 1 commit into from
Jul 13, 2021

Conversation

chrzaszcz
Copy link
Member

For parallel tests, init/end should be done per group, not per TC.

For parallel tests, init/end should be done per group, not per TC.
This caused random failures.

The fix was checked by running each test in the parallel group 10
times (simultaneously) and repeating the whole group 10 times.

Before: it failed multiple times. After: no failures.

Side change: do not return the config from end_per_*, it is ignored.
@codecov
Copy link

codecov bot commented Jul 13, 2021

Codecov Report

Merging #3181 (73cc11c) into master (de27b3f) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3181      +/-   ##
==========================================
- Coverage   80.27%   80.25%   -0.02%     
==========================================
  Files         396      396              
  Lines       32327    32327              
==========================================
- Hits        25950    25945       -5     
- Misses       6377     6382       +5     
Impacted Files Coverage Δ
src/mod_roster_riak.erl 81.53% <0.00%> (-15.39%) ⬇️
src/jingle_sip/mod_jingle_sip_backend.erl 80.00% <0.00%> (-5.00%) ⬇️
src/domain/mongoose_domain_core.erl 88.09% <0.00%> (-1.20%) ⬇️
src/wpool/mongoose_wpool.erl 84.00% <0.00%> (-1.00%) ⬇️
src/muc_light/mod_muc_light_utils.erl 90.00% <0.00%> (-1.00%) ⬇️
src/inbox/mod_inbox_rdbms.erl 92.50% <0.00%> (-0.63%) ⬇️
src/mod_muc.erl 74.77% <0.00%> (-0.23%) ⬇️
src/mod_muc_log.erl 77.77% <0.00%> (ø)
src/ejabberd_c2s.erl 89.27% <0.00%> (+0.07%) ⬆️
src/mod_muc_room.erl 77.10% <0.00%> (+0.17%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de27b3f...73cc11c. Read the comment docs.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Jul 13, 2021

small_tests_21_3 / small_tests / 73cc11c
Reports root / small


small_tests_22 / small_tests / 73cc11c
Reports root / small


dynamic_domains / pgsql_mnesia / 73cc11c
Reports root/ big
OK: 1585 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


small_tests_23 / small_tests / 73cc11c
Reports root / small


ldap_mnesia_22 / ldap_mnesia / 73cc11c
Reports root/ big
OK: 1514 / Failed: 0 / User-skipped: 359 / Auto-skipped: 0


ldap_mnesia_21 / ldap_mnesia / 73cc11c
Reports root/ big
OK: 1514 / Failed: 0 / User-skipped: 359 / Auto-skipped: 0


internal_mnesia / internal_mnesia / 73cc11c
Reports root/ big
OK: 1587 / Failed: 0 / User-skipped: 286 / Auto-skipped: 0


ldap_mnesia_23 / ldap_mnesia / 73cc11c
Reports root/ big
OK: 1514 / Failed: 0 / User-skipped: 359 / Auto-skipped: 0


pgsql_mnesia / pgsql_mnesia / 73cc11c
Reports root/ big
OK: 3084 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


elasticsearch_and_cassandra / elasticsearch_and_cassandra_mnesia / 73cc11c
Reports root/ big
OK: 1890 / Failed: 0 / User-skipped: 282 / Auto-skipped: 0


mysql_redis / mysql_redis / 73cc11c
Reports root/ big
OK: 3067 / Failed: 0 / User-skipped: 201 / Auto-skipped: 0


mssql_mnesia / odbc_mssql_mnesia / 73cc11c
Reports root/ big
OK: 3084 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


riak_mnesia / riak_mnesia / 73cc11c
Reports root/ big
OK: 1737 / Failed: 0 / User-skipped: 285 / Auto-skipped: 0

Copy link
Contributor

@arcusfelis arcusfelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@arcusfelis arcusfelis merged commit 5ee7ac9 into master Jul 13, 2021
@arcusfelis arcusfelis deleted the service-domain-db-test-fix branch July 13, 2021 09:33
@Premwoik Premwoik added this to the 5.0.0 milestone Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants