Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ci/docker #3183

Merged
merged 15 commits into from
Jul 15, 2021
Merged

Ci/docker #3183

merged 15 commits into from
Jul 15, 2021

Conversation

NelsonVides
Copy link
Collaborator

@NelsonVides NelsonVides commented Jul 13, 2021

In this PR I'm going to try to migrate at least some jobs to docker runners in CircleCI, like dialyzer, small_tests, and packages.

  • Some unused files were deleted, travis relics (cache-[build|tests|certs].sh)
  • awscli is not installed by default in the docker containers, so selectively install it
  • certs preset in the main makefile now detects if the certificates are about to expire in the next hour, if so, they're deleted and recreated automatically.
  • Plenty of changes to .circleci/config.yml
    • Orb was removed, that was totally unnecessary for us. This unfortunately means a huge diff because of indentation. But this change is applied only on the first commit.
    • More commands were added, to improve repeating code.

Note that many jobs still run the old way, so this doesn't reduce the overall duration of CI. But some jobs are much faster: otp_23 build job usually takes around 10min, while otp_23_docker takes 5-6min. On top of the later, small_tests_23 takes 8min and dialyzer <2min, compared to the previous 11min and 13min on master

@codecov

This comment has been minimized.

@mongoose-im

This comment has been minimized.

@mongoose-im

This comment has been minimized.

@mongoose-im

This comment has been minimized.

@mongoose-im

This comment has been minimized.

@NelsonVides NelsonVides force-pushed the ci/docker branch 3 times, most recently from ae1fa69 to 07df7ca Compare July 13, 2021 21:36
@esl esl deleted a comment from mongoose-im Jul 13, 2021
@esl esl deleted a comment from mongoose-im Jul 13, 2021
@esl esl deleted a comment from mongoose-im Jul 13, 2021
@NelsonVides NelsonVides force-pushed the ci/docker branch 3 times, most recently from 90da35f to ef22b7a Compare July 14, 2021 07:28
@esl esl deleted a comment from mongoose-im Jul 14, 2021
@esl esl deleted a comment from mongoose-im Jul 14, 2021
@mongoose-im

This comment has been minimized.

@NelsonVides NelsonVides marked this pull request as ready for review July 14, 2021 09:03
@mongoose-im

This comment has been minimized.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Jul 14, 2021

small_tests_23 / small_tests / 6748350
Reports root / small


internal_mnesia / internal_mnesia / 6748350
Reports root/ big
OK: 1587 / Failed: 0 / User-skipped: 286 / Auto-skipped: 0


small_tests_21_3 / small_tests / 6748350
Reports root / small


small_tests_22 / small_tests / 6748350
Reports root / small


dynamic_domains / pgsql_mnesia / 6748350
Reports root/ big
OK: 1585 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


ldap_mnesia_21 / ldap_mnesia / 6748350
Reports root/ big
OK: 1514 / Failed: 0 / User-skipped: 359 / Auto-skipped: 0


ldap_mnesia_22 / ldap_mnesia / 6748350
Reports root/ big
OK: 1514 / Failed: 0 / User-skipped: 359 / Auto-skipped: 0


ldap_mnesia_23 / ldap_mnesia / 6748350
Reports root/ big
OK: 1514 / Failed: 0 / User-skipped: 359 / Auto-skipped: 0


elasticsearch_and_cassandra / elasticsearch_and_cassandra_mnesia / 6748350
Reports root/ big
OK: 1890 / Failed: 0 / User-skipped: 282 / Auto-skipped: 0


pgsql_mnesia / pgsql_mnesia / 6748350
Reports root/ big
OK: 3084 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


mssql_mnesia / odbc_mssql_mnesia / 6748350
Reports root/ big
OK: 3084 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


mysql_redis / mysql_redis / 6748350
Reports root/ big
OK: 3073 / Failed: 1 / User-skipped: 201 / Auto-skipped: 0

mam_SUITE:rdbms_prefs_cases:prefs_set_cdata_request
{error,{test_case_failed,"ASSERT EQUAL\n\tExpected {prefs_result_iq,<<\"roster\">>,\n                  [<<\"montague@montague.net\">>,\n                   <<\"romeo@montague.net\">>],\n                  []}\n\tValue {prefs_result_iq,<<\"always\">>,\n                 [<<\"montague@montague.net\">>,\n                <<\"romeo@montague.net\">>],\n                 []}\n"}}

Report log


riak_mnesia / riak_mnesia / 6748350
Reports root/ big
OK: 1743 / Failed: 1 / User-skipped: 285 / Auto-skipped: 0

mod_ping_SUITE:server_ping:server_ping_pong
{error,{{badmatch,[{[<<"localhost">>,mod_ping,ping_response],
          {expected_diff,5},
          {before_story,0},
          {after_story,4}}]},
    [{escalus_mongooseim,post_story_check_metrics,1,
               [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,74}]},
     {escalus_mongooseim,maybe_check_metrics_post_story,1,
               [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,51}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,75}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1754}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1263}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1195}]}]}}

Report log

Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, I like the cert check and removing unused files.
Do you think that the remaining jobs can be converted to use Docker as well?

@NelsonVides
Copy link
Collaborator Author

Great work, I like the cert check and removing unused files.
Do you think that the remaining jobs can be converted to use Docker as well?

All the others, totally, but they'll need to rework the whole ssl configuration and scripts with the pools, and that'll get quite more complex, so maybe for the future.

@chrzaszcz chrzaszcz merged commit fbac330 into master Jul 15, 2021
@chrzaszcz chrzaszcz deleted the ci/docker branch July 15, 2021 10:01
@Premwoik Premwoik added this to the 5.0.0 milestone Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants