Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare fusco obviously in big tests #3213

Merged
merged 1 commit into from
Aug 10, 2021
Merged

Declare fusco obviously in big tests #3213

merged 1 commit into from
Aug 10, 2021

Conversation

vkatsuba
Copy link
Contributor

The fusco is used from escalus but not used in escalus.

The fusco is used from escalus but not used in escalus
@NelsonVides
Copy link
Collaborator

The fusco is used from escalus but not used in escalus.

I'm not sure to get what this one mean, can you explain better? 🤔

@vkatsuba
Copy link
Contributor Author

vkatsuba commented Aug 10, 2021

I'm not sure to get what this one mean, can you explain better? thinking

Sure. So, the fusco is declare in escalus, but not used at all in escalus. At the same time in big tests of MIM fusco is used but not declare as dependency. Does this explanation make more sense for you?

@NelsonVides
Copy link
Collaborator

I'm not sure to get what this one mean, can you explain better? thinking

Sure. So, the fusco is declare in escalus, but not used at all in escalus. At the same time in big tests of MIM fusco is used but not declare as dependency. Does this explanation make more sense for you?

Aaaaaah, right, that's a mess. If escalus is not using fusco, it should be removed from there as well I suppose.

Where is big_tests using fusco btw?

@vkatsuba
Copy link
Contributor Author

it should be removed from there as well I suppose.

Will be done soonish I hope in the scope of esl/escalus#245 PR.

Where is big_tests using fusco btw?

Mostly used in rest_helper.erl

@mongoose-im
Copy link
Collaborator

mongoose-im commented Aug 10, 2021

small_tests_24 / small_tests / 33e0b68
Reports root / small


internal_mnesia_24 / internal_mnesia / 33e0b68
Reports root/ big
OK: 1588 / Failed: 0 / User-skipped: 287 / Auto-skipped: 0


small_tests_22 / small_tests / 33e0b68
Reports root / small


small_tests_23 / small_tests / 33e0b68
Reports root / small


dynamic_domains_24 / pgsql_mnesia / 33e0b68
Reports root/ big
OK: 1644 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


dynamic_domains_23 / pgsql_mnesia / 33e0b68
Reports root/ big
OK: 1644 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


ldap_mnesia_23 / ldap_mnesia / 33e0b68
Reports root/ big
OK: 1515 / Failed: 0 / User-skipped: 360 / Auto-skipped: 0


pgsql_mnesia_23 / pgsql_mnesia / 33e0b68
Reports root/ big
OK: 3086 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 33e0b68
Reports root/ big
OK: 1891 / Failed: 0 / User-skipped: 283 / Auto-skipped: 0


mysql_redis_24 / mysql_redis / 33e0b68
Reports root/ big
OK: 3069 / Failed: 0 / User-skipped: 201 / Auto-skipped: 0


ldap_mnesia_24 / ldap_mnesia / 33e0b68
Reports root/ big
OK: 1515 / Failed: 0 / User-skipped: 360 / Auto-skipped: 0


ldap_mnesia_22 / ldap_mnesia / 33e0b68
Reports root/ big
OK: 1515 / Failed: 0 / User-skipped: 360 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 33e0b68
Reports root/ big
OK: 3086 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


pgsql_mnesia_22 / pgsql_mnesia / 33e0b68
Reports root/ big
OK: 3086 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


mssql_mnesia_24 / odbc_mssql_mnesia / 33e0b68
Reports root/ big
OK: 3097 / Failed: 1 / User-skipped: 184 / Auto-skipped: 0

pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription
{error,
  {{badmatch,
     [{xmlel,<<"message">>,
        [{<<"from">>,
        <<"alice_unsubscribe_after_presence_unsubscription_5.99484@localhost">>},
         {<<"to">>,
        <<"bob_unsubscribe_after_presence_unsubscription_5.99484@localhost/res1">>},
         {<<"type">>,<<"headline">>}],
        [{xmlel,<<"event">>,
           [{<<"xmlns">>,
           <<"http://jabber.org/protocol/pubsub#event">>}],
           [{xmlel,<<"items">>,
            [{<<"node">>,<<"93lMbPJ1NwDGsLpFtLg1QQ==">>}],
            [{xmlel,<<"item">>,
               [{<<"id">>,<<"salmon">>}],
               [{xmlel,<<"entry">>,
                  [{<<"xmlns">>,
                  <<"http://www.w3.org/2005/Atom">>}],
                  []}]}]}]},
         {xmlel,<<"headers">>,
           [{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
           []}]}]},
   [{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
      [{file,"/home/circleci/app/big_tests/tests/pep_SUITE.erl"},
       {line,382}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1292}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1224}]}]}}

Report log


riak_mnesia_24 / riak_mnesia / 33e0b68
Reports root/ big
OK: 1738 / Failed: 0 / User-skipped: 286 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Aug 10, 2021

Codecov Report

Merging #3213 (33e0b68) into master (88c9463) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3213      +/-   ##
==========================================
+ Coverage   80.23%   80.27%   +0.04%     
==========================================
  Files         397      397              
  Lines       32474    32474              
==========================================
+ Hits        26054    26067      +13     
+ Misses       6420     6407      -13     
Impacted Files Coverage Δ
src/elasticsearch/mongoose_elasticsearch.erl 76.92% <0.00%> (-7.70%) ⬇️
src/mam/mod_mam_elasticsearch_arch.erl 85.08% <0.00%> (-1.76%) ⬇️
src/global_distrib/mod_global_distrib_utils.erl 64.48% <0.00%> (-0.94%) ⬇️
src/muc_light/mod_muc_light.erl 85.13% <0.00%> (-0.75%) ⬇️
src/ejabberd_c2s.erl 89.20% <0.00%> (-0.08%) ⬇️
src/ejabberd_sm.erl 84.59% <0.00%> (+0.32%) ⬆️
src/pubsub/mod_pubsub_db_mnesia.erl 92.85% <0.00%> (+0.42%) ⬆️
...c/global_distrib/mod_global_distrib_server_mgr.erl 77.40% <0.00%> (+0.56%) ⬆️
...bal_distrib/mod_global_distrib_hosts_refresher.erl 73.58% <0.00%> (+1.88%) ⬆️
src/mod_bosh.erl 93.91% <0.00%> (+2.02%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88c9463...33e0b68. Read the comment docs.

Copy link
Collaborator

@NelsonVides NelsonVides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent 👍🏽

@NelsonVides NelsonVides merged commit 7c97ad7 into master Aug 10, 2021
@NelsonVides NelsonVides deleted the big_tests/fusco branch August 10, 2021 18:30
@Premwoik Premwoik added this to the 5.0.0 milestone Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants