-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Declare fusco obviously in big tests #3213
Conversation
The fusco is used from escalus but not used in escalus
I'm not sure to get what this one mean, can you explain better? 🤔 |
Sure. So, the |
Aaaaaah, right, that's a mess. If escalus is not using fusco, it should be removed from there as well I suppose. Where is big_tests using fusco btw? |
Will be done soonish I hope in the scope of esl/escalus#245 PR.
Mostly used in rest_helper.erl |
small_tests_24 / small_tests / 33e0b68 internal_mnesia_24 / internal_mnesia / 33e0b68 small_tests_22 / small_tests / 33e0b68 small_tests_23 / small_tests / 33e0b68 dynamic_domains_24 / pgsql_mnesia / 33e0b68 dynamic_domains_23 / pgsql_mnesia / 33e0b68 ldap_mnesia_23 / ldap_mnesia / 33e0b68 pgsql_mnesia_23 / pgsql_mnesia / 33e0b68 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 33e0b68 mysql_redis_24 / mysql_redis / 33e0b68 ldap_mnesia_24 / ldap_mnesia / 33e0b68 ldap_mnesia_22 / ldap_mnesia / 33e0b68 pgsql_mnesia_24 / pgsql_mnesia / 33e0b68 pgsql_mnesia_22 / pgsql_mnesia / 33e0b68 mssql_mnesia_24 / odbc_mssql_mnesia / 33e0b68 pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription{error,
{{badmatch,
[{xmlel,<<"message">>,
[{<<"from">>,
<<"alice_unsubscribe_after_presence_unsubscription_5.99484@localhost">>},
{<<"to">>,
<<"bob_unsubscribe_after_presence_unsubscription_5.99484@localhost/res1">>},
{<<"type">>,<<"headline">>}],
[{xmlel,<<"event">>,
[{<<"xmlns">>,
<<"http://jabber.org/protocol/pubsub#event">>}],
[{xmlel,<<"items">>,
[{<<"node">>,<<"93lMbPJ1NwDGsLpFtLg1QQ==">>}],
[{xmlel,<<"item">>,
[{<<"id">>,<<"salmon">>}],
[{xmlel,<<"entry">>,
[{<<"xmlns">>,
<<"http://www.w3.org/2005/Atom">>}],
[]}]}]}]},
{xmlel,<<"headers">>,
[{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
[]}]}]},
[{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
[{file,"/home/circleci/app/big_tests/tests/pep_SUITE.erl"},
{line,382}]},
{escalus_story,story,4,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} riak_mnesia_24 / riak_mnesia / 33e0b68 |
Codecov Report
@@ Coverage Diff @@
## master #3213 +/- ##
==========================================
+ Coverage 80.23% 80.27% +0.04%
==========================================
Files 397 397
Lines 32474 32474
==========================================
+ Hits 26054 26067 +13
+ Misses 6420 6407 -13
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent 👍🏽
The
fusco
is used fromescalus
but not used inescalus
.