Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This scenario is not used in this repo #3214

Merged
merged 1 commit into from
Aug 11, 2021
Merged

Conversation

NelsonVides
Copy link
Collaborator

As said in the title. This scenario can always be added (with proper rewriting), to amoc_arsenal.

@vkatsuba
Copy link
Contributor

vkatsuba commented Aug 10, 2021

Can we add this scenario into https://github.com/esl/amoc-arsenal-xmpp/tree/master/src/scenarios?

@codecov
Copy link

codecov bot commented Aug 10, 2021

Codecov Report

Merging #3214 (26ddc93) into master (88c9463) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3214      +/-   ##
==========================================
+ Coverage   80.23%   80.28%   +0.05%     
==========================================
  Files         397      397              
  Lines       32474    32474              
==========================================
+ Hits        26054    26073      +19     
+ Misses       6420     6401      -19     
Impacted Files Coverage Δ
src/event_pusher/mod_event_pusher_sns.erl 84.21% <0.00%> (-5.27%) ⬇️
src/global_distrib/mod_global_distrib_utils.erl 64.48% <0.00%> (-0.94%) ⬇️
src/ejabberd_sm.erl 84.26% <0.00%> (ø)
src/mod_muc_room.erl 77.18% <0.00%> (+0.05%) ⬆️
src/pubsub/mod_pubsub_db_mnesia.erl 92.85% <0.00%> (+0.42%) ⬆️
...c/global_distrib/mod_global_distrib_server_mgr.erl 77.40% <0.00%> (+0.56%) ⬆️
src/ejabberd_s2s_out.erl 61.95% <0.00%> (+1.13%) ⬆️
src/mod_bosh.erl 93.91% <0.00%> (+2.02%) ⬆️
src/global_distrib/mod_global_distrib_receiver.erl 84.44% <0.00%> (+3.33%) ⬆️
src/pubsub/node_hometree.erl 83.33% <0.00%> (+5.55%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88c9463...26ddc93. Read the comment docs.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Aug 10, 2021

small_tests_24 / small_tests / 26ddc93
Reports root / small


internal_mnesia_24 / internal_mnesia / 26ddc93
Reports root/ big
OK: 1588 / Failed: 0 / User-skipped: 287 / Auto-skipped: 0


dynamic_domains_24 / pgsql_mnesia / 26ddc93
Reports root/ big
OK: 1644 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


small_tests_22 / small_tests / 26ddc93
Reports root / small


dynamic_domains_23 / pgsql_mnesia / 26ddc93
Reports root/ big
OK: 1644 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


small_tests_23 / small_tests / 26ddc93
Reports root / small


ldap_mnesia_22 / ldap_mnesia / 26ddc93
Reports root/ big
OK: 1515 / Failed: 0 / User-skipped: 360 / Auto-skipped: 0


ldap_mnesia_24 / ldap_mnesia / 26ddc93
Reports root/ big
OK: 1515 / Failed: 0 / User-skipped: 360 / Auto-skipped: 0


ldap_mnesia_23 / ldap_mnesia / 26ddc93
Reports root/ big
OK: 1515 / Failed: 0 / User-skipped: 360 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 26ddc93
Reports root/ big
OK: 3086 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


pgsql_mnesia_22 / pgsql_mnesia / 26ddc93
Reports root/ big
OK: 3086 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 26ddc93
Reports root/ big
OK: 1891 / Failed: 0 / User-skipped: 283 / Auto-skipped: 0


pgsql_mnesia_23 / pgsql_mnesia / 26ddc93
Reports root/ big
OK: 3086 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


mysql_redis_24 / mysql_redis / 26ddc93
Reports root/ big
OK: 3069 / Failed: 0 / User-skipped: 201 / Auto-skipped: 0


mssql_mnesia_24 / odbc_mssql_mnesia / 26ddc93
Reports root/ big
OK: 3086 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / 26ddc93
Reports root/ big
OK: 1774 / Failed: 2 / User-skipped: 286 / Auto-skipped: 0

jingle_SUITE:all:resp_4xx_from_sip_proxy_results_in_session_terminate
{error,
  {{assertion_failed,assert,is_iq_result,
     {xmlel,<<"iq">>,
       [{<<"from">>,<<"error.480@localhost">>},
        {<<"to">>,
         <<"alice_resp_4xx_from_sip_proxy_results_in_session_terminate_87.769803@localhost/res1">>},
        {<<"id">>,<<"36e0b794-dc5e-4d21-9839-811d7c081bc3">>},
        {<<"type">>,<<"set">>}],
       [{xmlel,<<"jingle">>,
          [{<<"xmlns">>,<<"urn:xmpp:jingle:1">>},
           {<<"action">>,<<"session-terminate">>},
           {<<"sid">>,<<"bb51c56b-6dd6-445e-8e4f-7729a3e9c8ae">>}],
          [{xmlel,<<"reason">>,[],
             [{xmlel,<<"general-error">>,[],[]},
            {xmlel,<<"sip-error">>,
              [{<<"code">>,<<"480">>}],
              [{xmlcdata,<<"Temporarily Unavailable">>}]}]}]}]},
     "<iq from='error.480@localhost' to='alice_resp_4xx_from_sip_proxy_results_in_session_terminate_87.769803@localhost/res1' id='36e0b794-dc5e-4d21-9839-811d7c081bc3' type='set'><jingle xmlns='urn:xmpp:jingle:1' action='session-terminate' sid='bb51c56b-6dd6-445e-8e4f-7729a3e9c8ae'><reason><general-error/><sip-error code='480'>Temporarily Unavailable</sip-error></reason></jingle></iq>"},
   [{escalus_new_assert,assert_true,2,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
       {line,84}]},
    {jingle_SUITE,send_initiate_and_wait_for_first_iq_set,2,
      [{file,"/home/circleci/app/big_tests/tests/jingle_SUITE.erl"},
       {line,393}]},
    {jingle_SUITE,
      '-res...

Report log

jingle_SUITE:all:resp_4xx_from_sip_proxy_results_in_session_terminate
{error,
  {{assertion_failed,assert,is_iq_result,
     {xmlel,<<"iq">>,
       [{<<"from">>,<<"error.480@localhost">>},
        {<<"to">>,
         <<"alice_resp_4xx_from_sip_proxy_results_in_session_terminate_98.356956@localhost/res1">>},
        {<<"id">>,<<"dfe519b4-f8aa-46cb-b251-ab25be6d97b6">>},
        {<<"type">>,<<"set">>}],
       [{xmlel,<<"jingle">>,
          [{<<"xmlns">>,<<"urn:xmpp:jingle:1">>},
           {<<"action">>,<<"session-terminate">>},
           {<<"sid">>,<<"22b86466-c1f4-428c-bc65-438d7422f9ba">>}],
          [{xmlel,<<"reason">>,[],
             [{xmlel,<<"general-error">>,[],[]},
            {xmlel,<<"sip-error">>,
              [{<<"code">>,<<"480">>}],
              [{xmlcdata,<<"Temporarily Unavailable">>}]}]}]}]},
     "<iq from='error.480@localhost' to='alice_resp_4xx_from_sip_proxy_results_in_session_terminate_98.356956@localhost/res1' id='dfe519b4-f8aa-46cb-b251-ab25be6d97b6' type='set'><jingle xmlns='urn:xmpp:jingle:1' action='session-terminate' sid='22b86466-c1f4-428c-bc65-438d7422f9ba'><reason><general-error/><sip-error code='480'>Temporarily Unavailable</sip-error></reason></jingle></iq>"},
   [{escalus_new_assert,assert_true,2,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
       {line,84}]},
    {jingle_SUITE,send_initiate_and_wait_for_first_iq_set,2,
      [{file,"/home/circleci/app/big_tests/tests/jingle_SUITE.erl"},
       {line,393}]},
    {jingle_SUITE,
      '-res...

Report log


riak_mnesia_24 / riak_mnesia / 26ddc93
Reports root/ big
OK: 1738 / Failed: 0 / User-skipped: 286 / Auto-skipped: 0

Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The scenario is overly complicated and incompatible with the latest Amoc. Let's remove it now.

@chrzaszcz chrzaszcz merged commit f4ec19f into master Aug 11, 2021
@chrzaszcz chrzaszcz deleted the remove_unused_file branch August 11, 2021 06:30
@Premwoik Premwoik added this to the 5.0.0 milestone Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants