Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gen_fsm_compat from big_tests #3218

Merged
merged 1 commit into from
Aug 13, 2021

Conversation

vkatsuba
Copy link
Contributor

No description provided.

@vkatsuba
Copy link
Contributor Author

GHA

@codecov
Copy link

codecov bot commented Aug 12, 2021

Codecov Report

Merging #3218 (0d29b5b) into master (b2497b3) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3218      +/-   ##
==========================================
- Coverage   80.28%   80.25%   -0.04%     
==========================================
  Files         397      397              
  Lines       32474    32474              
==========================================
- Hits        26072    26062      -10     
- Misses       6402     6412      +10     
Impacted Files Coverage Δ
src/mod_roster_riak.erl 81.53% <0.00%> (-15.39%) ⬇️
src/event_pusher/mod_event_pusher_sns.erl 84.21% <0.00%> (-5.27%) ⬇️
src/auth/ejabberd_auth_internal.erl 86.11% <0.00%> (-1.86%) ⬇️
src/ejabberd_admin.erl 59.06% <0.00%> (-0.94%) ⬇️
src/auth/ejabberd_auth.erl 82.38% <0.00%> (-0.52%) ⬇️
src/mod_roster.erl 79.17% <0.00%> (-0.25%) ⬇️
src/mod_muc.erl 74.88% <0.00%> (-0.23%) ⬇️
src/ejabberd_c2s.erl 89.06% <0.00%> (-0.23%) ⬇️
src/ejabberd_sm.erl 84.59% <0.00%> (+0.32%) ⬆️
src/global_distrib/mod_global_distrib_receiver.erl 84.44% <0.00%> (+1.11%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2497b3...0d29b5b. Read the comment docs.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Aug 12, 2021

small_tests_24 / small_tests / 0d29b5b
Reports root / small


internal_mnesia_24 / internal_mnesia / 0d29b5b
Reports root/ big
OK: 1588 / Failed: 0 / User-skipped: 287 / Auto-skipped: 0


dynamic_domains_24 / pgsql_mnesia / 0d29b5b
Reports root/ big
OK: 1644 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


dynamic_domains_23 / pgsql_mnesia / 0d29b5b
Reports root/ big
OK: 1644 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


small_tests_22 / small_tests / 0d29b5b
Reports root / small


small_tests_23 / small_tests / 0d29b5b
Reports root / small


ldap_mnesia_24 / ldap_mnesia / 0d29b5b
Reports root/ big
OK: 1515 / Failed: 0 / User-skipped: 360 / Auto-skipped: 0


ldap_mnesia_23 / ldap_mnesia / 0d29b5b
Reports root/ big
OK: 1515 / Failed: 0 / User-skipped: 360 / Auto-skipped: 0


ldap_mnesia_22 / ldap_mnesia / 0d29b5b
Reports root/ big
OK: 1515 / Failed: 0 / User-skipped: 360 / Auto-skipped: 0


pgsql_mnesia_23 / pgsql_mnesia / 0d29b5b
Reports root/ big
OK: 3086 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 0d29b5b
Reports root/ big
OK: 1891 / Failed: 0 / User-skipped: 283 / Auto-skipped: 0


mysql_redis_24 / mysql_redis / 0d29b5b
Reports root/ big
OK: 3069 / Failed: 0 / User-skipped: 201 / Auto-skipped: 0


pgsql_mnesia_22 / pgsql_mnesia / 0d29b5b
Reports root/ big
OK: 3086 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


mssql_mnesia_24 / odbc_mssql_mnesia / 0d29b5b
Reports root/ big
OK: 3086 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / 0d29b5b
Reports root/ big
OK: 1738 / Failed: 0 / User-skipped: 286 / Auto-skipped: 0

Copy link
Collaborator

@NelsonVides NelsonVides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

[{_,_,Pid}|_] ->
%% @TODO related to gen_fsm_compat: after migration to gen_statem
%% should be replaced to - gen_statem:call(Pid, destroy).
Pid ! {'$gen_all_state_event', destroy},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple, though code gets a bit uglier in the meantime, this is now a way less self-explaining line of code than before. Looking forward for the migration to gen_statem!

@NelsonVides NelsonVides merged commit 8f1bf7c into master Aug 13, 2021
@NelsonVides NelsonVides deleted the big_tests/remove-gen_fsm_compat branch August 13, 2021 09:44
@Premwoik Premwoik added this to the 5.0.0 milestone Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants