Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallelise more inbox tests #3227

Merged
merged 1 commit into from
Aug 23, 2021
Merged

Parallelise more inbox tests #3227

merged 1 commit into from
Aug 23, 2021

Conversation

NelsonVides
Copy link
Collaborator

Locally the suite goes from 7-8s to 4-5s. I'm too impatient, if I'm going to be running this suite even more 馃槵

@codecov
Copy link

codecov bot commented Aug 20, 2021

Codecov Report

Merging #3227 (ccf3bed) into master (6d68ad1) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3227      +/-   ##
==========================================
+ Coverage   80.31%   80.33%   +0.01%     
==========================================
  Files         398      398              
  Lines       32505    32505              
==========================================
+ Hits        26108    26114       +6     
+ Misses       6397     6391       -6     
Impacted Files Coverage 螖
src/pubsub/node_hometree.erl 77.77% <0.00%> (-5.56%) 猬囷笍
...bal_distrib/mod_global_distrib_hosts_refresher.erl 71.69% <0.00%> (-1.89%) 猬囷笍
src/ejabberd_sm.erl 84.26% <0.00%> (-0.33%) 猬囷笍
src/mod_roster.erl 79.17% <0.00%> (-0.25%) 猬囷笍
src/mod_muc.erl 74.88% <0.00%> (-0.23%) 猬囷笍
src/ejabberd_c2s.erl 89.20% <0.00%> (-0.08%) 猬囷笍
src/mod_muc_log.erl 77.88% <0.00%> (酶)
src/mod_muc_room.erl 77.18% <0.00%> (+0.05%) 猬嗭笍
src/pubsub/mod_pubsub_db_mnesia.erl 92.85% <0.00%> (+0.42%) 猬嗭笍
src/inbox/mod_inbox_rdbms.erl 93.12% <0.00%> (+0.62%) 猬嗭笍
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 6d68ad1...ccf3bed. Read the comment docs.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Aug 20, 2021

small_tests_24 / small_tests / ccf3bed
Reports root / small


internal_mnesia_24 / internal_mnesia / ccf3bed
Reports root/ big
OK: 1588 / Failed: 0 / User-skipped: 287 / Auto-skipped: 0


small_tests_22 / small_tests / ccf3bed
Reports root / small


dynamic_domains_24 / pgsql_mnesia / ccf3bed
Reports root/ big
OK: 1644 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


dynamic_domains_23 / pgsql_mnesia / ccf3bed
Reports root/ big
OK: 1644 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


small_tests_23 / small_tests / ccf3bed
Reports root / small


ldap_mnesia_22 / ldap_mnesia / ccf3bed
Reports root/ big
OK: 1515 / Failed: 0 / User-skipped: 360 / Auto-skipped: 0


ldap_mnesia_24 / ldap_mnesia / ccf3bed
Reports root/ big
OK: 1515 / Failed: 0 / User-skipped: 360 / Auto-skipped: 0


ldap_mnesia_23 / ldap_mnesia / ccf3bed
Reports root/ big
OK: 1515 / Failed: 0 / User-skipped: 360 / Auto-skipped: 0


pgsql_mnesia_22 / pgsql_mnesia / ccf3bed
Reports root/ big
OK: 3086 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / ccf3bed
Reports root/ big
OK: 3086 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


pgsql_mnesia_23 / pgsql_mnesia / ccf3bed
Reports root/ big
OK: 3086 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / ccf3bed
Reports root/ big
OK: 1891 / Failed: 0 / User-skipped: 283 / Auto-skipped: 0


mysql_redis_24 / mysql_redis / ccf3bed
Reports root/ big
OK: 3069 / Failed: 0 / User-skipped: 201 / Auto-skipped: 0


mssql_mnesia_24 / odbc_mssql_mnesia / ccf3bed
Reports root/ big
OK: 3086 / Failed: 9 / User-skipped: 184 / Auto-skipped: 0

inbox_SUITE:muclight:groupchat_markers_one_reset_room_created
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"alicE_groupchat_markers_one_reset_room_created_33.789589@localhost/res1">>,
          escalus_tcp,<0.17905.0>,
          [{event_manager,<0.17875.0>},
           {server,<<"localhost">>},
           {username,
             <<"alicE_groupchat_markers_one_reset_room_created_33.789589">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.17875.0>},
            {server,<<"localhost">>},
            {username,
              <<"alicE_groupchat_markers_one_reset_room_created_33.789589">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"alicE_groupchat_markers_one_reset_room_created_33.789589">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,
             <<"alicE_groupchat_markers_one_reset_room_created_33.789589">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"0c18048f2d5806ff">>}]},
        5000],
       [{file,
          "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {muc_helper,'-foreach_recipient/2-fun-0-',2,
       [{file,"/home/circleci/app/big_tests/tests/muc_helper.erl"},
        {line,45}]},
    ...

Report log

inbox_SUITE:muclight:groupchat_markers_all_reset_room_created
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"alicE_groupchat_markers_all_reset_room_created_33.787053@localhost/res1">>,
          escalus_tcp,<0.17906.0>,
          [{event_manager,<0.17866.0>},
           {server,<<"localhost">>},
           {username,
             <<"alicE_groupchat_markers_all_reset_room_created_33.787053">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.17866.0>},
            {server,<<"localhost">>},
            {username,
              <<"alicE_groupchat_markers_all_reset_room_created_33.787053">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"alicE_groupchat_markers_all_reset_room_created_33.787053">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,
             <<"alicE_groupchat_markers_all_reset_room_created_33.787053">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"1dffaa3ef43092fd">>}]},
        5000],
       [{file,
          "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {muc_helper,'-foreach_recipient/2-fun-0-',2,
       [{file,"/home/circleci/app/big_tests/tests/muc_helper.erl"},
        {line,45}]},
    ...

Report log

inbox_SUITE:muclight:leave_and_remove_conversation
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"alicE_leave_and_remove_conversation_33.791502@localhost/res1">>,
          escalus_tcp,<0.17907.0>,
          [{event_manager,<0.17887.0>},
           {server,<<"localhost">>},
           {username,
             <<"alicE_leave_and_remove_conversation_33.791502">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.17887.0>},
            {server,<<"localhost">>},
            {username,
              <<"alicE_leave_and_remove_conversation_33.791502">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"alicE_leave_and_remove_conversation_33.791502">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,
             <<"alicE_leave_and_remove_conversation_33.791502">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"3c5bd0f4a3404ff3">>}]},
        5000],
       [{file,
          "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {muc_light_helper,given_muc_light_room,3,
       [{file,"/home/circleci/app/big_tests/tests/muc_light_helper.erl"},
        {line,54}]},
     {inbox_helper,create_room,3,
       [{file,"/home/c...

Report log

inbox_SUITE:muclight:groupchat_markers_one_reset
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"alicE_groupchat_markers_one_reset_33.784305@localhost/res1">>,
          escalus_tcp,<0.17903.0>,
          [{event_manager,<0.17854.0>},
           {server,<<"localhost">>},
           {username,
             <<"alicE_groupchat_markers_one_reset_33.784305">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.17854.0>},
            {server,<<"localhost">>},
            {username,
              <<"alicE_groupchat_markers_one_reset_33.784305">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"alicE_groupchat_markers_one_reset_33.784305">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,
             <<"alicE_groupchat_markers_one_reset_33.784305">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"d10c685fccf0305a">>}]},
        5000],
       [{file,
          "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {muc_light_helper,given_muc_light_room,3,
       [{file,"/home/circleci/app/big_tests/tests/muc_light_helper.erl"},
        {line,54}]},
     {inbox_helper,create_room,3,
       [{file,"/home/circleci/ap...

Report log

inbox_SUITE:muclight:non_reset_marker_should_not_affect_muclight_inbox
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"alicE_non_reset_marker_should_not_affect_muclight_inbox_33.793321@localhost/res1">>,
          escalus_tcp,<0.17909.0>,
          [{event_manager,<0.17894.0>},
           {server,<<"localhost">>},
           {username,
             <<"alicE_non_reset_marker_should_not_affect_muclight_inbox_33.793321">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.17894.0>},
            {server,<<"localhost">>},
            {username,
              <<"alicE_non_reset_marker_should_not_affect_muclight_inbox_33.793321">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"alicE_non_reset_marker_should_not_affect_muclight_inbox_33.793321">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,
             <<"alicE_non_reset_marker_should_not_affect_muclight_inbox_33.793321">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"e93275f6f563ce1e">>}]},
        5000],
       [{file,
          "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {muc_light_helper,given_muc_light_room,3,
       [{file,"/home/circleci/app/big_tests/tests/m...

Report log

inbox_SUITE:muclight:advanced_groupchat_stored_in_all_inbox
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"alicE_advanced_groupchat_stored_in_all_inbox_33.790063@localhost/res1">>,
          escalus_tcp,<0.17908.0>,
          [{event_manager,<0.17880.0>},
           {server,<<"localhost">>},
           {username,
             <<"alicE_advanced_groupchat_stored_in_all_inbox_33.790063">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.17880.0>},
            {server,<<"localhost">>},
            {username,
              <<"alicE_advanced_groupchat_stored_in_all_inbox_33.790063">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"alicE_advanced_groupchat_stored_in_all_inbox_33.790063">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,
             <<"alicE_advanced_groupchat_stored_in_all_inbox_33.790063">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"5bc1aa7bff4a5e8f">>}]},
        5000],
       [{file,
          "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {muc_light_helper,given_muc_light_room,3,
       [{file,"/home/circleci/app/big_tests/tests/muc_light_helper.erl"},
        {line,54}]},
     {inbox...

Report log

inbox_SUITE:muclight:groupchat_reset_stanza_resets_inbox
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"alicE_groupchat_reset_stanza_resets_inbox_33.793506@localhost/res1">>,
          escalus_tcp,<0.17910.0>,
          [{event_manager,<0.17901.0>},
           {server,<<"localhost">>},
           {username,
             <<"alicE_groupchat_reset_stanza_resets_inbox_33.793506">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.17901.0>},
            {server,<<"localhost">>},
            {username,
              <<"alicE_groupchat_reset_stanza_resets_inbox_33.793506">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"alicE_groupchat_reset_stanza_resets_inbox_33.793506">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,
             <<"alicE_groupchat_reset_stanza_resets_inbox_33.793506">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"883806b3404df636">>}]},
        5000],
       [{file,
          "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {muc_light_helper,given_muc_light_room,3,
       [{file,"/home/circleci/app/big_tests/tests/muc_light_helper.erl"},
        {line,54}]},
     {inbox_helper,create_...

Report log

inbox_SUITE:muclight:simple_groupchat_stored_in_all_inbox
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"alicE_simple_groupchat_stored_in_all_inbox_33.777518@localhost/res1">>,
          escalus_tcp,<0.17902.0>,
          [{event_manager,<0.17846.0>},
           {server,<<"localhost">>},
           {username,
             <<"alicE_simple_groupchat_stored_in_all_inbox_33.777518">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.17846.0>},
            {server,<<"localhost">>},
            {username,
              <<"alicE_simple_groupchat_stored_in_all_inbox_33.777518">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"alicE_simple_groupchat_stored_in_all_inbox_33.777518">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,
             <<"alicE_simple_groupchat_stored_in_all_inbox_33.777518">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"4b992e030663715c">>}]},
        5000],
       [{file,
          "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {muc_helper,'-foreach_recipient/2-fun-0-',2,
       [{file,"/home/circleci/app/big_tests/tests/muc_helper.erl"},
        {line,45}]},
     {lists,foreach,2,[{...

Report log

inbox_SUITE:muclight:create_groupchat
{error,{badarg,[{erlang,binary_to_integer,
            [undefined],
            [{error_info,#{module => erl_erts_errors}}]},
        {inbox_helper,get_result_el,2,
                [{file,"/home/circleci/app/big_tests/tests/inbox_helper.erl"},
                 {line,236}]},
        {inbox_helper,'-check_result/2-fun-0-',3,
                [{file,"/home/circleci/app/big_tests/tests/inbox_helper.erl"},
                 {line,241}]},
        {maps,filter_1,2,[{file,"maps.erl"},{line,318}]},
        {maps,filter,2,[{file,"maps.erl"},{line,309}]},
        {inbox_helper,get_inbox,3,
                [{file,"/home/circleci/app/big_tests/tests/inbox_helper.erl"},
                 {line,222}]},
        {inbox_helper,check_inbox,4,
                [{file,"/home/circleci/app/big_tests/tests/inbox_helper.erl"},
                 {line,167}]},
        {inbox_helper,'-create_room_and_check_inbox/3-lc$^3/1-2-',2,
                [{file,"/home/circleci/app/big_tests/tests/inbox_helper.erl"},
                 {line,528}]}]}}

Report log


riak_mnesia_24 / riak_mnesia / ccf3bed
Reports root/ big
OK: 1738 / Failed: 0 / User-skipped: 286 / Auto-skipped: 0

Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@chrzaszcz chrzaszcz merged commit 359ebe5 into master Aug 23, 2021
@chrzaszcz chrzaszcz deleted the inbox/parallelise_tests branch August 23, 2021 13:24
@Premwoik Premwoik added this to the 5.0.0 milestone Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants