Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out only used users in mam_helper:serv_users/1 #3230

Merged
merged 1 commit into from
Aug 26, 2021

Conversation

arcusfelis
Copy link
Contributor

@arcusfelis arcusfelis commented Aug 26, 2021

So, we don't call remove_user if not needed

Proposed changes include:

  • it does not call remove_user for non-existing test users.
  • Should be a bit faster to execute tests in mam_SUITE too.

This user gets filtered out, for example:

    {astrid, [
        {username, <<"astrid">>},
        {server, <<"sogndal">>},
        {host, <<"localhost">>},
        {password, <<"doctor">>}]},

So, we don't call remove_user if not needed
@mongoose-im
Copy link
Collaborator

mongoose-im commented Aug 26, 2021

small_tests_24 / small_tests / 0bcc208
Reports root / small


internal_mnesia_24 / internal_mnesia / 0bcc208
Reports root/ big
OK: 1588 / Failed: 0 / User-skipped: 288 / Auto-skipped: 0


dynamic_domains_24 / pgsql_mnesia / 0bcc208
Reports root/ big
OK: 1684 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0


small_tests_22 / small_tests / 0bcc208
Reports root / small


dynamic_domains_23 / pgsql_mnesia / 0bcc208
Reports root/ big
OK: 1684 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0


small_tests_23 / small_tests / 0bcc208
Reports root / small


ldap_mnesia_24 / ldap_mnesia / 0bcc208
Reports root/ big
OK: 1515 / Failed: 0 / User-skipped: 361 / Auto-skipped: 0


ldap_mnesia_22 / ldap_mnesia / 0bcc208
Reports root/ big
OK: 1515 / Failed: 0 / User-skipped: 361 / Auto-skipped: 0


ldap_mnesia_23 / ldap_mnesia / 0bcc208
Reports root/ big
OK: 1515 / Failed: 0 / User-skipped: 361 / Auto-skipped: 0


elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 0bcc208
Reports root/ big
OK: 1891 / Failed: 0 / User-skipped: 284 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 0bcc208
Reports root/ big
OK: 3087 / Failed: 1 / User-skipped: 184 / Auto-skipped: 0

service_domain_db_SUITE:db:db_keeps_syncing_after_cluster_join
{error,{test_case_failed,{[<<"example1.com">>,<<"example2.com">>,
               <<"example3.com">>],
              [<<"example1.com">>,<<"example2.com">>,
               <<"example3.com">>,<<"example4.com">>]}}}

Report log


pgsql_mnesia_22 / pgsql_mnesia / 0bcc208
Reports root/ big
OK: 3088 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


mysql_redis_24 / mysql_redis / 0bcc208
Reports root/ big
OK: 3071 / Failed: 0 / User-skipped: 201 / Auto-skipped: 0


pgsql_mnesia_23 / pgsql_mnesia / 0bcc208
Reports root/ big
OK: 3088 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


mssql_mnesia_24 / odbc_mssql_mnesia / 0bcc208
Reports root/ big
OK: 3088 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / 0bcc208
Reports root/ big
OK: 1738 / Failed: 0 / User-skipped: 287 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 0bcc208
Reports root/ big
OK: 3088 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Aug 26, 2021

Codecov Report

Merging #3230 (0bcc208) into master (413e706) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3230      +/-   ##
==========================================
- Coverage   80.30%   80.26%   -0.04%     
==========================================
  Files         398      398              
  Lines       32524    32524              
==========================================
- Hits        26117    26105      -12     
- Misses       6407     6419      +12     
Impacted Files Coverage Δ
src/elasticsearch/mongoose_elasticsearch.erl 76.92% <0.00%> (-7.70%) ⬇️
src/mam/mod_mam_elasticsearch_arch.erl 85.08% <0.00%> (-1.76%) ⬇️
src/ejabberd_s2s_out.erl 60.82% <0.00%> (-1.60%) ⬇️
src/mod_muc_room.erl 76.94% <0.00%> (-0.24%) ⬇️
src/mod_muc_log.erl 77.88% <0.00%> (ø)
src/ejabberd_c2s.erl 89.28% <0.00%> (+0.07%) ⬆️
src/global_distrib/mod_global_distrib_utils.erl 65.42% <0.00%> (+0.93%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 413e706...0bcc208. Read the comment docs.

@vkatsuba vkatsuba merged commit cda4a60 into master Aug 26, 2021
@vkatsuba vkatsuba deleted the mu-mam-helper-serv-users-filtering branch August 26, 2021 19:57
@Premwoik Premwoik added this to the 5.0.0 milestone Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants