Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BOSH with dynamic domains #3253

Merged
merged 6 commits into from
Sep 9, 2021
Merged

BOSH with dynamic domains #3253

merged 6 commits into from
Sep 9, 2021

Conversation

chrzaszcz
Copy link
Member

@chrzaszcz chrzaszcz commented Sep 9, 2021

Update mod_bosh and the corresponding big tests to work with dynamic domains.

Also: fix some type specs related to system metrics.

@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #3253 (5eb3f9b) into master (bba4d7e) will decrease coverage by 0.01%.
The diff coverage is 95.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3253      +/-   ##
==========================================
- Coverage   80.33%   80.31%   -0.02%     
==========================================
  Files         398      398              
  Lines       32566    32565       -1     
==========================================
- Hits        26162    26155       -7     
- Misses       6404     6410       +6     
Impacted Files Coverage Δ
src/mod_bosh.erl 93.87% <94.11%> (-0.05%) ⬇️
src/mod_bosh_socket.erl 79.19% <100.00%> (ø)
src/system_metrics/mongoose_module_metrics.erl 83.33% <100.00%> (ø)
src/elasticsearch/mongoose_elasticsearch.erl 76.92% <0.00%> (-7.70%) ⬇️
src/mod_last_rdbms.erl 91.66% <0.00%> (-4.17%) ⬇️
src/mam/mod_mam_elasticsearch_arch.erl 85.08% <0.00%> (-1.76%) ⬇️
src/mod_last.erl 86.36% <0.00%> (-1.52%) ⬇️
src/rdbms/mongoose_rdbms.erl 60.88% <0.00%> (-0.81%) ⬇️
src/ejabberd_s2s_out.erl 61.95% <0.00%> (-0.46%) ⬇️
src/mod_muc.erl 73.76% <0.00%> (-0.23%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bba4d7e...5eb3f9b. Read the comment docs.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Sep 9, 2021

small_tests_24 / small_tests / 5eb3f9b
Reports root / small


internal_mnesia_24 / internal_mnesia / 5eb3f9b
Reports root/ big
OK: 1588 / Failed: 0 / User-skipped: 290 / Auto-skipped: 0


small_tests_22 / small_tests / 5eb3f9b
Reports root / small


dynamic_domains_24 / pgsql_mnesia / 5eb3f9b
Reports root/ big
OK: 1789 / Failed: 0 / User-skipped: 112 / Auto-skipped: 0


dynamic_domains_23 / pgsql_mnesia / 5eb3f9b
Reports root/ big
OK: 1789 / Failed: 0 / User-skipped: 112 / Auto-skipped: 0


small_tests_23 / small_tests / 5eb3f9b
Reports root / small


ldap_mnesia_23 / ldap_mnesia / 5eb3f9b
Reports root/ big
OK: 1515 / Failed: 0 / User-skipped: 363 / Auto-skipped: 0


ldap_mnesia_24 / ldap_mnesia / 5eb3f9b
Reports root/ big
OK: 1515 / Failed: 0 / User-skipped: 363 / Auto-skipped: 0


pgsql_mnesia_22 / pgsql_mnesia / 5eb3f9b
Reports root/ big
OK: 3090 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 5eb3f9b
Reports root/ big
OK: 1891 / Failed: 0 / User-skipped: 286 / Auto-skipped: 0


mysql_redis_24 / mysql_redis / 5eb3f9b
Reports root/ big
OK: 3073 / Failed: 0 / User-skipped: 201 / Auto-skipped: 0


pgsql_mnesia_23 / pgsql_mnesia / 5eb3f9b
Reports root/ big
OK: 3090 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


mssql_mnesia_24 / odbc_mssql_mnesia / 5eb3f9b
Reports root/ big
OK: 3090 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 5eb3f9b
Reports root/ big
OK: 3090 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / 5eb3f9b
Reports root/ big
OK: 1738 / Failed: 0 / User-skipped: 289 / Auto-skipped: 0

@chrzaszcz chrzaszcz marked this pull request as ready for review September 9, 2021 10:33
Copy link
Contributor

@Premwoik Premwoik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Premwoik Premwoik merged commit a107c1d into master Sep 9, 2021
@Premwoik Premwoik deleted the bosh-with-dynamic-domains branch September 9, 2021 12:16
@Premwoik Premwoik added this to the 5.0.0 milestone Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants