Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make mod_version multitenancy ready #3256

Merged
merged 1 commit into from
Sep 10, 2021
Merged

Make mod_version multitenancy ready #3256

merged 1 commit into from
Sep 10, 2021

Conversation

NelsonVides
Copy link
Collaborator

As in the title

@codecov
Copy link

codecov bot commented Sep 9, 2021 •
edited

Codecov Report

Merging #3256 (d5a2bcc) into master (c86e7c7) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3256      +/-   ##
==========================================
- Coverage   80.33%   80.33%   -0.01%     
==========================================
  Files         398      398              
  Lines       32566    32567       +1     
==========================================
  Hits        26163    26163              
- Misses       6403     6404       +1
Impacted Files Coverage Δ
src/mod_version.erl 94.11% <100.00%> (+0.36%) ⬆️
src/event_pusher/mod_event_pusher_sns.erl 84.21% <0.00%> (-5.27%) ⬇️
src/mod_last_rdbms.erl 91.66% <0.00%> (-4.17%) ⬇️
...c/global_distrib/mod_global_distrib_server_mgr.erl 75.14% <0.00%> (-2.26%) ⬇️
...bal_distrib/mod_global_distrib_hosts_refresher.erl 71.69% <0.00%> (-1.89%) ⬇️
src/domain/mongoose_domain_loader.erl 75.47% <0.00%> (-1.89%) ⬇️
src/mod_last.erl 86.36% <0.00%> (-1.52%) ⬇️
src/privacy/mod_privacy_rdbms.erl 80.51% <0.00%> (-1.03%) ⬇️
src/rdbms/mongoose_rdbms.erl 60.88% <0.00%> (-0.81%) ⬇️
src/ejabberd_sm.erl 84.26% <0.00%> (-0.33%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c86e7c7...d5a2bcc. Read the comment docs.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Sep 9, 2021 •
edited

small_tests_24 / small_tests / b63ea3c
Reports root / small

internal_mnesia_24 / internal_mnesia / b63ea3c
Reports root/ big
OK: 1588 / Failed: 0 / User-skipped: 290 / Auto-skipped: 0

small_tests_22 / small_tests / b63ea3c
Reports root / small

dynamic_domains_24 / pgsql_mnesia / b63ea3c
Reports root/ big
OK: 1732 / Failed: 0 / User-skipped: 112 / Auto-skipped: 0

dynamic_domains_23 / pgsql_mnesia / b63ea3c
Reports root/ big
OK: 1732 / Failed: 0 / User-skipped: 112 / Auto-skipped: 0

small_tests_23 / small_tests / b63ea3c
Reports root / small

ldap_mnesia_24 / ldap_mnesia / b63ea3c
Reports root/ big
OK: 1515 / Failed: 0 / User-skipped: 363 / Auto-skipped: 0

ldap_mnesia_23 / ldap_mnesia / b63ea3c
Reports root/ big
OK: 1515 / Failed: 0 / User-skipped: 363 / Auto-skipped: 0

ldap_mnesia_22 / ldap_mnesia / b63ea3c
Reports root/ big
OK: 1515 / Failed: 0 / User-skipped: 363 / Auto-skipped: 0

pgsql_mnesia_22 / pgsql_mnesia / b63ea3c
Reports root/ big
OK: 3090 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / b63ea3c
Reports root/ big
OK: 3090 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0

pgsql_mnesia_23 / pgsql_mnesia / b63ea3c
Reports root/ big
OK: 3090 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0

elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / b63ea3c
Reports root/ big
OK: 1891 / Failed: 0 / User-skipped: 286 / Auto-skipped: 0

mysql_redis_24 / mysql_redis / b63ea3c
Reports root/ big
OK: 3073 / Failed: 0 / User-skipped: 201 / Auto-skipped: 0

mssql_mnesia_24 / odbc_mssql_mnesia / b63ea3c
Reports root/ big
OK: 3090 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / b63ea3c
Reports root/ big
OK: 1738 / Failed: 0 / User-skipped: 289 / Auto-skipped: 0

chrzaszcz
chrzaszcz reviewed Sep 10, 2021
View reviewed changes
Copy link
Member

@chrzaszcz chrzaszcz left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good in general, I have one comment.

src/mod_version.erl Outdated Show resolved Hide resolved
@mongoose-im
Copy link
Collaborator

mongoose-im commented Sep 10, 2021 •
edited

small_tests_24 / small_tests / d5a2bcc
Reports root / small

internal_mnesia_24 / internal_mnesia / d5a2bcc
Reports root/ big
OK: 1589 / Failed: 0 / User-skipped: 290 / Auto-skipped: 0

small_tests_22 / small_tests / d5a2bcc
Reports root / small

dynamic_domains_24 / pgsql_mnesia / d5a2bcc
Reports root/ big
OK: 1814 / Failed: 0 / User-skipped: 112 / Auto-skipped: 0

dynamic_domains_23 / pgsql_mnesia / d5a2bcc
Reports root/ big
OK: 1814 / Failed: 0 / User-skipped: 112 / Auto-skipped: 0

small_tests_23 / small_tests / d5a2bcc
Reports root / small

ldap_mnesia_22 / ldap_mnesia / d5a2bcc
Reports root/ big
OK: 1516 / Failed: 0 / User-skipped: 363 / Auto-skipped: 0

ldap_mnesia_24 / ldap_mnesia / d5a2bcc
Reports root/ big
OK: 1516 / Failed: 0 / User-skipped: 363 / Auto-skipped: 0

ldap_mnesia_23 / ldap_mnesia / d5a2bcc
Reports root/ big
OK: 1534 / Failed: 1 / User-skipped: 363 / Auto-skipped: 0

jingle_SUITE:all:resp_4xx_from_sip_proxy_results_in_session_terminate 
{error,
  {{assertion_failed,assert,is_iq_result,
     {xmlel,<<"iq">>,
       [{<<"from">>,<<"error.480@localhost">>},
        {<<"to">>,
         <<"alice_resp_4xx_from_sip_proxy_results_in_session_terminate_81.980686@localhost/res1">>},
        {<<"id">>,<<"e2d34e45-85b1-43e3-82e3-ec706894f81f">>},
        {<<"type">>,<<"set">>}],
       [{xmlel,<<"jingle">>,
          [{<<"xmlns">>,<<"urn:xmpp:jingle:1">>},
           {<<"action">>,<<"session-terminate">>},
           {<<"sid">>,<<"faeedd2e-f049-4df2-8a13-8f6ecc3359ba">>}],
          [{xmlel,<<"reason">>,[],
             [{xmlel,<<"general-error">>,[],[]},
            {xmlel,<<"sip-error">>,
              [{<<"code">>,<<"480">>}],
              [{xmlcdata,<<"Temporarily Unavailable">>}]}]}]}]},
     "<iq from='error.480@localhost' to='alice_resp_4xx_from_sip_proxy_results_in_session_terminate_81.980686@localhost/res1' id='e2d34e45-85b1-43e3-82e3-ec706894f81f' type='set'><jingle xmlns='urn:xmpp:jingle:1' action='session-terminate' sid='faeedd2e-f049-4df2-8a13-8f6ecc3359ba'><reason><general-error/><sip-error code='480'>Temporarily Unavailable</sip-error></reason></jingle></iq>"},
   [{escalus_new_assert,assert_true,2,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
       {line,84}]},
    {jingle_SUITE,send_initiate_and_wait_for_first_iq_set,2,
      [{file,"/home/circleci/app/big_tests/tests/jingle_SUITE.erl"},
       {line,393}]},
    {jingle_SUITE,
      '-res...

Report log

pgsql_mnesia_23 / pgsql_mnesia / d5a2bcc
Reports root/ big
OK: 3091 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / d5a2bcc
Reports root/ big
OK: 3091 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0

pgsql_mnesia_22 / pgsql_mnesia / d5a2bcc
Reports root/ big
OK: 3091 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0

elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / d5a2bcc
Reports root/ big
OK: 1892 / Failed: 0 / User-skipped: 286 / Auto-skipped: 0

mysql_redis_24 / mysql_redis / d5a2bcc
Reports root/ big
OK: 3074 / Failed: 0 / User-skipped: 201 / Auto-skipped: 0

mssql_mnesia_24 / odbc_mssql_mnesia / d5a2bcc
Reports root/ big
OK: 3091 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / d5a2bcc
Reports root/ big
OK: 1739 / Failed: 0 / User-skipped: 289 / Auto-skipped: 0

chrzaszcz
chrzaszcz approved these changes Sep 10, 2021
View reviewed changes
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@chrzaszcz chrzaszcz merged commit da5955c into master Sep 10, 2021
@chrzaszcz chrzaszcz deleted the multitenancy/mod_version branch September 10, 2021 09:05
@Premwoik Premwoik added this to the 5.0.0 milestone Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrzaszcz chrzaszcz chrzaszcz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@NelsonVides @mongoose-im @chrzaszcz @Premwoik