Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test GDPR with dynamic domains #3284

Merged
merged 2 commits into from
Sep 17, 2021
Merged

Test GDPR with dynamic domains #3284

merged 2 commits into from
Sep 17, 2021

Conversation

chrzaszcz
Copy link
Member

Enable gdpr_SUITE, skip pubsub-related tests (mod_pubsub not supported for dynamic domains).

@codecov
Copy link

codecov bot commented Sep 17, 2021 •
edited

Codecov Report

Merging #3284 (6020dea) into master (3ad1bfd) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3284      +/-   ##
==========================================
+ Coverage   80.20%   80.24%   +0.04%     
==========================================
  Files         398      398              
  Lines       32560    32560              
==========================================
+ Hits        26114    26129      +15     
+ Misses       6446     6431      -15
Impacted Files Coverage Δ
src/mod_roster_mnesia.erl 72.72% <0.00%> (-21.22%) ⬇️
src/metrics/mongoose_metrics.erl 95.45% <0.00%> (-0.65%) ⬇️
src/mod_muc_room.erl 77.12% <0.00%> (-0.06%) ⬇️
src/mod_muc.erl 73.99% <0.00%> (ø)
src/ejabberd_sm.erl 84.59% <0.00%> (+0.32%) ⬆️
src/pubsub/mod_pubsub_db_mnesia.erl 92.85% <0.00%> (+0.42%) ⬆️
src/mam/mod_mam.erl 89.16% <0.00%> (+0.83%) ⬆️
src/domain/mongoose_domain_loader.erl 79.24% <0.00%> (+1.88%) ⬆️
src/domain/mongoose_domain_sql.erl 85.71% <0.00%> (+2.85%) ⬆️
src/mongoose_tcp_listener.erl 80.85% <0.00%> (+4.25%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ad1bfd...6020dea. Read the comment docs.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Sep 17, 2021 •
edited

small_tests_24 / small_tests / 6020dea
Reports root / small

internal_mnesia_24 / internal_mnesia / 6020dea
Reports root/ big
OK: 1589 / Failed: 0 / User-skipped: 290 / Auto-skipped: 0

small_tests_22 / small_tests / 6020dea
Reports root / small

small_tests_23 / small_tests / 6020dea
Reports root / small

dynamic_domains_24 / pgsql_mnesia / 6020dea
Reports root/ big
OK: 2537 / Failed: 0 / User-skipped: 182 / Auto-skipped: 0

ldap_mnesia_24 / ldap_mnesia / 6020dea
Reports root/ big
OK: 1504 / Failed: 1 / User-skipped: 393 / Auto-skipped: 0

jingle_SUITE:all:resp_4xx_from_sip_proxy_results_in_session_terminate 
{error,
  {{assertion_failed,assert,is_iq_result,
     {xmlel,<<"iq">>,
       [{<<"from">>,<<"error.480@localhost">>},
        {<<"to">>,
         <<"alice_resp_4xx_from_sip_proxy_results_in_session_terminate_30.633612@localhost/res1">>},
        {<<"id">>,<<"219d169e-a6be-4548-8195-90fe02b015fa">>},
        {<<"type">>,<<"set">>}],
       [{xmlel,<<"jingle">>,
          [{<<"xmlns">>,<<"urn:xmpp:jingle:1">>},
           {<<"action">>,<<"session-terminate">>},
           {<<"sid">>,<<"2e09b1e0-b4d2-48ed-a1ae-bbbc0f2c8178">>}],
          [{xmlel,<<"reason">>,[],
             [{xmlel,<<"general-error">>,[],[]},
            {xmlel,<<"sip-error">>,
              [{<<"code">>,<<"480">>}],
              [{xmlcdata,<<"Temporarily Unavailable">>}]}]}]}]},
     "<iq from='error.480@localhost' to='alice_resp_4xx_from_sip_proxy_results_in_session_terminate_30.633612@localhost/res1' id='219d169e-a6be-4548-8195-90fe02b015fa' type='set'><jingle xmlns='urn:xmpp:jingle:1' action='session-terminate' sid='2e09b1e0-b4d2-48ed-a1ae-bbbc0f2c8178'><reason><general-error/><sip-error code='480'>Temporarily Unavailable</sip-error></reason></jingle></iq>"},
   [{escalus_new_assert,assert_true,2,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
       {line,84}]},
    {jingle_SUITE,send_initiate_and_wait_for_first_iq_set,2,
      [{file,"/home/circleci/app/big_tests/tests/jingle_SUITE.erl"},
       {line,393}]},
    {jingle_SUITE,
      '-res...

Report log

ldap_mnesia_22 / ldap_mnesia / 6020dea
Reports root/ big
OK: 1486 / Failed: 0 / User-skipped: 393 / Auto-skipped: 0

ldap_mnesia_23 / ldap_mnesia / 6020dea
Reports root/ big
OK: 1486 / Failed: 0 / User-skipped: 393 / Auto-skipped: 0

dynamic_domains_23 / pgsql_mnesia / 6020dea
Reports root/ big
OK: 2537 / Failed: 0 / User-skipped: 182 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / 6020dea
Reports root/ big
OK: 3061 / Failed: 3 / User-skipped: 211 / Auto-skipped: 0

service_domain_db_SUITE:db:db_keeps_syncing_after_cluster_join 
{error,{test_case_failed,{[<<"example1.com">>],
              [<<"example1.com">>,<<"example2.com">>]}}}

Report log

service_domain_db_SUITE:db:rest_with_auth:rest_delete_domain_cleans_data_from_mam 
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"bob_rest_delete_domain_cleans_data_from_mam_40.985355@example.org/res1">>,
          escalus_tcp,<0.12535.2>,
          [{event_manager,<0.12529.2>},
           {server,<<"example.org">>},
           {username,
             <<"bob_rest_delete_domain_cleans_data_from_mam_40.985355">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.12529.2>},
            {server,<<"example.org">>},
            {username,
              <<"bob_rest_delete_domain_cleans_data_from_mam_40.985355">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"bob_rest_delete_domain_cleans_data_from_mam_40.985355">>},
           {server,<<"example.org">>},
           {host,<<"localhost">>},
           {port,5232},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,
             <<"bob_rest_delete_domain_cleans_data_from_mam_40.985355">>},
           {server,<<"example.org">>},
           {host,<<"localhost">>},
           {password,<<"makota3">>},
           {port,5232},
           {stream_id,<<"84da9bcd0310b9c2">>}]},
        5000],
       [{file,
          "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {service_domain_db_SUITE,
       '-rest_delete_domain_cleans_data_from_mam/1-fun-0-',5...

Report log

service_domain_db_SUITE:db:rest_without_auth:rest_delete_domain_cleans_data_from_mam 
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"bob_rest_delete_domain_cleans_data_from_mam_49.289668@example.org/res1">>,
          escalus_tcp,<0.13171.2>,
          [{event_manager,<0.13165.2>},
           {server,<<"example.org">>},
           {username,
             <<"bob_rest_delete_domain_cleans_data_from_mam_49.289668">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.13165.2>},
            {server,<<"example.org">>},
            {username,
              <<"bob_rest_delete_domain_cleans_data_from_mam_49.289668">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"bob_rest_delete_domain_cleans_data_from_mam_49.289668">>},
           {server,<<"example.org">>},
           {host,<<"localhost">>},
           {port,5232},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,
             <<"bob_rest_delete_domain_cleans_data_from_mam_49.289668">>},
           {server,<<"example.org">>},
           {host,<<"localhost">>},
           {password,<<"makota3">>},
           {port,5232},
           {stream_id,<<"6cc64048e458ca44">>}]},
        5000],
       [{file,
          "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {service_domain_db_SUITE,
       '-rest_delete_domain_cleans_data_from_mam/1-fun-0-',5...

Report log

elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 6020dea
Reports root/ big
OK: 1862 / Failed: 0 / User-skipped: 316 / Auto-skipped: 0

mysql_redis_24 / mysql_redis / 6020dea
Reports root/ big
OK: 3047 / Failed: 0 / User-skipped: 228 / Auto-skipped: 0

pgsql_mnesia_22 / pgsql_mnesia / 6020dea
Reports root/ big
OK: 3064 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0

mssql_mnesia_24 / odbc_mssql_mnesia / 6020dea
Reports root/ big
OK: 3062 / Failed: 1 / User-skipped: 211 / Auto-skipped: 1

carboncopy_SUITE:end_per_suite 
{error,
 {{unregistering_failed,
   {amount,12},
   {unregistered_items,
  [{{<<"_prop_forward_received_chat_messages_87.909961">>,
     [{escalus_event_mgr,<0.11435.0>},
    {tc_name,prop_forward_received_chat_messages},
    {escalus_cleaner,<0.11434.0>},
    {watchdog,<0.11433.0>},
    {mim_data_dir,
     "/home/circleci/app/big_tests/tests/carboncopy_SUITE_data"},
    {preset,"odbc_mssql_mnesia"},
    {tc_logfile,
     "https://circleci-mim-results.s3.eu-central-1.amazonaws.com/PR/3284/73742/odbc_mssql_mnesia.24.0-1/big/ct_run.test%40default-d2dda555-f859-4d5c-9d04-11b14eb231d8.2021-09-17_07.48.40/big_tests.tests.carboncopy_SUITE.logs/run.2021-09-17_07.49.46/carboncopy_suite.prop_forward_received_chat_messages.2403.html"},
    {tc_group_properties,
     [{suite,carboncopy_SUITE},
      {name,all},
      {repeat_until_all_ok,3},
      parallel]},
    {tc_group_path,[]},
    {data_dir,
     "/home/circleci/app/big_tests/_build/default/lib/ejabberd_tests/ebin/carboncopy_SUITE_data/"},
    {priv_dir,
     "https://circleci-mim-results.s3.eu-central-1.amazonaws.com/PR/3284/73742/odbc_mssql_mnesia.24.0-1/big/ct_run.test%40default-d2dda555-f859-4d5c-9d04-11b14eb231d8.2021-09-17_07.48.40/big_tests.tests.carboncopy_SUITE.logs/run.2021-09-17_07.49.46/log_private/"},
    {escalus_users,
     [{alice,
       [{username,
       <<"alicE_prop_forward_received_chat_messages_87.909961">>},
      {server,<<"localhost">>},
      {password,<<"matygrysa">>}]},
      {bob,
       [{username,<<"bOb_prop_forward_received_chat_messages_87.909961">>},
      {server,<<"localhost">>},
      {password,<<"makrolika">>}]}]}]},
  ...

Report log

mongooseimctl_SUITE:stats:stats_global 
{error,{{badmatch,{"25\n",0}},
    [{mongooseimctl_SUITE,'-stats_global/1-fun-0-',3,
                [{file,"/home/circleci/app/big_tests/tests/mongooseimctl_SUITE.erl"},
                 {line,1056}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1292}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1224}]}]}}

Report log

pgsql_mnesia_23 / pgsql_mnesia / 6020dea
Reports root/ big
OK: 3064 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / 6020dea
Reports root/ big
OK: 1709 / Failed: 0 / User-skipped: 319 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / 6020dea
Reports root/ big
OK: 3064 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0

mssql_mnesia_24 / odbc_mssql_mnesia / 6020dea
Reports root/ big
OK: 3064 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0

Premwoik
Premwoik approved these changes Sep 17, 2021
View reviewed changes
Copy link
Contributor

@Premwoik Premwoik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Premwoik Premwoik merged commit 9e53098 into master Sep 17, 2021
@Premwoik Premwoik deleted the test-gdpr-with-dynamic-domains branch September 17, 2021 09:09
@Premwoik Premwoik added this to the 5.0.0 milestone Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Premwoik Premwoik Premwoik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chrzaszcz @mongoose-im @Premwoik