Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hooks and handlers docs #3300

Merged
merged 5 commits into from
Sep 27, 2021
Merged

Update hooks and handlers docs #3300

merged 5 commits into from
Sep 27, 2021

Conversation

gustawlippa
Copy link
Contributor

This PR updates hooks/handlers/accumulator pages in the docs so that they are in line with the current code.

It was looking for hooks run the old way, through ejabberd_hooks:run or
ejabberd_hooks:run_fold, and so it didn't find anything. Now it is just
enought to extract the exported functions from `mongoose_hooks`.
It makes sense to have the Accumulator overview right after Hooks and
Handlers.
@codecov
Copy link

codecov bot commented Sep 24, 2021

Codecov Report

Merging #3300 (1aecebc) into master (3c5df56) will decrease coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 1aecebc differs from pull request most recent head 7d591a1. Consider uploading reports for the commit 7d591a1 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3300      +/-   ##
==========================================
- Coverage   80.25%   80.21%   -0.04%     
==========================================
  Files         398      398              
  Lines       32559    32559              
==========================================
- Hits        26129    26118      -11     
- Misses       6430     6441      +11     
Impacted Files Coverage Δ
src/mod_smart_markers.erl 90.24% <ø> (ø)
src/event_pusher/mod_event_pusher.erl 65.00% <0.00%> (-22.50%) ⬇️
src/domain/mongoose_domain_sql.erl 82.85% <0.00%> (-2.86%) ⬇️
src/mam/mod_mam_meta.erl 94.73% <0.00%> (-2.11%) ⬇️
...bal_distrib/mod_global_distrib_hosts_refresher.erl 71.69% <0.00%> (-1.89%) ⬇️
src/domain/mongoose_domain_loader.erl 77.35% <0.00%> (-1.89%) ⬇️
src/global_distrib/mod_global_distrib_receiver.erl 78.88% <0.00%> (-1.12%) ⬇️
src/pubsub/mod_pubsub.erl 73.17% <0.00%> (-0.06%) ⬇️
src/mod_muc_room.erl 77.12% <0.00%> (-0.06%) ⬇️
src/mod_muc_log.erl 77.88% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c5df56...7d591a1. Read the comment docs.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Sep 24, 2021

small_tests_24 / small_tests / 1aecebc
Reports root / small


internal_mnesia_24 / internal_mnesia / 1aecebc
Reports root/ big
OK: 1589 / Failed: 0 / User-skipped: 290 / Auto-skipped: 0


small_tests_22 / small_tests / 1aecebc
Reports root / small


small_tests_23 / small_tests / 1aecebc
Reports root / small


dynamic_domains_23 / pgsql_mnesia / 1aecebc
Reports root/ big
OK: 2674 / Failed: 1 / User-skipped: 183 / Auto-skipped: 0

service_domain_db_SUITE:db:db_keeps_syncing_after_cluster_join
{error,{test_case_failed,{[<<"example1.com">>,<<"example2.com">>,
               <<"example3.com">>],
              [<<"example1.com">>,<<"example2.com">>,
               <<"example3.com">>,<<"example4.com">>]}}}

Report log


ldap_mnesia_22 / ldap_mnesia / 1aecebc
Reports root/ big
OK: 1486 / Failed: 0 / User-skipped: 393 / Auto-skipped: 0


dynamic_domains_24 / pgsql_mnesia / 1aecebc
Reports root/ big
OK: 2675 / Failed: 0 / User-skipped: 183 / Auto-skipped: 0


ldap_mnesia_23 / ldap_mnesia / 1aecebc
Reports root/ big
OK: 1486 / Failed: 0 / User-skipped: 393 / Auto-skipped: 0


pgsql_mnesia_23 / pgsql_mnesia / 1aecebc
Reports root/ big
OK: 3064 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0


ldap_mnesia_24 / ldap_mnesia / 1aecebc
Reports root/ big
OK: 1486 / Failed: 0 / User-skipped: 393 / Auto-skipped: 0


elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 1aecebc
Reports root/ big
OK: 1862 / Failed: 0 / User-skipped: 316 / Auto-skipped: 0


pgsql_mnesia_22 / pgsql_mnesia / 1aecebc
Reports root/ big
OK: 3064 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0


mssql_mnesia_24 / odbc_mssql_mnesia / 1aecebc
Reports root/ big
OK: 3064 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 1aecebc
Reports root/ big
OK: 3064 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0


mysql_redis_24 / mysql_redis / 1aecebc
Reports root/ big
OK: 3056 / Failed: 2 / User-skipped: 228 / Auto-skipped: 0

mam_SUITE:rdbms_prefs_cases:prefs_set_request
{error,{test_case_failed,"ASSERT EQUAL\n\tExpected {prefs_result_iq,<<\"roster\">>,\n                  [<<\"romeo@montague.net\">>],\n                  [<<\"montague@montague.net\">>]}\n\tValue {prefs_result_iq,<<\"always\">>,\n                 [<<\"romeo@montague.net\">>],\n                 [<<\"montague@montague.net\">>]}\n"}}

Report log

mod_event_pusher_rabbit_SUITE:group_chat_message_publish:group_chat_message_received_event_properly_formatted
{error,
  {{assertMatch,
     [{module,mod_event_pusher_rabbit_SUITE},
      {line,435},
      {expression,
        "get_decoded_message_from_rabbit ( AliceGroupChatMsgRecvRK )"},
      {pattern,
        "# { << \"from_user_id\" >> := BobRoomJID , << \"to_user_id\" >> := AliceFullJID , << \"message\" >> := Message }"},
      {value,
        #{<<"from_user_id">> => <<"muc_publish@muc.localhost">>,
        <<"message">> => <<>>,
        <<"to_user_id">> =>
          <<"alice_unnamed_41.658975@localhost/res1">>}}]},
   [{mod_event_pusher_rabbit_SUITE,
      '-group_chat_message_received_event_properly_formatted/1-fun-1-',3,
      [{file,
         "/home/circleci/app/big_tests/tests/mod_event_pusher_rabbit_SUITE.erl"},
       {line,435}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1292}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1224}]}]}}

Report log


riak_mnesia_24 / riak_mnesia / 1aecebc
Reports root/ big
OK: 1709 / Failed: 0 / User-skipped: 319 / Auto-skipped: 0


dynamic_domains_23 / pgsql_mnesia / 1aecebc
Reports root/ big
OK: 2675 / Failed: 0 / User-skipped: 183 / Auto-skipped: 0

vkatsuba
vkatsuba previously approved these changes Sep 27, 2021
@vkatsuba vkatsuba self-requested a review September 27, 2021 09:01
@vkatsuba vkatsuba dismissed their stale review September 27, 2021 09:02

Missing some review

Co-authored-by: Viacheslav Katsuba <v.katsuba.dev@gmail.com>
@vkatsuba vkatsuba merged commit 5320372 into master Sep 27, 2021
@vkatsuba vkatsuba deleted the doc-hooks-update branch September 27, 2021 09:18
@mongoose-im
Copy link
Collaborator

mongoose-im commented Sep 27, 2021

small_tests_24 / small_tests / 7d591a1
Reports root / small


internal_mnesia_24 / internal_mnesia / 7d591a1
Reports root/ big
OK: 1589 / Failed: 0 / User-skipped: 290 / Auto-skipped: 0


small_tests_22 / small_tests / 7d591a1
Reports root / small


small_tests_23 / small_tests / 7d591a1
Reports root / small


ldap_mnesia_24 / ldap_mnesia / 7d591a1
Reports root/ big
OK: 1486 / Failed: 0 / User-skipped: 393 / Auto-skipped: 0


dynamic_domains_24 / pgsql_mnesia / 7d591a1
Reports root/ big
OK: 2675 / Failed: 0 / User-skipped: 183 / Auto-skipped: 0


dynamic_domains_23 / pgsql_mnesia / 7d591a1
Reports root/ big
OK: 2674 / Failed: 1 / User-skipped: 183 / Auto-skipped: 0

dynamic_domains_SUITE:with_mod_dynamic_domains_test:packet_handling_for_subdomain
{error,
  {{badrpc,
     {'EXIT',
       {timeout,
         [{meck_proc,wait,6,
            [{file,
               "/home/circleci/app/_build/default/lib/meck/src/meck_proc.erl"},
             {line,171}]},
          {meck,wait,5,[]}]}}},
   [{distributed_helper,rpc,
      [#{node => mongooseim@localhost},
       meck,wait,
       [3,mod_dynamic_domains_test,process_packet,5,500]],
      [{file,"/home/circleci/app/big_tests/tests/distributed_helper.erl"},
       {line,117}]},
    {dynamic_domains_SUITE,'-packet_handling_for_subdomain/1-fun-3-',1,
      [{file,
         "/home/circleci/app/big_tests/tests/dynamic_domains_SUITE.erl"},
       {line,113}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1784}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1293}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1225}]}]}}

Report log


ldap_mnesia_22 / ldap_mnesia / 7d591a1
Reports root/ big
OK: 1486 / Failed: 0 / User-skipped: 393 / Auto-skipped: 0


ldap_mnesia_23 / ldap_mnesia / 7d591a1
Reports root/ big
OK: 1486 / Failed: 0 / User-skipped: 393 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 7d591a1
Reports root/ big
OK: 3064 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0


pgsql_mnesia_22 / pgsql_mnesia / 7d591a1
Reports root/ big
OK: 3064 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0


elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 7d591a1
Reports root/ big
OK: 1862 / Failed: 0 / User-skipped: 316 / Auto-skipped: 0


mysql_redis_24 / mysql_redis / 7d591a1
Reports root/ big
OK: 3047 / Failed: 0 / User-skipped: 228 / Auto-skipped: 0


pgsql_mnesia_23 / pgsql_mnesia / 7d591a1
Reports root/ big
OK: 3064 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0


mssql_mnesia_24 / odbc_mssql_mnesia / 7d591a1
Reports root/ big
OK: 3064 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / 7d591a1
Reports root/ big
OK: 1709 / Failed: 0 / User-skipped: 319 / Auto-skipped: 0

@Premwoik Premwoik added this to the 5.0.0 milestone Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants