Routing shouldnt create new accs if ones are already available #3314
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## master #3314 +/- ##
=======================================
Coverage 80.70% 80.70%
=======================================
Files 397 397
Lines 32439 32439
=======================================
+ Hits 26180 26181 +1
+ Misses 6259 6258 -1
Continue to review full report at Codecov.
|
NelsonVides
changed the title
This comment has been minimized.
This comment has been minimized.
NelsonVides
force-pushed
the
acc/less_news
branch
from
33eaaab
to
56ba94d
Compare
|
small_tests_24 / small_tests / 56ba94d internal_mnesia_24 / internal_mnesia / 56ba94d small_tests_23 / small_tests / 56ba94d dynamic_domains_24 / pgsql_mnesia / 56ba94d ldap_mnesia_24 / ldap_mnesia / 56ba94d dynamic_domains_23 / pgsql_mnesia / 56ba94d ldap_mnesia_23 / ldap_mnesia / 56ba94d pgsql_mnesia_24 / pgsql_mnesia / 56ba94d jingle_SUITE:all:resp_4xx_from_sip_proxy_results_in_session_terminate{error,
{{assertion_failed,assert,is_iq_result,
{xmlel,<<"iq">>,
[{<<"from">>,<<"error.480@localhost">>},
{<<"to">>,
<<"alice_resp_4xx_from_sip_proxy_results_in_session_terminate_28.781492@localhost/res1">>},
{<<"id">>,<<"f7960385-8216-43a6-9c46-02a9292ffff5">>},
{<<"type">>,<<"set">>}],
[{xmlel,<<"jingle">>,
[{<<"xmlns">>,<<"urn:xmpp:jingle:1">>},
{<<"action">>,<<"session-terminate">>},
{<<"sid">>,<<"b81579c1-f28f-4d7c-8495-612fef933cfb">>}],
[{xmlel,<<"reason">>,[],
[{xmlel,<<"general-error">>,[],[]},
{xmlel,<<"sip-error">>,
[{<<"code">>,<<"480">>}],
[{xmlcdata,<<"Temporarily Unavailable">>}]}]}]}]},
"<iq from='error.480@localhost' to='alice_resp_4xx_from_sip_proxy_results_in_session_terminate_28.781492@localhost/res1' id='f7960385-8216-43a6-9c46-02a9292ffff5' type='set'><jingle xmlns='urn:xmpp:jingle:1' action='session-terminate' sid='b81579c1-f28f-4d7c-8495-612fef933cfb'><reason><general-error/><sip-error code='480'>Temporarily Unavailable</sip-error></reason></jingle></iq>"},
[{escalus_new_assert,assert_true,2,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{jingle_SUITE,send_initiate_and_wait_for_first_iq_set,2,
[{file,"/home/circleci/app/big_tests/tests/jingle_SUITE.erl"},
{line,395}]},
{jingle_SUITE,
'-res...elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 56ba94d connect_SUITE:just_tls:feature_order:auth_compression_bind_session{error,
{{badmatch,
{error,
{connection_step_failed,
{{escalus_session,maybe_use_compression},
{client,
<<"secure_joe_auth_compression_bind_session_18.867048@localhost">>,
escalus_tcp,<0.11885.0>,undefined,
[{username,
<<"secure_joe_auth_compression_bind_session_18.867048">>},
{server,<<"localhost">>},
{password,<<"break_me">>},
{compression,<<"zlib">>},
{starttls,required},
{host,<<"localhost">>},
{stream_id,<<"ce4acbf17736adea">>}]},
[{compression,[<<"zlib">>]},
{starttls,false},
{stream_management,true},
{advanced_message_processing,true},
{client_state_indication,false},
{sasl_mechanisms,[<<"SCRAM-SHA-256">>,<<"PLAIN">>]},
{caps,undefined}]},
{timeout,compressed}}}},
[{connect_SUITE,auth_compression_bind_session,1,
[{file,"/home/circleci/app/big_tests/tests/connect_SUITE.erl"},
{line,517}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}}mysql_redis_24 / mysql_redis / 56ba94d rest_client_SUITE:muc:messages_can_be_paginated_in_room{error,
{{assertion_failed,assert,is_chat_message,
[<<"013e08e3">>],
{xmlel,<<"message">>,
[{<<"to">>,<<"1633-347121-58782@muclight.localhost">>},
{<<"type">>,<<"chat">>}],
[{xmlel,<<"body">>,[],[{xmlcdata,<<"9dc06d78">>}]}]},
"<message to='1633-347121-58782@muclight.localhost' type='chat'><body>9dc06d78</body></message>"},
[{escalus_new_assert,assert_true,2,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{rest_client_SUITE,assert_room_messages,2,
[{file,"/home/circleci/app/big_tests/tests/rest_client_SUITE.erl"},
{line,772}]},
{escalus_story,story,4,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}}pgsql_mnesia_23 / pgsql_mnesia / 56ba94d mssql_mnesia_24 / odbc_mssql_mnesia / 56ba94d riak_mnesia_24 / riak_mnesia / 56ba94d |
Again, those accs might contain useful data we don't want to calculate again. In the case of carbons for example, hostypes, lservers, and timestamps, are the same for all copies, no need to recalculate again.