GraphQL in MongooseIM proof of concept #3354
Conversation
This comment has been minimized.
This comment has been minimized.
Premwoik
force-pushed
the
mim-graphql-poc
branch
from
4c2ac1e
to
49ea787
Compare
Codecov Report
@@ Coverage Diff @@
## feature/graphql #3354 +/- ##
===================================================
- Coverage 80.76% 80.75% -0.01%
===================================================
Files 414 423 +9
Lines 32335 32525 +190
===================================================
+ Hits 26116 26267 +151
- Misses 6219 6258 +39
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Premwoik
force-pushed
the
mim-graphql-poc
branch
from
b33e701
to
deb0fdc
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Premwoik
force-pushed
the
mim-graphql-poc
branch
from
df29384
to
f3a51a9
Compare
This comment has been minimized.
This comment has been minimized.
Premwoik
force-pushed
the
mim-graphql-poc
branch
from
f3a51a9
to
23a373b
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Premwoik
force-pushed
the
mim-graphql-poc
branch
from
c164a4e
to
327b103
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Premwoik
force-pushed
the
mim-graphql-poc
branch
from
f04067f
to
66de038
Compare
This comment has been minimized.
This comment has been minimized.
Premwoik
force-pushed
the
mim-graphql-poc
branch
from
66de038
to
10baf3b
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Seems that the latest versions of GraphiQL don't work with the Erlang GraphQL library, so I downgrade to the last working one.
- Fix descriptions - Make tests paralell - Add graphql_SUITE to default.spec - Log schema loading error - Simplify mongoose_graphql_cowboy_handler init
Premwoik
force-pushed
the
mim-graphql-poc
branch
from
f88e4d3
to
0a27425
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Premwoik
force-pushed
the
mim-graphql-poc
branch
from
197cf8a
to
38b8fea
Compare
This comment has been minimized.
This comment has been minimized.
|
small_tests_23 / small_tests / fba3a94 small_tests_24 / small_tests / fba3a94 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / fba3a94 dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / fba3a94 dynamic_domains_mysql_redis_24 / mysql_redis / fba3a94 sm_SUITE:parallel:messages_are_properly_flushed_during_resumption{error,
{{badmatch,
{error,
{connection_step_failed,
{#Fun<sm_SUITE.11.68776247>,
{client,
<<"alicE_messages_are_properly_flushed_during_resumption_1821@domain.example.com">>,
escalus_tcp,<0.30958.1>,undefined,
[{username,
<<"alicE_messages_are_properly_flushed_during_resumption_1821">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{password,<<"matygrysa">>},
{stream_management,true},
{stream_id,<<"cc96bd4c901386b7">>}]},
[{compression,[<<"zlib">>]},
{starttls,true},
{stream_management,true},
{advanced_message_processing,true},
{client_state_indication,false},
{sasl_mechanisms,[<<"SCRAM-SHA-256">>,<<"PLAIN">>]},
{caps,undefined}]},
{timeout,get_resumed}}}},
[{sm_SUITE,'-messages_are_properly_flushed_during_resumption/1-fun-1-',
3,
[{file,"/home/circleci/project/big_tests/tests/sm_SUITE.erl"},
{line,1226}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}}dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / fba3a94 ldap_mnesia_24 / ldap_mnesia / fba3a94 ldap_mnesia_23 / ldap_mnesia / fba3a94 internal_mnesia_24 / internal_mnesia / fba3a94 pgsql_mnesia_24 / pgsql_mnesia / fba3a94 pgsql_mnesia_23 / pgsql_mnesia / fba3a94 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / fba3a94 mysql_redis_24 / mysql_redis / fba3a94 mssql_mnesia_24 / odbc_mssql_mnesia / fba3a94 riak_mnesia_24 / riak_mnesia / fba3a94 |
| @@ -0,0 +1,205 @@ | |||
| -module(graphql_SUITE). | |||
There was a problem hiding this comment.
Maybe add it to dynamic_domains.spec as well to be tested also in the dynamic domains presets?
This comment has been minimized.
This comment has been minimized.
- Use jiffy instead of jsx - Fix descriptions - Other small fixes
Premwoik
force-pushed
the
mim-graphql-poc
branch
from
b5532f5
to
a719db0
Compare
|
small_tests_24 / small_tests / a719db0 small_tests_23 / small_tests / a719db0 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / a719db0 dynamic_domains_mysql_redis_24 / mysql_redis / a719db0 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / a719db0 mam_SUITE:rdbms_async_pool_muc_all:muc06:muc_show_x_user_to_moderators_in_anon_rooms{error,{test_case_failed,"Respond size is 0, 1 is expected."}}dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / a719db0 ldap_mnesia_24 / ldap_mnesia / a719db0 ldap_mnesia_23 / ldap_mnesia / a719db0 internal_mnesia_24 / internal_mnesia / a719db0 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / a719db0 mysql_redis_24 / mysql_redis / a719db0 pgsql_mnesia_23 / pgsql_mnesia / a719db0 pgsql_mnesia_24 / pgsql_mnesia / a719db0 mssql_mnesia_24 / odbc_mssql_mnesia / a719db0 riak_mnesia_24 / riak_mnesia / a719db0 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / a719db0 |
There was a problem hiding this comment.
looks good, but I have a few comments that must be addressed in the following PRs:
- I think we can get rid of separate schemas for big_tests, more over that would be nice to test exactly what is config file. I some specific case requires a dedicated schema - we may want to add it in /priv/graphql/test_schema directory instead of keeping copies for every SUITE, however I would prefer to test such cases as unit tests.
- please don't forget to change git reference for graphql in rebar.config file before merging feature branch to master. it can be either original repo (if they accept your PR) or we should make ESL's fork.
This PR proposes how MIM Rest API and CLI could be replaced by GraphQL in the future.
TODO:
Multi-schema adaptation
To do in other PR: