Mod roster remove dynamic modules #3364

JanuszJakubiec · 2021-10-26T06:38:33Z

Removing dynamically compiled modules from mod_roster

mongoose-im · 2021-10-26T06:52:12Z

small_tests_24 / small_tests / 6c14607
Reports root / small

internal_mnesia_24 / internal_mnesia / 6c14607
Reports root/ big
OK: 1589 / Failed: 0 / User-skipped: 297 / Auto-skipped: 0

small_tests_23 / small_tests / 6c14607
Reports root / small

ldap_mnesia_24 / ldap_mnesia / 6c14607
Reports root/ big
OK: 1486 / Failed: 0 / User-skipped: 400 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 6c14607
Reports root/ big
OK: 2702 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0

dynamic_domains_mysql_redis_24 / mysql_redis / 6c14607
Reports root/ big
OK: 2685 / Failed: 0 / User-skipped: 201 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 6c14607
Reports root/ big
OK: 2702 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 6c14607
Reports root/ big
OK: 2702 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0

ldap_mnesia_23 / ldap_mnesia / 6c14607
Reports root/ big
OK: 1486 / Failed: 0 / User-skipped: 400 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / 6c14607
Reports root/ big
OK: 3071 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0

elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 6c14607
Reports root/ big
OK: 1862 / Failed: 0 / User-skipped: 323 / Auto-skipped: 0

mysql_redis_24 / mysql_redis / 6c14607
Reports root/ big
OK: 3054 / Failed: 0 / User-skipped: 228 / Auto-skipped: 0

pgsql_mnesia_23 / pgsql_mnesia / 6c14607
Reports root/ big
OK: 3071 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0

mssql_mnesia_24 / odbc_mssql_mnesia / 6c14607
Reports root/ big
OK: 3071 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / 6c14607
Reports root/ big
OK: 1709 / Failed: 0 / User-skipped: 326 / Auto-skipped: 0

codecov · 2021-10-26T06:52:19Z

Codecov Report

Merging #3364 (e29d70a) into without-dynamic-backend-modules (c159446) will decrease coverage by 0.07%.
The diff coverage is 96.42%.

@@                         Coverage Diff                         @@
##           without-dynamic-backend-modules    #3364      +/-   ##
===================================================================
- Coverage                            80.92%   80.85%   -0.08%     
===================================================================
  Files                                  412      413       +1     
  Lines                                32613    32639      +26     
===================================================================
- Hits                                 26391    26389       -2     
- Misses                                6222     6250      +28

Impacted Files	Coverage Δ
src/mod_roster.erl	`78.99% <ø> (-0.10%)`	⬇️
src/mod_roster_mnesia.erl	`93.93% <ø> (ø)`
src/mod_roster_rdbms.erl	`96.15% <ø> (ø)`
src/mod_roster_riak.erl	`81.53% <ø> (-15.39%)`	⬇️
src/mod_roster_backend.erl	`96.42% <96.42%> (ø)`
src/event_pusher/mod_event_pusher_sns.erl	`84.21% <0.00%> (-5.27%)`	⬇️
src/mod_last_rdbms.erl	`96.15% <0.00%> (-3.85%)`	⬇️
src/domain/mongoose_domain_sql.erl	`82.85% <0.00%> (-2.86%)`	⬇️
src/mod_bosh.erl	`91.83% <0.00%> (-2.05%)`	⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c8d7fd...e29d70a. Read the comment docs.

mongoose-im · 2021-10-26T07:18:59Z

small_tests_24 / small_tests / 42ed2ab
Reports root / small

internal_mnesia_24 / internal_mnesia / 42ed2ab
Reports root/ big
OK: 1589 / Failed: 0 / User-skipped: 297 / Auto-skipped: 0

small_tests_23 / small_tests / 42ed2ab
Reports root / small

dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 42ed2ab
Reports root/ big
OK: 2702 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0

ldap_mnesia_24 / ldap_mnesia / 42ed2ab
Reports root/ big
OK: 1486 / Failed: 0 / User-skipped: 400 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 42ed2ab
Reports root/ big
OK: 2702 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0

ldap_mnesia_23 / ldap_mnesia / 42ed2ab
Reports root/ big
OK: 1486 / Failed: 0 / User-skipped: 400 / Auto-skipped: 0

dynamic_domains_mysql_redis_24 / mysql_redis / 42ed2ab
Reports root/ big
OK: 2685 / Failed: 0 / User-skipped: 201 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 42ed2ab
Reports root/ big
OK: 2702 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0

pgsql_mnesia_23 / pgsql_mnesia / 42ed2ab
Reports root/ big
OK: 3071 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0

mysql_redis_24 / mysql_redis / 42ed2ab
Reports root/ big
OK: 3054 / Failed: 0 / User-skipped: 228 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / 42ed2ab
Reports root/ big
OK: 3071 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0

elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 42ed2ab
Reports root/ big
OK: 1862 / Failed: 0 / User-skipped: 323 / Auto-skipped: 0

mssql_mnesia_24 / odbc_mssql_mnesia / 42ed2ab
Reports root/ big
OK: 3071 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / 42ed2ab
Reports root/ big
OK: 1709 / Failed: 0 / User-skipped: 326 / Auto-skipped: 0

src/mod_roster_backend.erl

mongoose-im · 2021-10-27T07:41:47Z

small_tests_24 / small_tests / d653ba0
Reports root / small

internal_mnesia_24 / internal_mnesia / d653ba0
Reports root/ big
OK: 1589 / Failed: 0 / User-skipped: 297 / Auto-skipped: 0

small_tests_23 / small_tests / d653ba0
Reports root / small

ldap_mnesia_24 / ldap_mnesia / d653ba0
Reports root/ big
OK: 1486 / Failed: 0 / User-skipped: 400 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / d653ba0
Reports root/ big
OK: 2702 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0

dynamic_domains_mysql_redis_24 / mysql_redis / d653ba0
Reports root/ big
OK: 2685 / Failed: 0 / User-skipped: 201 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / d653ba0
Reports root/ big
OK: 2702 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / d653ba0
Reports root/ big
OK: 2702 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0

elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / d653ba0
Reports root/ big
OK: 1862 / Failed: 0 / User-skipped: 323 / Auto-skipped: 0

ldap_mnesia_23 / ldap_mnesia / d653ba0
Reports root/ big
OK: 1486 / Failed: 0 / User-skipped: 400 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / d653ba0
Reports root/ big
OK: 3071 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0

pgsql_mnesia_23 / pgsql_mnesia / d653ba0
Reports root/ big
OK: 3071 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0

mysql_redis_24 / mysql_redis / d653ba0
Reports root/ big
OK: 3054 / Failed: 0 / User-skipped: 228 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / d653ba0
Reports root/ big
OK: 1709 / Failed: 0 / User-skipped: 326 / Auto-skipped: 0

gustawlippa

Looks OK, only the conflict in rebar.config should be resolved.

chrzaszcz

Looks good!

…-dynamic-modules

mongoose-im · 2021-11-02T07:23:04Z

small_tests_24 / small_tests / e29d70a
Reports root / small

internal_mnesia_24 / internal_mnesia / e29d70a
Reports root/ big
OK: 1589 / Failed: 0 / User-skipped: 297 / Auto-skipped: 0

small_tests_23 / small_tests / e29d70a
Reports root / small

ldap_mnesia_24 / ldap_mnesia / e29d70a
Reports root/ big
OK: 1486 / Failed: 0 / User-skipped: 400 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / e29d70a
Reports root/ big
OK: 2702 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / e29d70a
Reports root/ big
OK: 2702 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0

ldap_mnesia_23 / ldap_mnesia / e29d70a
Reports root/ big
OK: 1486 / Failed: 0 / User-skipped: 400 / Auto-skipped: 0

dynamic_domains_mysql_redis_24 / mysql_redis / e29d70a
Reports root/ big
OK: 2691 / Failed: 1 / User-skipped: 201 / Auto-skipped: 0

mam_SUITE:rdbms_prefs_cases:prefs_set_cdata_request

{error,{test_case_failed,"ASSERT EQUAL\n\tExpected {prefs_result_iq,<<\"roster\">>,\n                  [<<\"montague@montague.net\">>,\n                   <<\"romeo@montague.net\">>],\n                  []}\n\tValue {prefs_result_iq,<<\"always\">>,\n                 [<<\"montague@montague.net\">>,\n                <<\"romeo@montague.net\">>],\n                 []}\n"}}

Report log

dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / e29d70a
Reports root/ big
OK: 2702 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0

elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / e29d70a
Reports root/ big
OK: 1862 / Failed: 0 / User-skipped: 323 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / e29d70a
Reports root/ big
OK: 3071 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0

pgsql_mnesia_23 / pgsql_mnesia / e29d70a
Reports root/ big
OK: 3071 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0

mysql_redis_24 / mysql_redis / e29d70a
Reports root/ big
OK: 3060 / Failed: 1 / User-skipped: 228 / Auto-skipped: 0

mam_SUITE:rdbms_async_pool_prefs_cases:messages_filtered_when_prefs_default_policy_is_roster

{error,{test_case_failed,"ASSERT EQUAL\n\tExpected []\n\tValue [ok]\n"}}

Report log

mssql_mnesia_24 / odbc_mssql_mnesia / e29d70a
Reports root/ big
OK: 3071 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / e29d70a
Reports root/ big
OK: 1709 / Failed: 0 / User-skipped: 326 / Auto-skipped: 0

Janusz Jakubiec added 2 commits October 26, 2021 08:24

Removing dynamically compiled modules from mod_roster

3f74c5c

Fixing big-tests

6c14607

Removing mod_roster from rebar.config

42ed2ab

gustawlippa reviewed Oct 26, 2021

View reviewed changes

src/mod_roster_backend.erl Outdated Show resolved Hide resolved

Fixing mod_roster_backend to allow optional callbacks

d653ba0

gustawlippa approved these changes Oct 28, 2021

View reviewed changes

chrzaszcz approved these changes Nov 2, 2021

View reviewed changes

Merge branch 'without-dynamic-backend-modules' into mod-roster-remove…

e29d70a

…-dynamic-modules

gustawlippa merged commit 0c2bca9 into without-dynamic-backend-modules Nov 2, 2021

gustawlippa deleted the mod-roster-remove-dynamic-modules branch November 2, 2021 08:54

Premwoik modified the milestone: 5.1.0 May 25, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mod roster remove dynamic modules #3364

Mod roster remove dynamic modules #3364

JanuszJakubiec commented Oct 26, 2021

mongoose-im commented Oct 26, 2021 •

edited

codecov bot commented Oct 26, 2021 •

edited

mongoose-im commented Oct 26, 2021 •

edited

mongoose-im commented Oct 27, 2021 •

edited

gustawlippa left a comment

chrzaszcz left a comment

mongoose-im commented Nov 2, 2021 •

edited

Mod roster remove dynamic modules #3364

Mod roster remove dynamic modules #3364

Conversation

JanuszJakubiec commented Oct 26, 2021

mongoose-im commented Oct 26, 2021 • edited

codecov bot commented Oct 26, 2021 • edited

Codecov Report

mongoose-im commented Oct 26, 2021 • edited

mongoose-im commented Oct 27, 2021 • edited

gustawlippa left a comment

Choose a reason for hiding this comment

chrzaszcz left a comment

Choose a reason for hiding this comment

mongoose-im commented Nov 2, 2021 • edited

mongoose-im commented Oct 26, 2021 •

edited

codecov bot commented Oct 26, 2021 •

edited

mongoose-im commented Oct 26, 2021 •

edited

mongoose-im commented Oct 27, 2021 •

edited

mongoose-im commented Nov 2, 2021 •

edited