Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing optional callback in mod_offline #3371

Merged

Conversation

JanuszJakubiec
Copy link
Contributor

Fixing optional callback in mod_offline

@codecov
Copy link

codecov bot commented Oct 27, 2021

Codecov Report

Merging #3371 (14f8f2f) into without-dynamic-backend-modules (4748b9a) will increase coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@                         Coverage Diff                         @@
##           without-dynamic-backend-modules    #3371      +/-   ##
===================================================================
+ Coverage                            80.85%   80.87%   +0.01%     
===================================================================
  Files                                  410      410              
  Lines                                32664    32666       +2     
===================================================================
+ Hits                                 26412    26417       +5     
+ Misses                                6252     6249       -3     
Impacted Files Coverage Δ
src/offline/mod_offline_backend.erl 95.23% <66.66%> (-4.77%) ⬇️
src/event_pusher/mod_event_pusher.erl 65.00% <0.00%> (-22.50%) ⬇️
src/ejabberd.erl 45.00% <0.00%> (-10.00%) ⬇️
src/ejabberd_sm.erl 84.41% <0.00%> (-0.33%) ⬇️
src/mod_bosh_socket.erl 78.88% <0.00%> (-0.32%) ⬇️
src/ejabberd_c2s.erl 89.29% <0.00%> (-0.23%) ⬇️
src/mod_muc_log.erl 77.88% <0.00%> (ø)
src/pubsub/mod_pubsub.erl 73.23% <0.00%> (+0.05%) ⬆️
src/inbox/mod_inbox_rdbms.erl 93.12% <0.00%> (+0.62%) ⬆️
...c/global_distrib/mod_global_distrib_server_mgr.erl 76.83% <0.00%> (+2.25%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea8afc2...14f8f2f. Read the comment docs.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Oct 27, 2021

small_tests_24 / small_tests / 14f8f2f
Reports root / small


internal_mnesia_24 / internal_mnesia / 14f8f2f
Reports root/ big
OK: 1589 / Failed: 0 / User-skipped: 297 / Auto-skipped: 0


small_tests_23 / small_tests / 14f8f2f
Reports root / small


dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 14f8f2f
Reports root/ big
OK: 2702 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


ldap_mnesia_24 / ldap_mnesia / 14f8f2f
Reports root/ big
OK: 1486 / Failed: 0 / User-skipped: 400 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 14f8f2f
Reports root/ big
OK: 2702 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


ldap_mnesia_23 / ldap_mnesia / 14f8f2f
Reports root/ big
OK: 1486 / Failed: 0 / User-skipped: 400 / Auto-skipped: 0


dynamic_domains_mysql_redis_24 / mysql_redis / 14f8f2f
Reports root/ big
OK: 2735 / Failed: 2 / User-skipped: 201 / Auto-skipped: 0

rest_client_SUITE:muc:messages_can_be_paginated_in_room
{error,
  {{assertion_failed,assert,is_chat_message,
     [<<"09b0997f">>],
     {xmlel,<<"message">>,
       [{<<"to">>,<<"1635-320875-261902@muclight2.domain.example.com">>},
        {<<"type">>,<<"chat">>}],
       [{xmlel,<<"body">>,[],[{xmlcdata,<<"20d56a63">>}]}]},
     "<message to='1635-320875-261902@muclight2.domain.example.com' type='chat'><body>20d56a63</body></message>"},
   [{escalus_new_assert,assert_true,2,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
       {line,84}]},
    {rest_client_SUITE,assert_room_messages,2,
      [{file,"/home/circleci/app/big_tests/tests/rest_client_SUITE.erl"},
       {line,772}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1292}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1224}]}]}}

Report log

rest_client_SUITE:muc:messages_can_be_paginated_in_room
{error,
  {{assertion_failed,assert,is_chat_message,
     [<<"c258b03d">>],
     {xmlel,<<"message">>,
       [{<<"to">>,<<"1635-320879-195809@muclight2.domain.example.com">>},
        {<<"type">>,<<"chat">>}],
       [{xmlel,<<"body">>,[],[{xmlcdata,<<"ff43e71f">>}]}]},
     "<message to='1635-320879-195809@muclight2.domain.example.com' type='chat'><body>ff43e71f</body></message>"},
   [{escalus_new_assert,assert_true,2,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
       {line,84}]},
    {rest_client_SUITE,assert_room_messages,2,
      [{file,"/home/circleci/app/big_tests/tests/rest_client_SUITE.erl"},
       {line,772}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1292}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1224}]}]}}

Report log


dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 14f8f2f
Reports root/ big
OK: 2702 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 14f8f2f
Reports root/ big
OK: 1862 / Failed: 0 / User-skipped: 323 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 14f8f2f
Reports root/ big
OK: 3071 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0


mysql_redis_24 / mysql_redis / 14f8f2f
Reports root/ big
OK: 3060 / Failed: 1 / User-skipped: 228 / Auto-skipped: 0

mam_SUITE:rdbms_prefs_cases:messages_filtered_when_prefs_default_policy_is_roster
{error,{test_case_failed,"ASSERT EQUAL\n\tExpected []\n\tValue [ok]\n"}}

Report log


pgsql_mnesia_23 / pgsql_mnesia / 14f8f2f
Reports root/ big
OK: 3071 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0


mssql_mnesia_24 / odbc_mssql_mnesia / 14f8f2f
Reports root/ big
OK: 3089 / Failed: 1 / User-skipped: 211 / Auto-skipped: 0

jingle_SUITE:all:resp_4xx_from_sip_proxy_results_in_session_terminate
{error,
  {{assertion_failed,assert,is_iq_result,
     {xmlel,<<"iq">>,
       [{<<"from">>,<<"error.480@localhost">>},
        {<<"to">>,
         <<"alice_resp_4xx_from_sip_proxy_results_in_session_terminate_7.588408@localhost/res1">>},
        {<<"id">>,<<"4af0c6a4-64d0-4256-badd-78dca3bdbbb5">>},
        {<<"type">>,<<"set">>}],
       [{xmlel,<<"jingle">>,
          [{<<"xmlns">>,<<"urn:xmpp:jingle:1">>},
           {<<"action">>,<<"session-terminate">>},
           {<<"sid">>,<<"d8df6ab0-745e-4d1d-89e1-184c495afdd7">>}],
          [{xmlel,<<"reason">>,[],
             [{xmlel,<<"general-error">>,[],[]},
            {xmlel,<<"sip-error">>,
              [{<<"code">>,<<"480">>}],
              [{xmlcdata,<<"Temporarily Unavailable">>}]}]}]}]},
     "<iq from='error.480@localhost' to='alice_resp_4xx_from_sip_proxy_results_in_session_terminate_7.588408@localhost/res1' id='4af0c6a4-64d0-4256-badd-78dca3bdbbb5' type='set'><jingle xmlns='urn:xmpp:jingle:1' action='session-terminate' sid='d8df6ab0-745e-4d1d-89e1-184c495afdd7'><reason><general-error/><sip-error code='480'>Temporarily Unavailable</sip-error></reason></jingle></iq>"},
   [{escalus_new_assert,assert_true,2,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
       {line,84}]},
    {jingle_SUITE,send_initiate_and_wait_for_first_iq_set,2,
      [{file,"/home/circleci/app/big_tests/tests/jingle_SUITE.erl"},
       {line,395}]},
    {jingle_SUITE,
      '-resp_...

Report log


riak_mnesia_24 / riak_mnesia / 14f8f2f
Reports root/ big
OK: 1709 / Failed: 0 / User-skipped: 326 / Auto-skipped: 0


dynamic_domains_mysql_redis_24 / mysql_redis / 14f8f2f
Reports root/ big
OK: 2685 / Failed: 0 / User-skipped: 201 / Auto-skipped: 0

@gustawlippa gustawlippa merged commit d106506 into without-dynamic-backend-modules Oct 27, 2021
@gustawlippa gustawlippa deleted the mod-offline-optional-callback-fix branch October 27, 2021 09:17
@Premwoik Premwoik modified the milestone: 5.1.0 May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants