Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dynamically compiled modules from mod_http_upload #3372

Conversation

JanuszJakubiec
Copy link
Contributor

Remove dynamically compiled modules from mod_http_upload

@codecov
Copy link

codecov bot commented Oct 27, 2021

Codecov Report

Merging #3372 (047d066) into without-dynamic-backend-modules (14f8f2f) will increase coverage by 0.01%.
The diff coverage is 94.11%.

Impacted file tree graph

@@                         Coverage Diff                         @@
##           without-dynamic-backend-modules    #3372      +/-   ##
===================================================================
+ Coverage                            80.87%   80.88%   +0.01%     
===================================================================
  Files                                  410      412       +2     
  Lines                                32666    32678      +12     
===================================================================
+ Hits                                 26417    26433      +16     
+ Misses                                6249     6245       -4     
Impacted Files Coverage Δ
src/http_upload/mod_http_upload_s3.erl 100.00% <ø> (ø)
src/pubsub/mod_pubsub_cache_mnesia.erl 73.68% <ø> (ø)
src/pubsub/mod_pubsub_cache_rdbms.erl 91.17% <ø> (ø)
src/pubsub/mod_pubsub_cache_backend.erl 90.90% <90.90%> (ø)
src/http_upload/mod_http_upload.erl 94.62% <100.00%> (ø)
src/http_upload/mod_http_upload_backend.erl 100.00% <100.00%> (ø)
src/pubsub/mod_pubsub.erl 73.13% <100.00%> (-0.10%) ⬇️
src/mod_roster_riak.erl 81.53% <0.00%> (-15.39%) ⬇️
src/metrics/mongoose_metrics.erl 95.45% <0.00%> (-0.65%) ⬇️
src/inbox/mod_inbox_rdbms.erl 92.50% <0.00%> (-0.63%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d106506...047d066. Read the comment docs.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Oct 27, 2021

small_tests_24 / small_tests / ece5632
Reports root / small


internal_mnesia_24 / internal_mnesia / ece5632
Reports root/ big
OK: 1589 / Failed: 0 / User-skipped: 297 / Auto-skipped: 0


small_tests_23 / small_tests / ece5632
Reports root / small


ldap_mnesia_24 / ldap_mnesia / ece5632
Reports root/ big
OK: 1486 / Failed: 0 / User-skipped: 400 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / ece5632
Reports root/ big
OK: 2702 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / ece5632
Reports root/ big
OK: 2702 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


ldap_mnesia_23 / ldap_mnesia / ece5632
Reports root/ big
OK: 1486 / Failed: 0 / User-skipped: 400 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / ece5632
Reports root/ big
OK: 3071 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / ece5632
Reports root/ big
OK: 2702 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


dynamic_domains_mysql_redis_24 / mysql_redis / ece5632
Reports root/ big
OK: 2691 / Failed: 1 / User-skipped: 201 / Auto-skipped: 0

mam_SUITE:rdbms_prefs_cases:prefs_set_cdata_request
{error,{test_case_failed,"ASSERT EQUAL\n\tExpected {prefs_result_iq,<<\"roster\">>,\n                  [<<\"montague@montague.net\">>,\n                   <<\"romeo@montague.net\">>],\n                  []}\n\tValue {prefs_result_iq,<<\"always\">>,\n                 [<<\"montague@montague.net\">>,\n                <<\"romeo@montague.net\">>],\n                 []}\n"}}

Report log


elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / ece5632
Reports root/ big
OK: 1862 / Failed: 0 / User-skipped: 323 / Auto-skipped: 0


mssql_mnesia_24 / odbc_mssql_mnesia / ece5632
Reports root/ big
OK: 3071 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0


pgsql_mnesia_23 / pgsql_mnesia / ece5632
Reports root/ big
OK: 3071 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0


mysql_redis_24 / mysql_redis / ece5632
Reports root/ big
OK: 3054 / Failed: 0 / User-skipped: 228 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / ece5632
Reports root/ big
OK: 1709 / Failed: 0 / User-skipped: 326 / Auto-skipped: 0

@mongoose-im
Copy link
Collaborator

mongoose-im commented Oct 28, 2021

small_tests_24 / small_tests / 047d066
Reports root / small


internal_mnesia_24 / internal_mnesia / 047d066
Reports root/ big
OK: 1589 / Failed: 0 / User-skipped: 297 / Auto-skipped: 0


small_tests_23 / small_tests / 047d066
Reports root / small


ldap_mnesia_24 / ldap_mnesia / 047d066
Reports root/ big
OK: 1486 / Failed: 0 / User-skipped: 400 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 047d066
Reports root/ big
OK: 2702 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 047d066
Reports root/ big
OK: 2702 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


dynamic_domains_mysql_redis_24 / mysql_redis / 047d066
Reports root/ big
OK: 2685 / Failed: 0 / User-skipped: 201 / Auto-skipped: 0


ldap_mnesia_23 / ldap_mnesia / 047d066
Reports root/ big
OK: 1486 / Failed: 0 / User-skipped: 400 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 047d066
Reports root/ big
OK: 2702 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 047d066
Reports root/ big
OK: 1862 / Failed: 0 / User-skipped: 323 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 047d066
Reports root/ big
OK: 3071 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0


mysql_redis_24 / mysql_redis / 047d066
Reports root/ big
OK: 3082 / Failed: 2 / User-skipped: 228 / Auto-skipped: 0

mod_event_pusher_rabbit_SUITE:group_chat_message_publish:group_chat_message_received_event_properly_formatted
{error,
  {{assertMatch,
     [{module,mod_event_pusher_rabbit_SUITE},
      {line,435},
      {expression,
        "get_decoded_message_from_rabbit ( AliceGroupChatMsgRecvRK )"},
      {pattern,
        "# { << \"from_user_id\" >> := BobRoomJID , << \"to_user_id\" >> := AliceFullJID , << \"message\" >> := Message }"},
      {value,
        #{<<"from_user_id">> =>
          <<"muc_publish@muc.localhost/bOb_unnamed_36.161083">>,
        <<"message">> => <<"Hi there!">>,
        <<"to_user_id">> =>
          <<"alice_unnamed_36.314458@localhost/res1">>}}]},
   [{mod_event_pusher_rabbit_SUITE,
      '-group_chat_message_received_event_properly_formatted/1-fun-1-',3,
      [{file,
         "/home/circleci/app/big_tests/tests/mod_event_pusher_rabbit_SUITE.erl"},
       {line,435}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1292}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1224}]}]}}

Report log

rest_client_SUITE:muc:messages_can_be_paginated_in_room
{error,
  {{assertion_failed,assert,is_chat_message,
     [<<"cb633175">>],
     {xmlel,<<"message">>,
       [{<<"to">>,<<"1635-403042-526758@muclight.localhost">>},
        {<<"type">>,<<"chat">>}],
       [{xmlel,<<"body">>,[],[{xmlcdata,<<"02ad410a">>}]}]},
     "<message to='1635-403042-526758@muclight.localhost' type='chat'><body>02ad410a</body></message>"},
   [{escalus_new_assert,assert_true,2,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
       {line,84}]},
    {rest_client_SUITE,assert_room_messages,2,
      [{file,"/home/circleci/app/big_tests/tests/rest_client_SUITE.erl"},
       {line,772}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1292}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1224}]}]}}

Report log


pgsql_mnesia_23 / pgsql_mnesia / 047d066
Reports root/ big
OK: 3071 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0


mssql_mnesia_24 / odbc_mssql_mnesia / 047d066
Reports root/ big
OK: 3070 / Failed: 1 / User-skipped: 211 / Auto-skipped: 0

inbox_SUITE:muclight:non_reset_marker_should_not_affect_muclight_inbox
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"alicE_non_reset_marker_should_not_affect_muclight_inbox_30.462770@localhost/res1">>,
          escalus_tcp,<0.17442.0>,
          [{event_manager,<0.17421.0>},
           {server,<<"localhost">>},
           {username,
             <<"alicE_non_reset_marker_should_not_affect_muclight_inbox_30.462770">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.17421.0>},
            {server,<<"localhost">>},
            {username,
              <<"alicE_non_reset_marker_should_not_affect_muclight_inbox_30.462770">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"alicE_non_reset_marker_should_not_affect_muclight_inbox_30.462770">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,
             <<"alicE_non_reset_marker_should_not_affect_muclight_inbox_30.462770">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"1452315e561960f7">>}]},
        5000],
       [{file,
          "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {inbox_helper,mark_last_muclight_system_message,3,
       [{file,"/home/circleci/app/big_test...

Report log


riak_mnesia_24 / riak_mnesia / 047d066
Reports root/ big
OK: 1709 / Failed: 0 / User-skipped: 326 / Auto-skipped: 0


mssql_mnesia_24 / odbc_mssql_mnesia / 047d066
Reports root/ big
OK: 3071 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0

Copy link
Contributor

@gustawlippa gustawlippa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@vkatsuba vkatsuba merged commit a14a4a5 into without-dynamic-backend-modules Oct 28, 2021
@vkatsuba vkatsuba deleted the mod-http-upload-remove-dynamic-modules branch October 28, 2021 08:00
@Premwoik Premwoik modified the milestone: 5.1.0 May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants