Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use persistent terms to store backend_module in ejabberd_sm #3379

Merged

Conversation

arcusfelis
Copy link
Contributor

Proposed changes include:

  • Also fix acl:match_rule call to use hosttypes
  • Because we support only one global backend, we don't need to pass HostTypes (that could be done later, if needed, but would have to have tests and rewriting API a bit)

@mongoose-im

This comment has been minimized.

src/ejabberd_sm.erl Outdated Show resolved Hide resolved
@NelsonVides
Copy link
Collaborator

This looks great, but there are conflicts in the rebar.config 😛

@mongoose-im
Copy link
Collaborator

mongoose-im commented Oct 29, 2021

small_tests_24 / small_tests / 7d577a2
Reports root / small


internal_mnesia_24 / internal_mnesia / 7d577a2
Reports root/ big
OK: 1589 / Failed: 0 / User-skipped: 297 / Auto-skipped: 0


small_tests_23 / small_tests / 7d577a2
Reports root / small


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 7d577a2
Reports root/ big
OK: 2702 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


dynamic_domains_mysql_redis_24 / mysql_redis / 7d577a2
Reports root/ big
OK: 2684 / Failed: 1 / User-skipped: 201 / Auto-skipped: 0

service_domain_db_SUITE:db:db_keeps_syncing_after_cluster_join
{error,{test_case_failed,{[<<"example1.com">>],
              [<<"example1.com">>,<<"example2.com">>]}}}

Report log


ldap_mnesia_24 / ldap_mnesia / 7d577a2
Reports root/ big
OK: 1486 / Failed: 0 / User-skipped: 400 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 7d577a2
Reports root/ big
OK: 2701 / Failed: 1 / User-skipped: 184 / Auto-skipped: 0

domain_removal_SUITE:last_removal:last_removal
{error,{{assertion_failed,assert,is_last_result,
              {xmlel,<<"presence">>,
                 [{<<"from">>,
                   <<"alicE_last_removal_14.438283@domain.example.com/friendly">>},
                  {<<"to">>,
                   <<"alice_last_removal_14.438283@domain.example.com/res1">>},
                  {<<"type">>,<<"unavailable">>}],
                 []},
              "<presence from='alicE_last_removal_14.438283@domain.example.com/friendly' to='alice_last_removal_14.438283@domain.example.com/res1' type='unavailable'/>"},
    [{escalus_new_assert,assert_true,2,
               [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
                {line,84}]},
     {domain_removal_SUITE,'-last_removal/1-fun-0-',2,
                 [{file,"/home/circleci/app/big_tests/tests/domain_removal_SUITE.erl"},
                {line,379}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1784}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1293}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1225}]}]}}

Report log


ldap_mnesia_23 / ldap_mnesia / 7d577a2
Reports root/ big
OK: 1486 / Failed: 0 / User-skipped: 400 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 7d577a2
Reports root/ big
OK: 2701 / Failed: 1 / User-skipped: 184 / Auto-skipped: 0

inbox_SUITE:muclight:non_reset_marker_should_not_affect_muclight_inbox
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"alicE_non_reset_marker_should_not_affect_muclight_inbox_50.664076@domain.example.com/res1">>,
          escalus_tcp,<0.16591.0>,
          [{event_manager,<0.16586.0>},
           {server,<<"domain.example.com">>},
           {username,
             <<"alicE_non_reset_marker_should_not_affect_muclight_inbox_50.664076">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.16586.0>},
            {server,<<"domain.example.com">>},
            {username,
              <<"alicE_non_reset_marker_should_not_affect_muclight_inbox_50.664076">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"alicE_non_reset_marker_should_not_affect_muclight_inbox_50.664076">>},
           {server,<<"domain.example.com">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,
             <<"alicE_non_reset_marker_should_not_affect_muclight_inbox_50.664076">>},
           {server,<<"domain.example.com">>},
           {host,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"d7357c08a665f13f">>}]},
        5000],
       [{file,
          "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {inbox_helper...

Report log


elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 7d577a2
Reports root/ big
OK: 1862 / Failed: 0 / User-skipped: 323 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 7d577a2
Reports root/ big
OK: 3071 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0


mysql_redis_24 / mysql_redis / 7d577a2
Reports root/ big
OK: 3054 / Failed: 0 / User-skipped: 228 / Auto-skipped: 0


mssql_mnesia_24 / odbc_mssql_mnesia / 7d577a2
Reports root/ big
OK: 3071 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0


pgsql_mnesia_23 / pgsql_mnesia / 7d577a2
Reports root/ big
OK: 3071 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / 7d577a2
Reports root/ big
OK: 1709 / Failed: 0 / User-skipped: 326 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Oct 29, 2021

Codecov Report

Merging #3379 (c159446) into without-dynamic-backend-modules (047d066) will increase coverage by 0.03%.
The diff coverage is 89.93%.

Impacted file tree graph

@@                         Coverage Diff                         @@
##           without-dynamic-backend-modules    #3379      +/-   ##
===================================================================
+ Coverage                            80.88%   80.92%   +0.03%     
===================================================================
  Files                                  412      412              
  Lines                                32678    32613      -65     
===================================================================
- Hits                                 26433    26391      -42     
+ Misses                                6245     6222      -23     
Impacted Files Coverage Δ
src/mam/mod_mam_meta.erl 94.73% <ø> (ø)
src/mam/mod_mam_cassandra_prefs.erl 90.76% <83.33%> (+10.15%) ⬆️
src/mam/mod_mam_muc_cassandra_arch.erl 84.54% <88.33%> (-0.52%) ⬇️
src/mam/mod_mam_cassandra_arch.erl 84.61% <90.90%> (-0.07%) ⬇️
src/ejabberd_sm.erl 84.88% <100.00%> (+0.14%) ⬆️
src/mam/mod_mam_rdbms_async_pool_writer.erl 66.66% <0.00%> (-3.93%) ⬇️
src/domain/mongoose_domain_loader.erl 77.35% <0.00%> (-1.89%) ⬇️
...c/global_distrib/mod_global_distrib_server_mgr.erl 76.83% <0.00%> (-0.57%) ⬇️
src/ejabberd_c2s.erl 89.22% <0.00%> (-0.08%) ⬇️
src/mod_muc_log.erl 77.88% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a14a4a5...c159446. Read the comment docs.

@arcusfelis arcusfelis force-pushed the mu-without-dynamic-modules-in-sm branch from 7d577a2 to cf91f1a Compare October 29, 2021 11:10
Copy link
Collaborator

@NelsonVides NelsonVides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mongoose-im
Copy link
Collaborator

mongoose-im commented Oct 29, 2021

small_tests_24 / small_tests / cf91f1a
Reports root / small


internal_mnesia_24 / internal_mnesia / cf91f1a
Reports root/ big
OK: 1589 / Failed: 0 / User-skipped: 297 / Auto-skipped: 0


small_tests_23 / small_tests / cf91f1a
Reports root / small


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / cf91f1a
Reports root/ big
OK: 2702 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / cf91f1a
Reports root/ big
OK: 2700 / Failed: 2 / User-skipped: 184 / Auto-skipped: 0

inbox_SUITE:muclight:groupchat_markers_all_reset_room_created
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"alicE_groupchat_markers_all_reset_room_created_75.205244@domain.example.com/res1">>,
          escalus_tcp,<0.16558.0>,
          [{event_manager,<0.16531.0>},
           {server,<<"domain.example.com">>},
           {username,
             <<"alicE_groupchat_markers_all_reset_room_created_75.205244">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.16531.0>},
            {server,<<"domain.example.com">>},
            {username,
              <<"alicE_groupchat_markers_all_reset_room_created_75.205244">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"alicE_groupchat_markers_all_reset_room_created_75.205244">>},
           {server,<<"domain.example.com">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,
             <<"alicE_groupchat_markers_all_reset_room_created_75.205244">>},
           {server,<<"domain.example.com">>},
           {host,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"7a1be23d4f02bcbc">>}]},
        5000],
       [{file,
          "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {muc_helper,'-foreach_recipient/2-fun-0-',2,
       [{file...

Report log

inbox_SUITE:muclight:groupchat_markers_one_reset_room_created
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"alicE_groupchat_markers_one_reset_room_created_75.213364@domain.example.com/res1">>,
          escalus_tcp,<0.16559.0>,
          [{event_manager,<0.16550.0>},
           {server,<<"domain.example.com">>},
           {username,
             <<"alicE_groupchat_markers_one_reset_room_created_75.213364">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.16550.0>},
            {server,<<"domain.example.com">>},
            {username,
              <<"alicE_groupchat_markers_one_reset_room_created_75.213364">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"alicE_groupchat_markers_one_reset_room_created_75.213364">>},
           {server,<<"domain.example.com">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,
             <<"alicE_groupchat_markers_one_reset_room_created_75.213364">>},
           {server,<<"domain.example.com">>},
           {host,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"5235e2bdb0a4a2ad">>}]},
        5000],
       [{file,
          "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {muc_helper,'-foreach_recipient/2-fun-0-',2,
       [{file...

Report log

inbox_SUITE:muclight:end_per_group
{error,
  {{badrpc,
     {'EXIT',
       {timeout,
         {gen_server,call,
           ['wpool_pool-mongoose_wpool$rdbms$global$default-4',
            {sql_cmd,
              {sql_execute,muc_light_config_delete_all,[]},
              -576460471119},
            60000]}}}},
   [{distributed_helper,rpc,
      [#{node => mongooseim@localhost,timeout => 15000},
       mod_muc_light,force_clear_from_ct,
       [<<"test type">>]],
      [{file,"/home/circleci/app/big_tests/tests/distributed_helper.erl"},
       {line,117}]},
    {inbox_SUITE,end_per_group,2,
      [{file,"/home/circleci/app/big_tests/tests/inbox_SUITE.erl"},
       {line,241}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1380}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1224}]}]}}

Report log


ldap_mnesia_24 / ldap_mnesia / cf91f1a
Reports root/ big
OK: 1486 / Failed: 0 / User-skipped: 400 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / cf91f1a
Reports root/ big
OK: 2702 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


dynamic_domains_mysql_redis_24 / mysql_redis / cf91f1a
Reports root/ big
OK: 2685 / Failed: 0 / User-skipped: 201 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / cf91f1a
Reports root/ big
OK: 3071 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0


pgsql_mnesia_23 / pgsql_mnesia / cf91f1a
Reports root/ big
OK: 3071 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0


elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / cf91f1a
Reports root/ big
OK: 1862 / Failed: 0 / User-skipped: 323 / Auto-skipped: 0


mssql_mnesia_24 / odbc_mssql_mnesia / cf91f1a
Reports root/ big
OK: 3071 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / cf91f1a
Reports root/ big
OK: 1709 / Failed: 0 / User-skipped: 326 / Auto-skipped: 0


mysql_redis_24 / mysql_redis / cf91f1a
Reports root/ big
OK: 3053 / Failed: 36 / User-skipped: 224 / Auto-skipped: 129

mod_ping_SUITE:server_ping_kill:server_ping_pang
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,<<"alicE_server_ping_pang_18.790788@localhost/res1">>,
          escalus_tcp,<0.13936.1>,
          [{event_manager,<0.13935.1>},
           {server,<<"localhost">>},
           {username,<<"alicE_server_ping_pang_18.790788">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.13935.1>},
            {server,<<"localhost">>},
            {username,<<"alicE_server_ping_pang_18.790788">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"alicE_server_ping_pang_18.790788">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,<<"alicE_server_ping_pang_18.790788">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"d97f95c7a318c672">>}]},
        10000],
       [{file,
          "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {mod_ping_SUITE,wait_for_ping_req,1,
       [{file,"/home/circleci/app/big_tests/tests/mod_ping_SUITE.erl"},
        {line,267}]},
     {mod_ping_SUITE,'-server_ping_pang/1-fun-0-',2,
       [{file,"/home/circleci/app/big_tests/tests/mod_ping_SUITE.erl"},
        {line,249}]},
     {escalus_story,story,4,
       [{file,
   ...

Report log

mod_ping_SUITE:server_ping_kill:server_ping_pang
{error,{{badmatch,true},
    [{mod_ping_SUITE,check_connection,2,
             [{file,"/home/circleci/app/big_tests/tests/mod_ping_SUITE.erl"},
              {line,262}]},
     {mod_ping_SUITE,'-server_ping_pang/1-fun-0-',2,
             [{file,"/home/circleci/app/big_tests/tests/mod_ping_SUITE.erl"},
              {line,253}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1292}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1224}]}]}}

Report log

mod_ping_SUITE:server_ping_kill:server_ping_pang
{error,{{badmatch,true},
    [{mod_ping_SUITE,check_connection,2,
             [{file,"/home/circleci/app/big_tests/tests/mod_ping_SUITE.erl"},
              {line,262}]},
     {mod_ping_SUITE,'-server_ping_pang/1-fun-0-',2,
             [{file,"/home/circleci/app/big_tests/tests/mod_ping_SUITE.erl"},
              {line,253}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1292}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1224}]}]}}

Report log

pubsub_SUITE:dag+basic:subscribe_unsubscribe_test
{error,{thrown,{timeout,stream_end}}}

Report log

pubsub_SUITE:dag+basic:publish_with_existing_id_test
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"alicE_publish_with_existing_id_test_20.698599@localhost/res1">>,
          escalus_tcp,<0.25625.1>,
          [{event_manager,<0.25624.1>},
           {server,<<"localhost">>},
           {username,
             <<"alicE_publish_with_existing_id_test_20.698599">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.25624.1>},
            {server,<<"localhost">>},
            {username,
              <<"alicE_publish_with_existing_id_test_20.698599">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"alicE_publish_with_existing_id_test_20.698599">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,
             <<"alicE_publish_with_existing_id_test_20.698599">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"5d126769d0617a61">>}]},
        5000],
       [{file,
          "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {pubsub_tools,receive_response,3,
       [{file,"/home/circleci/app/big_tests/tests/pubsub_tools.erl"},
        {line,479}]},
     {pubsub_tools,receive_and_check_response,4,
       [{file,"/ho...

Report log

pubsub_SUITE:dag+basic:subscribe_unsubscribe_test
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"bOb_subscribe_unsubscribe_test_27.275153@localhost/res1">>,
          escalus_tcp,<0.25732.1>,
          [{event_manager,<0.25730.1>},
           {server,<<"localhost">>},
           {username,<<"bOb_subscribe_unsubscribe_test_27.275153">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.25730.1>},
            {server,<<"localhost">>},
            {username,
              <<"bOb_subscribe_unsubscribe_test_27.275153">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"bOb_subscribe_unsubscribe_test_27.275153">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,<<"bOb_subscribe_unsubscribe_test_27.275153">>},
           {server,<<"localhost">>},
           {password,<<"makrolika">>},
           {stream_id,<<"5013aa7c7cec980a">>}]},
        5000],
       [{file,
          "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {pubsub_tools,receive_response,3,
       [{file,"/home/circleci/app/big_tests/tests/pubsub_tools.erl"},
        {line,479}]},
     {pubsub_tools,receive_and_check_response,4,
       [{file,"/home/circleci/app/big_tests/tests/pubsub_tools.erl"},
        {line,4...

Report log

pubsub_SUITE:dag+node_affiliations:add_publisher_and_member_test
{error,{thrown,{timeout,stream_end}}}

Report log

pubsub_SUITE:dag+manage_subscriptions:process_subscription_requests_test
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"alicE_process_subscription_requests_test_42.740125@localhost/res1">>,
          escalus_tcp,<0.26168.1>,
          [{event_manager,<0.26152.1>},
           {server,<<"localhost">>},
           {username,
             <<"alicE_process_subscription_requests_test_42.740125">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.26152.1>},
            {server,<<"localhost">>},
            {username,
              <<"alicE_process_subscription_requests_test_42.740125">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"alicE_process_subscription_requests_test_42.740125">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,
             <<"alicE_process_subscription_requests_test_42.740125">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"d223d3f7eea15907">>}]},
        5000],
       [{file,
          "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {pubsub_tools,receive_response,3,
       [{file,"/home/circleci/app/big_tests/tests/pubsub_tools.erl"},
        {line,479}]},
     {pubsub_tools,receive_and_check_respo...

Report log

pubsub_SUITE:dag+manage_subscriptions:process_subscription_requests_test
{error,{thrown,{timeout,stream_end}}}

Report log

pubsub_SUITE:dag+manage_subscriptions:modify_node_subscriptions_test
{error,{thrown,{timeout,stream_end}}}

Report log

pubsub_SUITE:dag+manage_subscriptions:modify_node_subscriptions_test
{error,{thrown,{timeout,stream_end}}}

Report log

pubsub_SUITE:dag+manage_subscriptions:process_subscription_requests_test
{error,{thrown,{timeout,stream_end}}}

Report log

pubsub_SUITE:dag+collection:notify_collection_test
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"alicE_notify_collection_test_64.761069@localhost/res1">>,
          escalus_tcp,<0.26508.1>,
          [{event_manager,<0.26507.1>},
           {server,<<"localhost">>},
           {username,<<"alicE_notify_collection_test_64.761069">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.26507.1>},
            {server,<<"localhost">>},
            {username,
              <<"alicE_notify_collection_test_64.761069">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"alicE_notify_collection_test_64.761069">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,<<"alicE_notify_collection_test_64.761069">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"b35af6fd3f9e2a9d">>}]},
        5000],
       [{file,
          "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {pubsub_tools,receive_response,3,
       [{file,"/home/circleci/app/big_tests/tests/pubsub_tools.erl"},
        {line,479}]},
     {pubsub_tools,receive_and_check_response,4,
       [{file,"/home/circleci/app/big_tests/tests/pubsub_tools.erl"},
        {line,470}]},
   ...

Report log

pubsub_SUITE:dag+collection:notify_collection_and_leaf_test
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"alicE_notify_collection_and_leaf_test_81.147817@localhost/res1">>,
          escalus_tcp,<0.26640.1>,
          [{event_manager,<0.26639.1>},
           {server,<<"localhost">>},
           {username,
             <<"alicE_notify_collection_and_leaf_test_81.147817">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.26639.1>},
            {server,<<"localhost">>},
            {username,
              <<"alicE_notify_collection_and_leaf_test_81.147817">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"alicE_notify_collection_and_leaf_test_81.147817">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,
             <<"alicE_notify_collection_and_leaf_test_81.147817">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"e905243d982f46c8">>}]},
        5000],
       [{file,
          "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {pubsub_tools,receive_response,3,
       [{file,"/home/circleci/app/big_tests/tests/pubsub_tools.erl"},
        {line,479}]},
     {pubsub_tools,receive_and_check_response,4,
       [...

Report log

pubsub_SUITE:dag+collection:notify_collection_test
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"alicE_notify_collection_test_87.914831@localhost/res1">>,
          escalus_tcp,<0.26719.1>,
          [{event_manager,<0.26718.1>},
           {server,<<"localhost">>},
           {username,<<"alicE_notify_collection_test_87.914831">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.26718.1>},
            {server,<<"localhost">>},
            {username,
              <<"alicE_notify_collection_test_87.914831">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"alicE_notify_collection_test_87.914831">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,<<"alicE_notify_collection_test_87.914831">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"d10575ab377ef2d5">>}]},
        5000],
       [{file,
          "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {pubsub_tools,receive_response,3,
       [{file,"/home/circleci/app/big_tests/tests/pubsub_tools.erl"},
        {line,479}]},
     {pubsub_tools,receive_and_check_response,4,
       [{file,"/home/circleci/app/big_tests/tests/pubsub_tools.erl"},
        {line,470}]},
   ...

Report log

pubsub_SUITE:dag+last_item_cache:send_last_published_item_test
{error,{thrown,{timeout,stream_end}}}

Report log

pubsub_SUITE:dag+last_item_cache:purge_all_items_test
{error,{thrown,{timeout,stream_end}}}

Report log

pubsub_SUITE:tree+basic:subscribe_unsubscribe_test
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"bOb_subscribe_unsubscribe_test_3.752440@localhost/res1">>,
          escalus_tcp,<0.27113.1>,
          [{event_manager,<0.27111.1>},
           {server,<<"localhost">>},
           {username,<<"bOb_subscribe_unsubscribe_test_3.752440">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.27111.1>},
            {server,<<"localhost">>},
            {username,
              <<"bOb_subscribe_unsubscribe_test_3.752440">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"bOb_subscribe_unsubscribe_test_3.752440">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,<<"bOb_subscribe_unsubscribe_test_3.752440">>},
           {server,<<"localhost">>},
           {password,<<"makrolika">>},
           {stream_id,<<"841bcaeb4563d4d9">>}]},
        5000],
       [{file,
          "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {pubsub_tools,receive_response,3,
       [{file,"/home/circleci/app/big_tests/tests/pubsub_tools.erl"},
        {line,479}]},
     {pubsub_tools,receive_and_check_response,4,
       [{file,"/home/circleci/app/big_tests/tests/pubsub_tools.erl"},
        {line,470}]}...

Report log

pubsub_SUITE:tree+basic:subscribe_unsubscribe_test
{error,{thrown,{timeout,stream_end}}}

Report log

pubsub_SUITE:tree+basic:discover_nodes_test
{error,{thrown,{timeout,stream_end}}}

Report log

pubsub_SUITE:tree+manage_subscriptions:retrieve_pending_subscription_requests_test
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"alicE_retrieve_pending_subscription_requests_test_25.876984@localhost/res1">>,
          escalus_tcp,<0.27646.1>,
          [{event_manager,<0.27636.1>},
           {server,<<"localhost">>},
           {username,
             <<"alicE_retrieve_pending_subscription_requests_test_25.876984">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.27636.1>},
            {server,<<"localhost">>},
            {username,
              <<"alicE_retrieve_pending_subscription_requests_test_25.876984">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"alicE_retrieve_pending_subscription_requests_test_25.876984">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,
             <<"alicE_retrieve_pending_subscription_requests_test_25.876984">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"db48b58a743c38eb">>}]},
        5000],
       [{file,
          "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {pubsub_tools,receive_response,3,
       [{file,"/home/circleci/app/big_tests/tests/pubsub_tools.erl"},
        {line,479}]...

Report log

pubsub_SUITE:tree+manage_subscriptions:modify_node_subscriptions_test
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"alicE_modify_node_subscriptions_test_25.878055@localhost/res1">>,
          escalus_tcp,<0.27645.1>,
          [{event_manager,<0.27641.1>},
           {server,<<"localhost">>},
           {username,
             <<"alicE_modify_node_subscriptions_test_25.878055">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.27641.1>},
            {server,<<"localhost">>},
            {username,
              <<"alicE_modify_node_subscriptions_test_25.878055">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"alicE_modify_node_subscriptions_test_25.878055">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,
             <<"alicE_modify_node_subscriptions_test_25.878055">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"a4aca87c049ea886">>}]},
        5000],
       [{file,
          "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {pubsub_tools,receive_response,3,
       [{file,"/home/circleci/app/big_tests/tests/pubsub_tools.erl"},
        {line,479}]},
     {pubsub_tools,receive_and_check_response,4,
       [{file...

Report log

pubsub_SUITE:tree+manage_subscriptions:process_subscription_requests_test
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"alicE_process_subscription_requests_test_25.878936@localhost/res1">>,
          escalus_tcp,<0.27644.1>,
          [{event_manager,<0.27621.1>},
           {server,<<"localhost">>},
           {username,
             <<"alicE_process_subscription_requests_test_25.878936">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.27621.1>},
            {server,<<"localhost">>},
            {username,
              <<"alicE_process_subscription_requests_test_25.878936">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"alicE_process_subscription_requests_test_25.878936">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,
             <<"alicE_process_subscription_requests_test_25.878936">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"5e79d4611665ef3a">>}]},
        5000],
       [{file,
          "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {pubsub_tools,receive_response,3,
       [{file,"/home/circleci/app/big_tests/tests/pubsub_tools.erl"},
        {line,479}]},
     {pubsub_tools,receive_and_check_respo...

Report log

pubsub_SUITE:tree+hometree_specific:deleting_parent_path_deletes_children
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"alicE_deleting_parent_path_deletes_children_39.764428@localhost/res1">>,
          escalus_tcp,<0.27957.1>,
          [{event_manager,<0.27956.1>},
           {server,<<"localhost">>},
           {username,
             <<"alicE_deleting_parent_path_deletes_children_39.764428">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.27956.1>},
            {server,<<"localhost">>},
            {username,
              <<"alicE_deleting_parent_path_deletes_children_39.764428">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"alicE_deleting_parent_path_deletes_children_39.764428">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,
             <<"alicE_deleting_parent_path_deletes_children_39.764428">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"ceac2ac0237b8808">>}]},
        5000],
       [{file,
          "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {pubsub_tools,receive_error_response,4,
       [{file,"/home/circleci/app/big_tests/tests/pubsub_tools.erl"},
        {line,495}]},
     {escalus_story,s...

Report log

pubsub_SUITE:tree+hometree_specific:can_create_node_with_existing_parent_path
{error,{thrown,{timeout,stream_end}}}

Report log

11 errors were truncated


small_tests_24 / small_tests / cf91f1a
Reports root / small


small_tests_23 / small_tests / cf91f1a
Reports root / small


dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / cf91f1a
Reports root/ big
OK: 2702 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


mysql_redis_24 / mysql_redis / cf91f1a
Reports root/ big
OK: 3054 / Failed: 0 / User-skipped: 228 / Auto-skipped: 0

@mongoose-im
Copy link
Collaborator

mongoose-im commented Oct 29, 2021

small_tests_24 / small_tests / c159446
Reports root / small


internal_mnesia_24 / internal_mnesia / c159446
Reports root/ big
OK: 1589 / Failed: 0 / User-skipped: 297 / Auto-skipped: 0


small_tests_23 / small_tests / c159446
Reports root / small


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / c159446
Reports root/ big
OK: 2702 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


ldap_mnesia_24 / ldap_mnesia / c159446
Reports root/ big
OK: 1486 / Failed: 0 / User-skipped: 400 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / c159446
Reports root/ big
OK: 2702 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


dynamic_domains_mysql_redis_24 / mysql_redis / c159446
Reports root/ big
OK: 2697 / Failed: 2 / User-skipped: 201 / Auto-skipped: 0

mam_SUITE:rdbms_async_pool_prefs_cases:messages_filtered_when_prefs_default_policy_is_roster
{error,{test_case_failed,"ASSERT EQUAL\n\tExpected []\n\tValue [ok,ok]\n"}}

Report log

mam_SUITE:rdbms_async_pool_prefs_cases:messages_filtered_when_prefs_default_policy_is_roster
{error,{test_case_failed,"ASSERT EQUAL\n\tExpected []\n\tValue [ok]\n"}}

Report log


dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / c159446
Reports root/ big
OK: 2701 / Failed: 1 / User-skipped: 184 / Auto-skipped: 0

inbox_SUITE:one_to_one:other_resources_do_not_interfere
{error,
  {test_case_failed,
    #{check_params => #{},
      error => {badmatch,1},
      expected_items =>
        [#{content => <<"How are you">>,
         from =>
           <<"kate_other_resources_do_not_interfere_31.799416@domain.example.com/res1">>,
         to =>
           <<"mike_other_resources_do_not_interfere_31.799416@domain.example.com/res1">>,
         unread => 2,verify => #Fun<inbox_SUITE.117.11357666>}],
      inbox_items =>
        [<<"<message from='mike_other_resources_do_not_interfere_31.799416@domain.example.com' to='mike_other_resources_do_not_interfere_31.799416@domain.example.com/res1' id='0940905d-4303-4cc7-94f8-519eb774a968'><result xmlns='erlang-solutions.com:xmpp:inbox:0' unread='1' queryid='4a9c4db5f0d489751f2a9f1f00b6865b'><forwarded xmlns='urn:xmpp:forward:0'><delay xmlns='urn:xmpp:delay' stamp='2021-10-29T14:37:12.543805Z'/><message from='kate_other_resources_do_not_interfere_31.799416@domain.example.com/res1' xml:lang='en' to='mike_other_resources_do_not_interfere_31.799416@domain.example.com/res1' type='chat' id='f0142ccc738ddcdb71f28f3e4a08a8c3'><body>Hello</body></message></forwarded><archive>false</archive><mute>0</mute></result></message>">>],
      query_params => #{},reason => inbox_mismatch,
      stacktrace =>
        [{inbox_helper,process_inbox_message,4,
           [{file,
            "/home/circleci/app/big_tests/tests/inbox_helper.erl"},
          {line,194}]},
         {lists,foreach,2,[{file,"lists.erl"},{line,1342}]},
     ...

Report log


ldap_mnesia_23 / ldap_mnesia / c159446
Reports root/ big
OK: 1486 / Failed: 0 / User-skipped: 400 / Auto-skipped: 0


elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / c159446
Reports root/ big
OK: 1862 / Failed: 0 / User-skipped: 323 / Auto-skipped: 0


mssql_mnesia_24 / odbc_mssql_mnesia / c159446
Reports root/ big
OK: 3070 / Failed: 1 / User-skipped: 211 / Auto-skipped: 0

inbox_SUITE:one_to_one:user_has_two_conversations
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"alicE_user_has_two_conversations_76.984346@localhost/res1">>,
          escalus_tcp,<0.17237.0>,
          [{event_manager,<0.17137.0>},
           {server,<<"localhost">>},
           {username,<<"alicE_user_has_two_conversations_76.984346">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.17137.0>},
            {server,<<"localhost">>},
            {username,
              <<"alicE_user_has_two_conversations_76.984346">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"alicE_user_has_two_conversations_76.984346">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,<<"alicE_user_has_two_conversations_76.984346">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"64742ddb2c8c9da7">>}]},
        5000],
       [{file,
          "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {inbox_helper,get_inbox,3,
       [{file,"/home/circleci/app/big_tests/tests/inbox_helper.erl"},
        {line,221}]},
     {inbox_helper,check_inbox,4,
       [{file,"/home/circleci/app/big_tests/tests/inbox_helper.erl"},
        {line,167}]},
     ...

Report log


pgsql_mnesia_24 / pgsql_mnesia / c159446
Reports root/ big
OK: 3071 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0


pgsql_mnesia_23 / pgsql_mnesia / c159446
Reports root/ big
OK: 3071 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0


mysql_redis_24 / mysql_redis / c159446
Reports root/ big
OK: 3054 / Failed: 0 / User-skipped: 228 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / c159446
Reports root/ big
OK: 1709 / Failed: 0 / User-skipped: 326 / Auto-skipped: 0


dynamic_domains_mysql_redis_24 / mysql_redis / c159446
Reports root/ big
OK: 2691 / Failed: 1 / User-skipped: 201 / Auto-skipped: 0

mam_SUITE:rdbms_async_pool_prefs_cases:messages_filtered_when_prefs_default_policy_is_roster
{error,{test_case_failed,"ASSERT EQUAL\n\tExpected []\n\tValue [ok,ok]\n"}}

Report log


dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / c159446
Reports root/ big
OK: 2702 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


mssql_mnesia_24 / odbc_mssql_mnesia / c159446
Reports root/ big
OK: 3071 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0

@NelsonVides NelsonVides merged commit 4c8d7fd into without-dynamic-backend-modules Oct 30, 2021
@NelsonVides NelsonVides deleted the mu-without-dynamic-modules-in-sm branch October 30, 2021 08:09
@chrzaszcz
Copy link
Member

chrzaszcz commented Nov 2, 2021

For consistency, could we extend mongoose_backend to support such non-host-type (global) backends? Such pattern will occur a few more times and I think that it would be good to use one backend management module for this instead of creating persistent terms directly, which is a bit ad-hoc.

@arcusfelis
Copy link
Contributor Author

@chrzaszcz Yea, possible. What's about call_tracked/call API? ejabberd_gen_sm works kinda differently, it wants us to provide a backend module name. While mongoose_backend wants us to provide a HostType, and it gets a backend name internally.

Also, some operations, that would require several calls to the backend modules would be a little bit slower, because we currently get a backend module name once and use it in several functions (basically see below):

open_session(HostType, SID, JID, Priority, Info) ->
    BackendModule = sm_backend(),
    set_session(SID, JID, Priority, Info),
    ReplacedPIDs = check_for_sessions_to_replace(HostType, BackendModule, JID),
    mongoose_hooks:sm_register_connection_hook(HostType, SID, JID, Info),
    ReplacedPIDs.

We could also add HostType support into SM API. It asks for it :D

@Premwoik Premwoik modified the milestones: 5.1.0, 5.0.0 May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants