Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert scope to global for all global distrib redis presets #3393

Merged
merged 1 commit into from
Nov 9, 2021

Conversation

Premwoik
Copy link
Contributor

@Premwoik Premwoik commented Nov 9, 2021

This PR addresses MIM-1546

@mongoose-im
Copy link
Collaborator

mongoose-im commented Nov 9, 2021

small_tests_24 / small_tests / 7e82ac2
Reports root / small


internal_mnesia_24 / internal_mnesia / 7e82ac2
Reports root/ big
OK: 1587 / Failed: 0 / User-skipped: 297 / Auto-skipped: 0


small_tests_23 / small_tests / 7e82ac2
Reports root / small


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 7e82ac2
Reports root/ big
OK: 2722 / Failed: 0 / User-skipped: 186 / Auto-skipped: 0


ldap_mnesia_24 / ldap_mnesia / 7e82ac2
Reports root/ big
OK: 1525 / Failed: 1 / User-skipped: 370 / Auto-skipped: 0

push_SUITE:toggling:disable_all_nodes_removes_it_from_all_user_session_infos
{error,{{badmatch,{{jid,<<"pub-sub">>,
            <<"disable_all_nodes_removes_it_from_all_user_session_infos_8.111443">>,
            <<>>,<<"pub-sub">>,
            <<"disable_all_nodes_removes_it_from_all_user_session_infos_8.111443">>,
            <<>>},
           <<"princely_musings_BO00c7gOr+Y=">>,[]}},
    [{push_SUITE,'-disable_all_nodes_removes_it_from_all_user_session_infos/1-fun-0-',
           3,
           [{file,"/home/circleci/app/big_tests/tests/push_SUITE.erl"},
            {line,419}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1292}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1224}]}]}}

Report log


dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 7e82ac2
Reports root/ big
OK: 2722 / Failed: 0 / User-skipped: 186 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 7e82ac2
Reports root/ big
OK: 2722 / Failed: 0 / User-skipped: 186 / Auto-skipped: 0


dynamic_domains_mysql_redis_24 / mysql_redis / 7e82ac2
Reports root/ big
OK: 2705 / Failed: 0 / User-skipped: 203 / Auto-skipped: 0


ldap_mnesia_23 / ldap_mnesia / 7e82ac2
Reports root/ big
OK: 1521 / Failed: 1 / User-skipped: 370 / Auto-skipped: 0

sm_SUITE:parallel_manual_ack_freq_1:resume_session_state_send_message
{error,
  {{assertion_failed,assert_many,true,
     [#Fun<sm_SUITE.26.57441291>,#Fun<sm_SUITE.26.57441291>,
      #Fun<sm_SUITE.26.57441291>],
     [{xmlel,<<"presence">>,
        [{<<"from">>,
        <<"alicE_resume_session_state_send_message_31.971452@localhost/escalus-default-resource">>},
         {<<"to">>,
        <<"alice_resume_session_state_send_message_31.971452@localhost/escalus-default-resource">>},
         {<<"xml:lang">>,<<"en">>}],
        []},
      {xmlel,<<"message">>,
        [{<<"from">>,
        <<"bOb_resume_session_state_send_message_31.876101@localhost/escalus-default-resource">>},
         {<<"to">>,
        <<"alicE_resume_session_state_send_message_31.971452@localhost">>},
         {<<"xml:lang">>,<<"en">>},
         {<<"type">>,<<"chat">>}],
        [{xmlel,<<"body">>,[],[{xmlcdata,<<"msg-1">>}]},
         {xmlel,<<"delay">>,
           [{<<"xmlns">>,<<"urn:xmpp:delay">>},
          {<<"stamp">>,<<"2021-11-09T13:35:32.052905Z">>},
          {<<"from">>,<<"localhost">>}],
           [{xmlcdata,<<"SM Storage">>}]}]},
      {xmlel,<<"message">>,
        [{<<"from">>,
        <<"bOb_resume_session_state_send_message_31.876101@localhost/escalus-default-resource">>},
         {<<"to">>,
        <<"alicE_resume_session_state_send_message_31.971452@localhost">>},
         {<<"xml:lang">>,<<"en">>},
         {<<"type">>,<<"chat">>}],
        [{xmlel,<<"body">>,[],[{xmlcdata,<<"msg-2">>}]},
         {xmlel,<<"delay">>,
           [{<<"xmlns">>,<<"urn:xmpp:...

Report log


elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 7e82ac2
Reports root/ big
OK: 1892 / Failed: 0 / User-skipped: 297 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 7e82ac2
Reports root/ big
OK: 3121 / Failed: 0 / User-skipped: 183 / Auto-skipped: 0


mysql_redis_24 / mysql_redis / 7e82ac2
Reports root/ big
OK: 3104 / Failed: 0 / User-skipped: 200 / Auto-skipped: 0


mssql_mnesia_24 / odbc_mssql_mnesia / 7e82ac2
Reports root/ big
OK: 3121 / Failed: 0 / User-skipped: 183 / Auto-skipped: 0


pgsql_mnesia_23 / pgsql_mnesia / 7e82ac2
Reports root/ big
OK: 3121 / Failed: 0 / User-skipped: 183 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / 7e82ac2
Reports root/ big
OK: 1738 / Failed: 0 / User-skipped: 298 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Nov 9, 2021

Codecov Report

Merging #3393 (7e82ac2) into master (ef89bef) will increase coverage by 2.84%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3393      +/-   ##
==========================================
+ Coverage   77.85%   80.70%   +2.84%     
==========================================
  Files         397      397              
  Lines       32240    32240              
==========================================
+ Hits        25102    26019     +917     
+ Misses       7138     6221     -917     
Impacted Files Coverage Δ
src/mod_roster_mnesia.erl 72.72% <0.00%> (-21.22%) ⬇️
src/mongoose_tcp_listener.erl 76.59% <0.00%> (-4.26%) ⬇️
src/domain/mongoose_domain_sql.erl 82.85% <0.00%> (-2.86%) ⬇️
src/mod_muc_log.erl 78.11% <0.00%> (ø)
src/mod_muc_room.erl 77.14% <0.00%> (ø)
src/ejabberd_c2s.erl 89.42% <0.00%> (+0.22%) ⬆️
src/ejabberd_sm.erl 84.64% <0.00%> (+0.32%) ⬆️
...c/global_distrib/mod_global_distrib_server_mgr.erl 77.40% <0.00%> (+0.56%) ⬆️
src/metrics/mongoose_metrics.erl 95.45% <0.00%> (+0.64%) ⬆️
src/mam/mod_mam_utils.erl 86.53% <0.00%> (+0.96%) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef89bef...7e82ac2. Read the comment docs.

@Premwoik Premwoik marked this pull request as ready for review November 9, 2021 15:00
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@chrzaszcz chrzaszcz merged commit 8f92708 into master Nov 9, 2021
@chrzaszcz chrzaszcz deleted the global-distrib-redis-pool branch November 9, 2021 15:13
@Premwoik Premwoik modified the milestones: 5.1.0, 5.0.0 May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants