Do not use gen_mod:set_module_opt(s) in big tests

[Premwoik]

This PR addresses MIM-1547 and removes usage of gen_mod:set_module_opt(s) in modules:

• mam_SUITE
• roster_helper(presence_SUITE and domain_removal_SUITE)

[codecov]

Codecov Report

Merging #3398 (44ef957) into master (eacb079) will decrease coverage by 0.23%.
The diff coverage is n/a.

❗ Current head 44ef957 differs from pull request most recent head baf08cd. Consider uploading reports for the commit baf08cd to get more accurate results

@@            Coverage Diff             @@
##           master    #3398      +/-   ##
==========================================
- Coverage   80.90%   80.67%   -0.24%     
==========================================
  Files         414      397      -17     
  Lines       32437    32199     -238     
==========================================
- Hits        26244    25976     -268     
- Misses       6193     6223      +30     

Impacted Files	Coverage Δ
src/mod_roster_riak.erl	81.53% <0.00%> (-15.39%)	⬇️
src/mam/mod_mam_cassandra_prefs.erl	80.61% <0.00%> (-10.16%)	⬇️
src/gen_mod.erl	65.92% <0.00%> (-3.71%)	⬇️
src/wpool/mongoose_wpool_rdbms.erl	84.00% <0.00%> (-2.96%)	⬇️
src/domain/mongoose_domain_sql.erl	82.85% <0.00%> (-2.86%)	⬇️
...bal_distrib/mod_global_distrib_hosts_refresher.erl	75.47% <0.00%> (-1.89%)	⬇️
src/muc_light/mod_muc_light_db_mnesia.erl	88.54% <0.00%> (-0.94%)	⬇️
src/mod_commands.erl	92.56% <0.00%> (-0.52%)	⬇️
src/rdbms/mongoose_rdbms.erl	60.88% <0.00%> (-0.47%)	⬇️
.../mongoose_client_api/mongoose_client_api_rooms.erl	89.70% <0.00%> (-0.44%)	⬇️
... and 81 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eacb079...baf08cd. Read the comment docs.

[NelsonVides]

What about the very functions gen_mod:set_module_opt(s)? Are they still being used from anywhere else or can we finally remove them? 😄

[mongoose-im]

small_tests_24 / small_tests / baf08cd
Reports root / small

---

internal_mnesia_24 / internal_mnesia / baf08cd
Reports root/ big
OK: 1587 / Failed: 0 / User-skipped: 297 / Auto-skipped: 0

---

small_tests_24 / small_tests / baf08cd
Reports root / small

---

internal_mnesia_24 / internal_mnesia / baf08cd
Reports root/ big
OK: 1587 / Failed: 0 / User-skipped: 297 / Auto-skipped: 0

---

small_tests_23 / small_tests / baf08cd
Reports root / small

---

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / baf08cd
Reports root/ big
OK: 2722 / Failed: 0 / User-skipped: 186 / Auto-skipped: 0

---

dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / baf08cd
Reports root/ big
OK: 2721 / Failed: 1 / User-skipped: 186 / Auto-skipped: 0

service_domain_db_SUITE:db:db_keeps_syncing_after_cluster_join

{error,{test_case_failed,{[<<"example1.com">>,<<"example2.com">>,
               <<"example3.com">>],
              [<<"example1.com">>,<<"example2.com">>,
               <<"example3.com">>,<<"example4.com">>]}}}

Report log

---

ldap_mnesia_24 / ldap_mnesia / baf08cd
Reports root/ big
OK: 1514 / Failed: 0 / User-skipped: 370 / Auto-skipped: 0

---

dynamic_domains_mysql_redis_24 / mysql_redis / baf08cd
Reports root/ big
OK: 2705 / Failed: 0 / User-skipped: 203 / Auto-skipped: 0

---

dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / baf08cd
Reports root/ big
OK: 2722 / Failed: 0 / User-skipped: 186 / Auto-skipped: 0

---

ldap_mnesia_23 / ldap_mnesia / baf08cd
Reports root/ big
OK: 1514 / Failed: 0 / User-skipped: 370 / Auto-skipped: 0

---

pgsql_mnesia_24 / pgsql_mnesia / baf08cd
Reports root/ big
OK: 3121 / Failed: 0 / User-skipped: 183 / Auto-skipped: 0

---

elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / baf08cd
Reports root/ big
OK: 1892 / Failed: 0 / User-skipped: 297 / Auto-skipped: 0

---

pgsql_mnesia_23 / pgsql_mnesia / baf08cd
Reports root/ big
OK: 3121 / Failed: 0 / User-skipped: 183 / Auto-skipped: 0

---

mssql_mnesia_24 / odbc_mssql_mnesia / baf08cd
Reports root/ big
OK: 3121 / Failed: 0 / User-skipped: 183 / Auto-skipped: 0

---

mysql_redis_24 / mysql_redis / baf08cd
Reports root/ big
OK: 3104 / Failed: 0 / User-skipped: 200 / Auto-skipped: 0

---

riak_mnesia_24 / riak_mnesia / baf08cd
Reports root/ big
OK: 1738 / Failed: 0 / User-skipped: 298 / Auto-skipped: 0

---

dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / baf08cd
Reports root/ big
OK: 2722 / Failed: 0 / User-skipped: 186 / Auto-skipped: 0

[NelsonVides]

What about the very functions gen_mod:set_module_opt(s)? Are they still being used from anywhere else or can we finally remove them? 😄

Just checked, and if I'm not mistaken, these functions are indeed not used anymore in all of the repo, so why not removing them finally? 😄

[chrzaszcz]

Looks good! I checked it and there are no calls to set_module_opt(s) in the tests anymore.

[chrzaszcz]

What about the very functions gen_mod:set_module_opt(s)? Are they still being used from anywhere else or can we finally remove them? 😄

Just checked, and if I'm not mistaken, these functions are indeed not used anymore in all of the repo, so why not removing them finally? 😄

I agree, but maybe let's do it in a separate PR? Another follow-up would be to remove the usage of init_module from the tests including mam_SUITE.