Add a newline after module options to improve config readability #3402
Conversation
This way the resulting config for prod, dev nodes and all test presets has a single newline between each module. Previously some newlines were missing if there was at least one option as each option is in its separate line.
|
small_tests_24 / small_tests / 82b6c19 internal_mnesia_24 / internal_mnesia / 82b6c19 small_tests_23 / small_tests / 82b6c19 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 82b6c19 dynamic_domains_mysql_redis_24 / mysql_redis / 82b6c19 sm_SUITE:parallel_manual_ack_freq_1:resume_session_state_stop_c2s{error,{thrown,{timeout,msg}}}ldap_mnesia_24 / ldap_mnesia / 82b6c19 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 82b6c19 dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 82b6c19 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 82b6c19 ldap_mnesia_23 / ldap_mnesia / 82b6c19 pgsql_mnesia_24 / pgsql_mnesia / 82b6c19 mysql_redis_24 / mysql_redis / 82b6c19 pgsql_mnesia_23 / pgsql_mnesia / 82b6c19 mssql_mnesia_24 / odbc_mssql_mnesia / 82b6c19 riak_mnesia_24 / riak_mnesia / 82b6c19 jingle_SUITE:all:resp_4xx_from_sip_proxy_results_in_session_terminate{error,
{{assertion_failed,assert,is_iq_result,
{xmlel,<<"iq">>,
[{<<"from">>,<<"error.480@localhost">>},
{<<"to">>,
<<"alice_resp_4xx_from_sip_proxy_results_in_session_terminate_9.981111@localhost/res1">>},
{<<"id">>,<<"c1f90c86-7aec-43fd-b2d8-7c378d79ce6d">>},
{<<"type">>,<<"set">>}],
[{xmlel,<<"jingle">>,
[{<<"xmlns">>,<<"urn:xmpp:jingle:1">>},
{<<"action">>,<<"session-terminate">>},
{<<"sid">>,<<"b1471975-0dd6-4707-b34a-83feca25ead5">>}],
[{xmlel,<<"reason">>,[],
[{xmlel,<<"general-error">>,[],[]},
{xmlel,<<"sip-error">>,
[{<<"code">>,<<"480">>}],
[{xmlcdata,<<"Temporarily Unavailable">>}]}]}]}]},
"<iq from='error.480@localhost' to='alice_resp_4xx_from_sip_proxy_results_in_session_terminate_9.981111@localhost/res1' id='c1f90c86-7aec-43fd-b2d8-7c378d79ce6d' type='set'><jingle xmlns='urn:xmpp:jingle:1' action='session-terminate' sid='b1471975-0dd6-4707-b34a-83feca25ead5'><reason><general-error/><sip-error code='480'>Temporarily Unavailable</sip-error></reason></jingle></iq>"},
[{escalus_new_assert,assert_true,2,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{jingle_SUITE,send_initiate_and_wait_for_first_iq_set,2,
[{file,"/home/circleci/app/big_tests/tests/jingle_SUITE.erl"},
{line,395}]},
{jingle_SUITE,
'-resp_... |
Codecov Report
@@ Coverage Diff @@
## master #3402 +/- ##
==========================================
+ Coverage 80.90% 80.94% +0.03%
==========================================
Files 414 414
Lines 32437 32437
==========================================
+ Hits 26244 26255 +11
+ Misses 6193 6182 -11
Continue to review full report at Codecov.
|
The resulting config for prod, dev nodes and all test presets should have a single newline between modules in
mongooseim.toml. Previously some newlines were missing if there was at least one option as each option is in its separate line and there was no newline after the last option. Maybe for tests it's not that important but forprodit affects the initial configuration file, which had a bit broken layout, leading to worse initial impression.I chose to use '\n' as literal newlines could make the config spec less readable.
I checked the result manually for
mim1,prodand finally formim1with thepgsql_mnesiapreset enabled.