Correctly pass connection options to Fusco #3426
Conversation
The options were not used, which was critical when configuring TLS. Fusco did not complain, as the wpool library called did not call the exported start/start_link functions, which verified options. (https://github.com/inaka/worker_pool/blob/main/src/wpool_process.erl#L45).
Codecov Report
@@ Coverage Diff @@
## master #3426 +/- ##
===========================================
- Coverage 80.78% 17.51% -63.28%
===========================================
Files 414 414
Lines 32336 32285 -51
===========================================
- Hits 26124 5656 -20468
- Misses 6212 26629 +20417
Continue to review full report at Codecov.
|
|
small_tests_24 / small_tests / 0466d65 small_tests_23 / small_tests / 0466d65 dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 0466d65 dynamic_domains_mysql_redis_24 / mysql_redis / 0466d65 mam_SUITE:rdbms_async_cache_muc_all:muc04:muc_text_search_request{error,{test_case_failed,"Respond size is 2, 3 is expected."}}dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 0466d65 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 0466d65 ldap_mnesia_23 / ldap_mnesia / 0466d65 ldap_mnesia_24 / ldap_mnesia / 0466d65 internal_mnesia_24 / internal_mnesia / 0466d65 amp_big_SUITE:basic:notify_deliver_to_online_user_recipient_privacy_test{error,
{test_case_failed,
{has_stanzas_but_shouldnt,
{client,
<<"bOb_notify_deliver_to_online_user_recipient_privacy_test_61.46551@localhost/res1">>,
escalus_tcp,<0.3042.0>,
[{event_manager,<0.2661.0>},
{server,<<"localhost">>},
{username,
<<"bOb_notify_deliver_to_online_user_recipient_privacy_test_61.46551">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.2661.0>},
{server,<<"localhost">>},
{username,
<<"bOb_notify_deliver_to_online_user_recipient_privacy_test_61.46551">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,
<<"bOb_notify_deliver_to_online_user_recipient_privacy_test_61.46551">>},
{server,<<"localhost">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,
<<"bOb_notify_deliver_to_online_user_recipient_privacy_test_61.46551">>},
{server,<<"localhost">>},
{password,<<"makrolika">>},
{stream_id,<<"96e00598129164e2">>}]},
[{xmlel,<<"stream:error">>,[],
[{xmlel,<<"conflict">>,
[{<<"xmlns">>,
<<"urn:ietf:params:xml:ns:xmpp-streams">>}],
[]},
{xmlel,<<"text">>,
[{<<"xml:lang">>,<<"en">>},
{<<"xmlns">>,
<<"urn:ietf:params:xml:ns:xmpp-stre...amp_big_SUITE:basic:notify_deliver_to_online_user_recipient_privacy_test{error,
{test_case_failed,
{has_stanzas_but_shouldnt,
{client,
<<"alicE_notify_deliver_to_online_user_recipient_privacy_test_61.46551@localhost/res1">>,
escalus_tcp,<0.3017.0>,
[{event_manager,<0.2676.0>},
{server,<<"localhost">>},
{username,
<<"alicE_notify_deliver_to_online_user_recipient_privacy_test_61.46551">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.2676.0>},
{server,<<"localhost">>},
{username,
<<"alicE_notify_deliver_to_online_user_recipient_privacy_test_61.46551">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,
<<"alicE_notify_deliver_to_online_user_recipient_privacy_test_61.46551">>},
{server,<<"localhost">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,
<<"alicE_notify_deliver_to_online_user_recipient_privacy_test_61.46551">>},
{server,<<"localhost">>},
{password,<<"matygrysa">>},
{stream_id,<<"946115e1e1a91605">>}]},
[{xmlel,<<"stream:error">>,[],
[{xmlel,<<"conflict">>,
[{<<"xmlns">>,
<<"urn:ietf:params:xml:ns:xmpp-streams">>}],
[]},
{xmlel,<<"text">>,
[{<<"xml:lang">>,<<"en">>},
{<<"xmlns">>,
<<"urn:ietf:params:xml:ns...pgsql_mnesia_24 / pgsql_mnesia / 0466d65 pgsql_mnesia_23 / pgsql_mnesia / 0466d65 mssql_mnesia_24 / odbc_mssql_mnesia / 0466d65 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 0466d65 mysql_redis_24 / mysql_redis / 0466d65 riak_mnesia_24 / riak_mnesia / 0466d65 dynamic_domains_mysql_redis_24 / mysql_redis / 0466d65 internal_mnesia_24 / internal_mnesia / 0466d65 |
Codecov Report
@@ Coverage Diff @@
## master #3426 +/- ##
=======================================
Coverage 80.78% 80.78%
=======================================
Files 414 414
Lines 32336 32336
=======================================
Hits 26124 26124
Misses 6212 6212
Continue to review full report at Codecov.
|
The options are not used currently, which is critical when configuring TLS for HTTP auth.
Fusco did not complain, as the wpool library did not call the exported start/start_link functions, which verified options (https://github.com/inaka/worker_pool/blob/main/src/wpool_process.erl#L45, https://github.com/esl/fusco/blob/master/src/fusco.erl#L84).
Tested manually, without the patch, TLS is silently not verified and connection (if the MIM client certs are not rejected by the auth service) is established. With the patch, errors appear in logs when connecting to a service which has incorrect certificate.