Run tests in pubsub:basic in parallel

[arcusfelis]

Proposed changes include:

• Run tests in pubsub:basic in parallel
• We do repeat_all_until_all_ok anyway, so if there is a race condition, it would be good to see it
• Typos

The main motivation is that it has one test that sleeps 5 seconds (i.e. subscribe_options_deliver_option_test). But I probably need to read some pubsub to ensure we can check that notification would not come without sleeping :) - that would come separately

[codecov]

Codecov Report

Merging #3432 (8c4c6fd) into master (a540cd3) will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3432      +/-   ##
==========================================
+ Coverage   80.79%   80.87%   +0.07%     
==========================================
  Files         414      414              
  Lines       32336    32336              
==========================================
+ Hits        26126    26151      +25     
+ Misses       6210     6185      -25     

Impacted Files	Coverage Δ
src/elasticsearch/mongoose_elasticsearch.erl	76.92% <0.00%> (-7.70%)	⬇️
src/mam/mod_mam_elasticsearch_arch.erl	85.08% <0.00%> (-1.76%)	⬇️
src/rdbms/mongoose_rdbms.erl	61.75% <0.00%> (-1.20%)	⬇️
src/mod_muc_log.erl	78.11% <0.00%> (ø)
src/mod_muc_room.erl	77.26% <0.00%> (+0.17%)	⬆️
src/pubsub/mod_pubsub.erl	73.31% <0.00%> (+0.17%)	⬆️
src/mod_roster.erl	78.99% <0.00%> (+0.23%)	⬆️
src/pubsub/mod_pubsub_db_rdbms.erl	95.34% <0.00%> (+0.25%)	⬆️
src/ejabberd_c2s.erl	89.26% <0.00%> (+0.37%)	⬆️
...c/global_distrib/mod_global_distrib_server_mgr.erl	77.40% <0.00%> (+0.56%)	⬆️
... and 4 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a540cd3...8c4c6fd. Read the comment docs.

[mongoose-im]

small_tests_24 / small_tests / 8c4c6fd
Reports root / small

---

small_tests_23 / small_tests / 8c4c6fd
Reports root / small

---

dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 8c4c6fd
Reports root/ big
OK: 2726 / Failed: 0 / User-skipped: 186 / Auto-skipped: 0

---

dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 8c4c6fd
Reports root/ big
OK: 2726 / Failed: 0 / User-skipped: 186 / Auto-skipped: 0

---

dynamic_domains_mysql_redis_24 / mysql_redis / 8c4c6fd
Reports root/ big
OK: 2709 / Failed: 0 / User-skipped: 203 / Auto-skipped: 0

---

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 8c4c6fd
Reports root/ big
OK: 2726 / Failed: 0 / User-skipped: 186 / Auto-skipped: 0

---

ldap_mnesia_23 / ldap_mnesia / 8c4c6fd
Reports root/ big
OK: 1502 / Failed: 0 / User-skipped: 386 / Auto-skipped: 0

---

ldap_mnesia_24 / ldap_mnesia / 8c4c6fd
Reports root/ big
OK: 1502 / Failed: 0 / User-skipped: 386 / Auto-skipped: 0

---

internal_mnesia_24 / internal_mnesia / 8c4c6fd
Reports root/ big
OK: 1587 / Failed: 0 / User-skipped: 301 / Auto-skipped: 0

---

pgsql_mnesia_24 / pgsql_mnesia / 8c4c6fd
Reports root/ big
OK: 3113 / Failed: 0 / User-skipped: 195 / Auto-skipped: 0

---

elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 8c4c6fd
Reports root/ big
OK: 1880 / Failed: 0 / User-skipped: 313 / Auto-skipped: 0

---

pgsql_mnesia_23 / pgsql_mnesia / 8c4c6fd
Reports root/ big
OK: 3113 / Failed: 0 / User-skipped: 195 / Auto-skipped: 0

---

mssql_mnesia_24 / odbc_mssql_mnesia / 8c4c6fd
Reports root/ big
OK: 3121 / Failed: 1 / User-skipped: 195 / Auto-skipped: 0

disco_and_caps_SUITE:disco_with_caps:user_can_query_friend_features

{error,{{assertion_failed,assert_many,false,[is_roster_set],[],[]},
    [{escalus_new_assert,assert_true,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
                {line,84}]},
     {escalus_story,'-make_all_clients_friends/1-fun-0-',2,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,108}]},
     {escalus_utils,'-each_with_index/3-fun-0-',3,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
             {line,87}]},
     {lists,foldl,3,[{file,"lists.erl"},{line,1267}]},
     {escalus_utils,'-each_with_index/3-fun-0-',3,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
             {line,87}]},
     {lists,foldl,3,[{file,"lists.erl"},{line,1267}]},
     {escalus_utils,distinct_pairs,2,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
             {line,60}]},
     {escalus_story,make_all_clients_friends,1,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,106}]}]}}

Report log

---

mysql_redis_24 / mysql_redis / 8c4c6fd
Reports root/ big
OK: 3108 / Failed: 0 / User-skipped: 200 / Auto-skipped: 0

---

riak_mnesia_24 / riak_mnesia / 8c4c6fd
Reports root/ big
OK: 1733 / Failed: 1 / User-skipped: 314 / Auto-skipped: 0

sm_SUITE:parallel_manual_ack_freq_1:resume_session_state_stop_c2s

{error,{thrown,{timeout,msg}}}

Report log

[NelsonVides]

Yeah, ok, let's see if it crashes 🤔