Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth method defaults #3458

Merged
merged 4 commits into from
Dec 17, 2021
Merged

Auth method defaults #3458

merged 4 commits into from
Dec 17, 2021

Conversation

chrzaszcz
Copy link
Member

Introduce default values for auth methods, so they are easier to test and to find in the code.
The undefined values for LDAP are also included as defaults for consistency.

@mongoose-im

This comment has been minimized.

@codecov
Copy link

codecov bot commented Dec 17, 2021

Codecov Report

Merging #3458 (4813679) into master (38fcb5e) will decrease coverage by 0.01%.
The diff coverage is 95.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3458      +/-   ##
==========================================
- Coverage   80.78%   80.77%   -0.02%     
==========================================
  Files         415      415              
  Lines       32306    32303       -3     
==========================================
- Hits        26100    26093       -7     
- Misses       6206     6210       +4     
Impacted Files Coverage Δ
src/auth/ejabberd_auth_external.erl 29.70% <ø> (ø)
src/auth/ejabberd_auth_anonymous.erl 56.25% <50.00%> (ø)
src/auth/ejabberd_auth_dummy.erl 69.56% <100.00%> (-1.27%) ⬇️
src/auth/ejabberd_auth_ldap.erl 70.42% <100.00%> (ø)
src/auth/ejabberd_auth_rdbms.erl 57.22% <100.00%> (ø)
src/auth/ejabberd_auth_riak.erl 77.50% <100.00%> (ø)
src/auth/extauth.erl 62.71% <100.00%> (ø)
src/config/mongoose_config_spec.erl 98.87% <100.00%> (-0.01%) ⬇️
src/elasticsearch/mongoose_elasticsearch.erl 76.92% <0.00%> (-7.70%) ⬇️
src/mam/mod_mam_elasticsearch_arch.erl 85.08% <0.00%> (-1.76%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38fcb5e...4813679. Read the comment docs.

@mongoose-im

This comment has been minimized.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Dec 17, 2021

small_tests_24 / small_tests / 4813679
Reports root / small


small_tests_23 / small_tests / 4813679
Reports root / small


dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 4813679
Reports root/ big
OK: 2725 / Failed: 0 / User-skipped: 186 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 4813679
Reports root/ big
OK: 2725 / Failed: 0 / User-skipped: 186 / Auto-skipped: 0


dynamic_domains_mysql_redis_24 / mysql_redis / 4813679
Reports root/ big
OK: 2708 / Failed: 0 / User-skipped: 203 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 4813679
Reports root/ big
OK: 2725 / Failed: 0 / User-skipped: 186 / Auto-skipped: 0


ldap_mnesia_23 / ldap_mnesia / 4813679
Reports root/ big
OK: 1500 / Failed: 0 / User-skipped: 386 / Auto-skipped: 0


ldap_mnesia_24 / ldap_mnesia / 4813679
Reports root/ big
OK: 1500 / Failed: 0 / User-skipped: 386 / Auto-skipped: 0


internal_mnesia_24 / internal_mnesia / 4813679
Reports root/ big
OK: 1585 / Failed: 0 / User-skipped: 301 / Auto-skipped: 0


pgsql_mnesia_23 / pgsql_mnesia / 4813679
Reports root/ big
OK: 3112 / Failed: 0 / User-skipped: 195 / Auto-skipped: 0


elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 4813679
Reports root/ big
OK: 1878 / Failed: 0 / User-skipped: 313 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 4813679
Reports root/ big
OK: 3112 / Failed: 0 / User-skipped: 195 / Auto-skipped: 0


mysql_redis_24 / mysql_redis / 4813679
Reports root/ big
OK: 3107 / Failed: 0 / User-skipped: 200 / Auto-skipped: 0


mssql_mnesia_24 / odbc_mssql_mnesia / 4813679
Reports root/ big
OK: 3112 / Failed: 0 / User-skipped: 195 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / 4813679
Reports root/ big
OK: 1724 / Failed: 0 / User-skipped: 314 / Auto-skipped: 0

@chrzaszcz chrzaszcz marked this pull request as ready for review December 17, 2021 15:33
Copy link
Collaborator

@NelsonVides NelsonVides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent 👍🏽

@NelsonVides NelsonVides merged commit 3078826 into master Dec 17, 2021
@NelsonVides NelsonVides deleted the auth-method-defaults branch December 17, 2021 15:52
@Premwoik Premwoik added this to the 5.1.0 milestone May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants