Remove the ETS table from gen_mod

[chrzaszcz]

Before:

• Module options were stored in two places: mongoose_config (persistent terms) and gen_mod (ETS).
• API for getting module options and loaded modules was querying the ETS table.
• When a module was started/stopped by big tests, the check for already started/stopped module was duplicated: one in mongoose_modules and one in gen_mod.
• You shouldn't call gen_mod directly to start a module in the shell, but it was still possible.

After:

• Module options are stored only in mongoose_config.
• API for getting module options and loaded modules is querying the persistent terms.
• When a module is started/stopped by big tests, the check for already started/stopped module is done only in mongoose_modules.
• It is not possible to start a module in the shell with gen_mod because the config is missing, you should use mongoose_modules instead.

Other changes:

• Better test coverage for mongoose_modules and gen_mod API.

[codecov]

Codecov Report

Merging #3484 (e448b7c) into master (1262811) will increase coverage by 0.02%.
The diff coverage is 71.42%.

❗ Current head e448b7c differs from pull request most recent head fc28e62. Consider uploading reports for the commit fc28e62 to get more accurate results

@@            Coverage Diff             @@
##           master    #3484      +/-   ##
==========================================
+ Coverage   80.92%   80.95%   +0.02%     
==========================================
  Files         416      416              
  Lines       32352    32333      -19     
==========================================
- Hits        26180    26174       -6     
+ Misses       6172     6159      -13     

Impacted Files	Coverage Δ
src/ejabberd_app.erl	94.66% <ø> (-0.08%)	⬇️
src/gen_mod.erl	68.51% <66.66%> (+1.05%)	⬆️
src/mongoose_modules.erl	100.00% <100.00%> (ø)
src/http_upload/mod_http_upload.erl	94.62% <0.00%> (-2.16%)	⬇️
src/logger/mongoose_log_filter.erl	78.08% <0.00%> (-1.37%)	⬇️
src/ejabberd_c2s.erl	89.18% <0.00%> (+0.29%)	⬆️
src/mam/mod_mam_elasticsearch_arch.erl	86.84% <0.00%> (+1.75%)	⬆️
...bal_distrib/mod_global_distrib_hosts_refresher.erl	73.58% <0.00%> (+1.88%)	⬆️
src/config/mongoose_config.erl	97.22% <0.00%> (+2.77%)	⬆️
src/elasticsearch/mongoose_elasticsearch.erl	84.61% <0.00%> (+7.69%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1262811...fc28e62. Read the comment docs.

[mongoose-im]

small_tests_24 / small_tests / fc28e62
Reports root / small

---

small_tests_23 / small_tests / fc28e62
Reports root / small

---

dynamic_domains_mysql_redis_24 / mysql_redis / fc28e62
Reports root/ big
OK: 2671 / Failed: 0 / User-skipped: 247 / Auto-skipped: 0

---

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / fc28e62
Reports root/ big
OK: 2688 / Failed: 0 / User-skipped: 230 / Auto-skipped: 0

---

dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / fc28e62
Reports root/ big
OK: 2688 / Failed: 0 / User-skipped: 230 / Auto-skipped: 0

---

dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / fc28e62
Reports root/ big
OK: 2688 / Failed: 0 / User-skipped: 230 / Auto-skipped: 0

---

ldap_mnesia_24 / ldap_mnesia / fc28e62
Reports root/ big
OK: 1501 / Failed: 0 / User-skipped: 388 / Auto-skipped: 0

---

ldap_mnesia_23 / ldap_mnesia / fc28e62
Reports root/ big
OK: 1501 / Failed: 0 / User-skipped: 388 / Auto-skipped: 0

---

internal_mnesia_24 / internal_mnesia / fc28e62
Reports root/ big
OK: 1553 / Failed: 1 / User-skipped: 347 / Auto-skipped: 0

pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription

{error,
  {{badmatch,
     [{xmlel,<<"message">>,
        [{<<"from">>,
        <<"alice_unsubscribe_after_presence_unsubscription_965@localhost">>},
         {<<"to">>,
        <<"bob_unsubscribe_after_presence_unsubscription_965@localhost/res1">>},
         {<<"type">>,<<"headline">>}],
        [{xmlel,<<"event">>,
           [{<<"xmlns">>,
           <<"http://jabber.org/protocol/pubsub#event">>}],
           [{xmlel,<<"items">>,
            [{<<"node">>,<<"/zgJEyw+e5/DPEBfASg89w==">>}],
            [{xmlel,<<"item">>,
               [{<<"id">>,<<"salmon">>}],
               [{xmlel,<<"entry">>,
                  [{<<"xmlns">>,
                  <<"http://www.w3.org/2005/Atom">>}],
                  []}]}]}]},
         {xmlel,<<"headers">>,
           [{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
           []}]}]},
   [{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
      [{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
       {line,384}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1292}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1224}]}]}}

Report log

---

pgsql_mnesia_23 / pgsql_mnesia / fc28e62
Reports root/ big
OK: 3075 / Failed: 0 / User-skipped: 239 / Auto-skipped: 0

---

pgsql_mnesia_24 / pgsql_mnesia / fc28e62
Reports root/ big
OK: 3075 / Failed: 0 / User-skipped: 239 / Auto-skipped: 0

---

mssql_mnesia_24 / odbc_mssql_mnesia / fc28e62
Reports root/ big
OK: 3075 / Failed: 0 / User-skipped: 239 / Auto-skipped: 0

---

elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / fc28e62
Reports root/ big
OK: 1835 / Failed: 0 / User-skipped: 359 / Auto-skipped: 0

---

mysql_redis_24 / mysql_redis / fc28e62
Reports root/ big
OK: 3070 / Failed: 0 / User-skipped: 244 / Auto-skipped: 0

---

riak_mnesia_24 / riak_mnesia / fc28e62
Reports root/ big
OK: 1681 / Failed: 0 / User-skipped: 360 / Auto-skipped: 0

[NelsonVides]

🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉