Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to use podman instead of docker #3522

Merged
merged 4 commits into from
Feb 9, 2022
Merged

Allow to use podman instead of docker #3522

merged 4 commits into from
Feb 9, 2022

Conversation

arcusfelis
Copy link
Contributor

@arcusfelis arcusfelis commented Jan 28, 2022

This PR addresses "Desktop docker license change" MIM-1598.

Proposed changes include:

  • allows to use podman instead of docker
  • podman does not support mounting volumes from the host machine yet
  • But we already are not using volumes for circleci, so it makes sense to make circleci and setup-db code more similar.

And you can put alias docker=podman into your bash init script.
https://podman.io/whatis.html

What's else? It takes one hour to compile qemu (a dependency of podman) :D

One more thing, by default, podman machine takes 2GB of memory.
This means that after starting all other databases (i.e. primarily cassandra and elastic), starting mssql would fail (i.e. "podman ps" would not respond for some time, but after a minute, mssql container just stops and everything is fine). The solution is simple - just stop other containers in this case - it would release memory and make MSSQL happy (after that you can start these containers again, apparently).

@mongoose-im

This comment has been minimized.

@codecov
Copy link

codecov bot commented Jan 28, 2022

Codecov Report

Merging #3522 (38762c3) into master (1fa0fdc) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3522      +/-   ##
==========================================
+ Coverage   81.08%   81.09%   +0.01%     
==========================================
  Files         419      419              
  Lines       32298    32298              
==========================================
+ Hits        26188    26193       +5     
+ Misses       6110     6105       -5     
Impacted Files Coverage Δ
src/http_upload/mod_http_upload.erl 94.62% <0.00%> (-2.16%) ⬇️
...bal_distrib/mod_global_distrib_hosts_refresher.erl 71.69% <0.00%> (-1.89%) ⬇️
src/ejabberd_sm.erl 84.59% <0.00%> (-0.33%) ⬇️
src/mod_muc_room.erl 77.26% <0.00%> (+0.17%) ⬆️
src/ejabberd_c2s.erl 88.66% <0.00%> (+0.21%) ⬆️
src/domain/mongoose_domain_loader.erl 90.17% <0.00%> (+0.89%) ⬆️
src/muc_light/mod_muc_light_db_mnesia.erl 90.52% <0.00%> (+1.05%) ⬆️
src/mam/mod_mam_rdbms_arch_async.erl 97.77% <0.00%> (+1.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fa0fdc...38762c3. Read the comment docs.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Jan 28, 2022

small_tests_24 / small_tests / dccae65
Reports root / small


small_tests_23 / small_tests / dccae65
Reports root / small


dynamic_domains_mysql_redis_24 / mysql_redis / dccae65
Reports root/ big
OK: 2674 / Failed: 0 / User-skipped: 255 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / dccae65
Reports root/ big
OK: 2691 / Failed: 0 / User-skipped: 238 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / dccae65
Reports root/ big
OK: 2691 / Failed: 0 / User-skipped: 238 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / dccae65
Reports root/ big
OK: 2691 / Failed: 0 / User-skipped: 238 / Auto-skipped: 0


ldap_mnesia_23 / ldap_mnesia / dccae65
Reports root/ big
OK: 1500 / Failed: 0 / User-skipped: 390 / Auto-skipped: 0


ldap_mnesia_24 / ldap_mnesia / dccae65
Reports root/ big
OK: 1500 / Failed: 0 / User-skipped: 390 / Auto-skipped: 0


internal_mnesia_24 / internal_mnesia / dccae65
Reports root/ big
OK: 1541 / Failed: 0 / User-skipped: 349 / Auto-skipped: 0


elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / dccae65
Reports root/ big
OK: 1834 / Failed: 0 / User-skipped: 363 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / dccae65
Reports root/ big
OK: 3078 / Failed: 0 / User-skipped: 247 / Auto-skipped: 0


pgsql_mnesia_23 / pgsql_mnesia / dccae65
Reports root/ big
OK: 3078 / Failed: 0 / User-skipped: 247 / Auto-skipped: 0


mssql_mnesia_24 / odbc_mssql_mnesia / dccae65
Reports root/ big
OK: 3078 / Failed: 0 / User-skipped: 247 / Auto-skipped: 0


mysql_redis_24 / mysql_redis / dccae65
Reports root/ big
OK: 3073 / Failed: 0 / User-skipped: 252 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / dccae65
Reports root/ big
OK: 1680 / Failed: 0 / User-skipped: 363 / Auto-skipped: 0

@mongoose-im
Copy link
Collaborator

mongoose-im commented Jan 28, 2022

small_tests_24 / small_tests / 3aa83cc
Reports root / small


small_tests_23 / small_tests / 3aa83cc
Reports root / small


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 3aa83cc
Reports root/ big
OK: 2691 / Failed: 0 / User-skipped: 238 / Auto-skipped: 0


dynamic_domains_mysql_redis_24 / mysql_redis / 3aa83cc
Reports root/ big
OK: 2674 / Failed: 0 / User-skipped: 255 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 3aa83cc
Reports root/ big
OK: 2691 / Failed: 0 / User-skipped: 238 / Auto-skipped: 0


ldap_mnesia_23 / ldap_mnesia / 3aa83cc
Reports root/ big
OK: 1500 / Failed: 0 / User-skipped: 390 / Auto-skipped: 0


ldap_mnesia_24 / ldap_mnesia / 3aa83cc
Reports root/ big
OK: 1500 / Failed: 0 / User-skipped: 390 / Auto-skipped: 0


internal_mnesia_24 / internal_mnesia / 3aa83cc
Reports root/ big
OK: 1541 / Failed: 0 / User-skipped: 349 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 3aa83cc
Reports root/ big
OK: 3077 / Failed: 1 / User-skipped: 247 / Auto-skipped: 0

service_domain_db_SUITE:db:db_keeps_syncing_after_cluster_join
{error,{test_case_failed,{[<<"example1.com">>,<<"example2.com">>,
               <<"example3.com">>],
              [<<"example1.com">>,<<"example2.com">>,
               <<"example3.com">>,<<"example4.com">>]}}}

Report log


elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 3aa83cc
Reports root/ big
OK: 1834 / Failed: 0 / User-skipped: 363 / Auto-skipped: 0


pgsql_mnesia_23 / pgsql_mnesia / 3aa83cc
Reports root/ big
OK: 3078 / Failed: 0 / User-skipped: 247 / Auto-skipped: 0


mysql_redis_24 / mysql_redis / 3aa83cc
Reports root/ big
OK: 3073 / Failed: 0 / User-skipped: 252 / Auto-skipped: 0


mssql_mnesia_24 / odbc_mssql_mnesia / 3aa83cc
Reports root/ big
OK: 3078 / Failed: 0 / User-skipped: 247 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / 3aa83cc
Reports root/ big
OK: 1680 / Failed: 0 / User-skipped: 363 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 3aa83cc
Reports root/ big
OK: 3078 / Failed: 0 / User-skipped: 247 / Auto-skipped: 0

@mongoose-im
Copy link
Collaborator

mongoose-im commented Jan 31, 2022

small_tests_24 / small_tests / 917223f
Reports root / small


small_tests_23 / small_tests / 917223f
Reports root / small


dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 917223f
Reports root/ big
OK: 2691 / Failed: 0 / User-skipped: 238 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 917223f
Reports root/ big
OK: 2691 / Failed: 0 / User-skipped: 238 / Auto-skipped: 0


dynamic_domains_mysql_redis_24 / mysql_redis / 917223f
Reports root/ big
OK: 2674 / Failed: 0 / User-skipped: 255 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 917223f
Reports root/ big
OK: 2691 / Failed: 0 / User-skipped: 238 / Auto-skipped: 0


ldap_mnesia_23 / ldap_mnesia / 917223f
Reports root/ big
OK: 1500 / Failed: 0 / User-skipped: 390 / Auto-skipped: 0


ldap_mnesia_24 / ldap_mnesia / 917223f
Reports root/ big
OK: 1500 / Failed: 0 / User-skipped: 390 / Auto-skipped: 0


internal_mnesia_24 / internal_mnesia / 917223f
Reports root/ big
OK: 1541 / Failed: 0 / User-skipped: 349 / Auto-skipped: 0


pgsql_mnesia_23 / pgsql_mnesia / 917223f
Reports root/ big
OK: 3078 / Failed: 0 / User-skipped: 247 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 917223f
Reports root/ big
OK: 3078 / Failed: 0 / User-skipped: 247 / Auto-skipped: 0


mysql_redis_24 / mysql_redis / 917223f
Reports root/ big
OK: 3073 / Failed: 0 / User-skipped: 252 / Auto-skipped: 0


elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 917223f
Reports root/ big
OK: 1834 / Failed: 0 / User-skipped: 363 / Auto-skipped: 0


mssql_mnesia_24 / odbc_mssql_mnesia / 917223f
Reports root/ big
OK: 3078 / Failed: 0 / User-skipped: 247 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / 917223f
Reports root/ big
OK: 1680 / Failed: 0 / User-skipped: 363 / Auto-skipped: 0

@mongoose-im
Copy link
Collaborator

mongoose-im commented Feb 3, 2022

small_tests_24 / small_tests / 38762c3
Reports root / small


small_tests_23 / small_tests / 38762c3
Reports root / small


dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 38762c3
Reports root/ big
OK: 2698 / Failed: 0 / User-skipped: 239 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 38762c3
Reports root/ big
OK: 2698 / Failed: 0 / User-skipped: 239 / Auto-skipped: 0


dynamic_domains_mysql_redis_24 / mysql_redis / 38762c3
Reports root/ big
OK: 2681 / Failed: 0 / User-skipped: 256 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 38762c3
Reports root/ big
OK: 2698 / Failed: 0 / User-skipped: 239 / Auto-skipped: 0


ldap_mnesia_23 / ldap_mnesia / 38762c3
Reports root/ big
OK: 1506 / Failed: 0 / User-skipped: 390 / Auto-skipped: 0


ldap_mnesia_24 / ldap_mnesia / 38762c3
Reports root/ big
OK: 1506 / Failed: 0 / User-skipped: 390 / Auto-skipped: 0


internal_mnesia_24 / internal_mnesia / 38762c3
Reports root/ big
OK: 1547 / Failed: 0 / User-skipped: 349 / Auto-skipped: 0


elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 38762c3
Reports root/ big
OK: 1840 / Failed: 0 / User-skipped: 365 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 38762c3
Reports root/ big
OK: 3091 / Failed: 0 / User-skipped: 248 / Auto-skipped: 0


pgsql_mnesia_23 / pgsql_mnesia / 38762c3
Reports root/ big
OK: 3091 / Failed: 0 / User-skipped: 248 / Auto-skipped: 0


mysql_redis_24 / mysql_redis / 38762c3
Reports root/ big
OK: 3086 / Failed: 0 / User-skipped: 253 / Auto-skipped: 0


mssql_mnesia_24 / odbc_mssql_mnesia / 38762c3
Reports root/ big
OK: 3107 / Failed: 1 / User-skipped: 248 / Auto-skipped: 0

vcard_SUITE:ro_full:retrieve_own_card
{error,{test_case_failed,"Expected <<\"alice\">> got undefined\n"}}

Report log


riak_mnesia_24 / riak_mnesia / 38762c3
Reports root/ big
OK: 1686 / Failed: 0 / User-skipped: 364 / Auto-skipped: 0

Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@chrzaszcz chrzaszcz merged commit 2e6458c into master Feb 9, 2022
@chrzaszcz chrzaszcz deleted the mu-podman branch February 9, 2022 11:21
@Premwoik Premwoik added this to the 5.1.0 milestone May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants