Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build packages without using volumes #3543

Merged
merged 1 commit into from
Feb 17, 2022
Merged

Conversation

arcusfelis
Copy link
Contributor

This PR addresses "podman support". Also useful if you build on a remote machine.

Proposed changes include:

  • Use copy to extract a built package, instead of volumes.

@codecov
Copy link

codecov bot commented Feb 15, 2022

Codecov Report

Merging #3543 (c1a1534) into master (414cad3) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3543      +/-   ##
==========================================
- Coverage   81.09%   81.08%   -0.02%     
==========================================
  Files         419      419              
  Lines       32295    32295              
==========================================
- Hits        26191    26185       -6     
- Misses       6104     6110       +6     
Impacted Files Coverage Δ
src/pubsub/mod_pubsub_db.erl 57.14% <0.00%> (-28.58%) ⬇️
src/elasticsearch/mongoose_elasticsearch.erl 76.92% <0.00%> (-7.70%) ⬇️
src/cassandra/mongoose_cassandra.erl 77.77% <0.00%> (-3.71%) ⬇️
src/cassandra/mongoose_cassandra_worker.erl 65.72% <0.00%> (-2.82%) ⬇️
...bal_distrib/mod_global_distrib_hosts_refresher.erl 71.69% <0.00%> (-1.89%) ⬇️
src/mam/mod_mam_elasticsearch_arch.erl 85.08% <0.00%> (-1.76%) ⬇️
src/pubsub/mod_pubsub_db_mnesia.erl 92.43% <0.00%> (-0.85%) ⬇️
src/pubsub/mod_pubsub.erl 73.13% <0.00%> (-0.18%) ⬇️
src/mod_muc_log.erl 78.11% <0.00%> (ø)
src/global_distrib/mod_global_distrib_receiver.erl 81.11% <0.00%> (+1.11%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 414cad3...c1a1534. Read the comment docs.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Feb 15, 2022

small_tests_24 / small_tests / c1a1534
Reports root / small


small_tests_23 / small_tests / c1a1534
Reports root / small


dynamic_domains_mysql_redis_24 / mysql_redis / c1a1534
Reports root/ big
OK: 2703 / Failed: 0 / User-skipped: 256 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / c1a1534
Reports root/ big
OK: 2720 / Failed: 0 / User-skipped: 239 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / c1a1534
Reports root/ big
OK: 2720 / Failed: 0 / User-skipped: 239 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / c1a1534
Reports root/ big
OK: 2720 / Failed: 0 / User-skipped: 239 / Auto-skipped: 0


ldap_mnesia_23 / ldap_mnesia / c1a1534
Reports root/ big
OK: 1509 / Failed: 0 / User-skipped: 390 / Auto-skipped: 0


ldap_mnesia_24 / ldap_mnesia / c1a1534
Reports root/ big
OK: 1509 / Failed: 0 / User-skipped: 390 / Auto-skipped: 0


internal_mnesia_24 / internal_mnesia / c1a1534
Reports root/ big
OK: 1550 / Failed: 0 / User-skipped: 349 / Auto-skipped: 0


pgsql_mnesia_23 / pgsql_mnesia / c1a1534
Reports root/ big
OK: 3094 / Failed: 0 / User-skipped: 248 / Auto-skipped: 0


mysql_redis_24 / mysql_redis / c1a1534
Reports root/ big
OK: 3089 / Failed: 0 / User-skipped: 253 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / c1a1534
Reports root/ big
OK: 3094 / Failed: 0 / User-skipped: 248 / Auto-skipped: 0


elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / c1a1534
Reports root/ big
OK: 1843 / Failed: 0 / User-skipped: 365 / Auto-skipped: 0


mssql_mnesia_24 / odbc_mssql_mnesia / c1a1534
Reports root/ big
OK: 3094 / Failed: 0 / User-skipped: 248 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / c1a1534
Reports root/ big
OK: 1689 / Failed: 0 / User-skipped: 364 / Auto-skipped: 0

Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@chrzaszcz chrzaszcz merged commit 8005e53 into master Feb 17, 2022
@chrzaszcz chrzaszcz deleted the mu-packages-built-in-podman branch February 17, 2022 07:39
@Premwoik Premwoik added this to the 5.1.0 milestone May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants