Support maps in gen_mod_deps #3555
Conversation
chrzaszcz
force-pushed
the
module-deps-with-maps
branch
3 times, most recently
from
39b8906
to
f1202cf
Compare
chrzaszcz
force-pushed
the
module-deps-with-maps
branch
from
f1202cf
to
2ba28b5
Compare
Codecov Report
@@ Coverage Diff @@
## master #3555 +/- ##
==========================================
- Coverage 79.26% 79.23% -0.04%
==========================================
Files 420 420
Lines 32266 32265 -1
==========================================
- Hits 25577 25564 -13
- Misses 6689 6701 +12
Continue to review full report at Codecov.
|
This comment was marked as outdated.
This comment was marked as outdated.
chrzaszcz
force-pushed
the
module-deps-with-maps
branch
from
2ba28b5
to
634c0cc
Compare
|
small_tests_24 / small_tests / 634c0cc small_tests_23 / small_tests / 634c0cc dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 634c0cc dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 634c0cc dynamic_domains_mysql_redis_24 / mysql_redis / 634c0cc dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 634c0cc ldap_mnesia_23 / ldap_mnesia / 634c0cc ldap_mnesia_24 / ldap_mnesia / 634c0cc internal_mnesia_24 / internal_mnesia / 634c0cc elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 634c0cc pgsql_mnesia_24 / pgsql_mnesia / 634c0cc pgsql_mnesia_23 / pgsql_mnesia / 634c0cc mysql_redis_24 / mysql_redis / 634c0cc mssql_mnesia_24 / odbc_mssql_mnesia / 634c0cc riak_mnesia_24 / riak_mnesia / 634c0cc |
- Update dependency processing and resolution - Update type specs, improving reuse
Do not maintain tests for lists and maps as this state is temporary.
chrzaszcz
force-pushed
the
module-deps-with-maps
branch
from
634c0cc
to
7b99d7b
Compare
|
small_tests_24 / small_tests / 7b99d7b small_tests_23 / small_tests / 7b99d7b dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 7b99d7b dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 7b99d7b dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 7b99d7b dynamic_domains_mysql_redis_24 / mysql_redis / 7b99d7b ldap_mnesia_24 / ldap_mnesia / 7b99d7b ldap_mnesia_23 / ldap_mnesia / 7b99d7b internal_mnesia_24 / internal_mnesia / 7b99d7b pgsql_mnesia_23 / pgsql_mnesia / 7b99d7b pgsql_mnesia_24 / pgsql_mnesia / 7b99d7b elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 7b99d7b mssql_mnesia_24 / odbc_mssql_mnesia / 7b99d7b mysql_redis_24 / mysql_redis / 7b99d7b riak_mnesia_24 / riak_mnesia / 7b99d7b |
| @@ -536,13 +536,13 @@ config_metrics(HostType) -> | |||
|
|
|||
| muclight_dep(List) -> | |||
| case lists:member(muclight, List) of | |||
| true -> [{mod_muc_light, hard}]; | |||
| true -> [{mod_muc_light, [], hard}]; | |||
There was a problem hiding this comment.
From what I understand - this place, and all these similar ones could be a #{} already?
There was a problem hiding this comment.
No, if a module still has its options in a list, it should be [], that's the whole point of making this explicit.
When mod_muc_light opts get converted to a map, this should be changed to #{}. Same applies to other modules. Otherwise a module expecting a list would get a map, and it could potentially crash.
Prepare module deps for module opts in maps - now modules using maps can be deps of other modules.
[]and#{}are possible now. This does not seem to be worse in any way, so I think it is a permanent change.Minor changes:
opts, notargsorparams.