Implement GraphQL MUC Light user queries #3563

Premwoik · 2022-02-25T11:56:42Z

This PR implements the user part of the MUC Light category. The user API is basically the admin API without a user argument in queries and the user is taken from the context. User tests are mostly adapted admin tests.

In addition, this PR introduces a blocking list management API both for users and admin. It also adds a NonEmptyString scalar that validates if the given string is not empty.

I also provide here some admin part improvements:

Return passed page size as a limit field in the StanzaPayload type.
Use macro paths in admin tests.
Other minor fixes.

codecov · 2022-02-25T12:04:47Z

Codecov Report

Merging #3563 (52f77be) into feature/graphql (28f484f) will increase coverage by 0.11%.
The diff coverage is 95.65%.

@@                 Coverage Diff                 @@
##           feature/graphql    #3563      +/-   ##
===================================================
+ Coverage            81.36%   81.47%   +0.11%     
===================================================
  Files                  454      456       +2     
  Lines                32955    33068     +113     
===================================================
+ Hits                 26814    26943     +129     
+ Misses                6141     6125      -16

Impacted Files	Coverage Δ
src/graphql/mongoose_graphql.erl	`91.11% <ø> (ø)`
...ngoose_client_api/mongoose_client_api_messages.erl	`92.06% <ø> (ø)`
src/graphql/mongoose_graphql_scalar.erl	`66.66% <50.00%> (-5.56%)`	⬇️
src/graphql/mongoose_graphql_enum.erl	`58.82% <87.50%> (+22.45%)`	⬆️
src/muc_light/mod_muc_light_api.erl	`97.03% <94.91%> (+1.98%)`	⬆️
...dmin/mongoose_graphql_muc_light_admin_mutation.erl	`100.00% <100.00%> (ø)`
...l/admin/mongoose_graphql_muc_light_admin_query.erl	`100.00% <100.00%> (ø)`
src/graphql/mongoose_graphql_muc_light_helper.erl	`100.00% <100.00%> (ø)`
.../user/mongoose_graphql_muc_light_user_mutation.erl	`100.00% <100.00%> (ø)`
...hql/user/mongoose_graphql_muc_light_user_query.erl	`100.00% <100.00%> (ø)`
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28f484f...52f77be. Read the comment docs.

mongoose-im · 2022-03-01T23:08:57Z

small_tests_24 / small_tests / 48283d4
Reports root / small

small_tests_23 / small_tests / 48283d4
Reports root / small

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 48283d4
Reports root/ big
OK: 2793 / Failed: 0 / User-skipped: 238 / Auto-skipped: 0

dynamic_domains_mysql_redis_24 / mysql_redis / 48283d4
Reports root/ big
OK: 2776 / Failed: 0 / User-skipped: 255 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 48283d4
Reports root/ big
OK: 2793 / Failed: 0 / User-skipped: 238 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 48283d4
Reports root/ big
OK: 2793 / Failed: 0 / User-skipped: 238 / Auto-skipped: 0

ldap_mnesia_24 / ldap_mnesia / 48283d4
Reports root/ big
OK: 1568 / Failed: 0 / User-skipped: 424 / Auto-skipped: 0

internal_mnesia_24 / internal_mnesia / 48283d4
Reports root/ big
OK: 1614 / Failed: 0 / User-skipped: 378 / Auto-skipped: 0

ldap_mnesia_23 / ldap_mnesia / 48283d4
Reports root/ big
OK: 1568 / Failed: 0 / User-skipped: 424 / Auto-skipped: 0

elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 48283d4
Reports root/ big
OK: 1920 / Failed: 0 / User-skipped: 379 / Auto-skipped: 0

pgsql_mnesia_23 / pgsql_mnesia / 48283d4
Reports root/ big
OK: 3180 / Failed: 0 / User-skipped: 247 / Auto-skipped: 0

mysql_redis_24 / mysql_redis / 48283d4
Reports root/ big
OK: 3175 / Failed: 0 / User-skipped: 252 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / 48283d4
Reports root/ big
OK: 3180 / Failed: 0 / User-skipped: 247 / Auto-skipped: 0

mssql_mnesia_24 / odbc_mssql_mnesia / 48283d4
Reports root/ big
OK: 3180 / Failed: 0 / User-skipped: 247 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / 48283d4
Reports root/ big
OK: 1768 / Failed: 0 / User-skipped: 377 / Auto-skipped: 0

chrzaszcz

It all looks really good in general. I added a few minor comments.

big_tests/tests/graphql_muc_light_SUITE.erl

priv/graphql/schemas/global/muc.gql

src/graphql/user/mongoose_graphql_muc_light_user_mutation.erl

src/muc_light/mod_muc_light_api.erl

Separate creating a room with generated id from creating a room with the given one.

mongoose-im · 2022-03-03T09:34:50Z

small_tests_24 / small_tests / 52f77be
Reports root / small

small_tests_23 / small_tests / 52f77be
Reports root / small

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 52f77be
Reports root/ big
OK: 2793 / Failed: 0 / User-skipped: 238 / Auto-skipped: 0

dynamic_domains_mysql_redis_24 / mysql_redis / 52f77be
Reports root/ big
OK: 2776 / Failed: 0 / User-skipped: 255 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 52f77be
Reports root/ big
OK: 2793 / Failed: 0 / User-skipped: 238 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 52f77be
Reports root/ big
OK: 2793 / Failed: 0 / User-skipped: 238 / Auto-skipped: 0

ldap_mnesia_23 / ldap_mnesia / 52f77be
Reports root/ big
OK: 1568 / Failed: 0 / User-skipped: 424 / Auto-skipped: 0

ldap_mnesia_24 / ldap_mnesia / 52f77be
Reports root/ big
OK: 1568 / Failed: 0 / User-skipped: 424 / Auto-skipped: 0

internal_mnesia_24 / internal_mnesia / 52f77be
Reports root/ big
OK: 1614 / Failed: 0 / User-skipped: 378 / Auto-skipped: 0

pgsql_mnesia_23 / pgsql_mnesia / 52f77be
Reports root/ big
OK: 3180 / Failed: 0 / User-skipped: 247 / Auto-skipped: 0

mssql_mnesia_24 / odbc_mssql_mnesia / 52f77be
Reports root/ big
OK: 3180 / Failed: 0 / User-skipped: 247 / Auto-skipped: 0

mysql_redis_24 / mysql_redis / 52f77be
Reports root/ big
OK: 3175 / Failed: 0 / User-skipped: 252 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / 52f77be
Reports root/ big
OK: 3180 / Failed: 0 / User-skipped: 247 / Auto-skipped: 0

elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 52f77be
Reports root/ big
OK: 1920 / Failed: 0 / User-skipped: 379 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / 52f77be
Reports root/ big
OK: 1768 / Failed: 0 / User-skipped: 377 / Auto-skipped: 0

chrzaszcz

All great 👍

This comment was marked as outdated.

Sign in to view

mongoose-im mentioned this pull request Feb 25, 2022

CI build failures summary #3360

Closed

Premwoik force-pushed the graphql/muc-light-api-user branch from f19d81b to 2638714 Compare February 28, 2022 09:27

This comment was marked as outdated.

Sign in to view

Premwoik force-pushed the graphql/muc-light-api-user branch from 348844e to 7869e2a Compare March 1, 2022 10:29

This comment was marked as outdated.

Sign in to view

Premwoik force-pushed the graphql/muc-light-api-user branch from 7869e2a to 7e8b7b6 Compare March 1, 2022 11:32

This comment was marked as outdated.

Sign in to view

Add schema for muc light user API

eeb0510

Premwoik force-pushed the graphql/muc-light-api-user branch from 7e8b7b6 to fe44123 Compare March 1, 2022 20:37

This comment was marked as outdated.

Sign in to view

Premwoik added 9 commits March 1, 2022 23:21

Extend muc light api with user functionality

35e1c4a

Use muc light api in old user rest api

c6e615e

Add graphql resolvers for muc light user queries

28ac94c

Add tests for graphql muc light user api

3798155

Add user blocking list management to muc light api

778c519

Add admin queries for blocking list management

b131c44

Add user queries for blocking list management

be0ba15

Use macro paths in admin tests

6961e34

Add a default page size for admin getRoomMessages query

48283d4

Premwoik force-pushed the graphql/muc-light-api-user branch from fe44123 to 48283d4 Compare March 1, 2022 23:01

Premwoik marked this pull request as ready for review March 2, 2022 07:54

Premwoik added the waiting-for-review label Mar 2, 2022

chrzaszcz reviewed Mar 2, 2022

View reviewed changes

Base automatically changed from graphql/muc-light-api to feature/graphql March 2, 2022 16:44

Premwoik added 2 commits March 3, 2022 00:05

Split mod_muc_light_api:create_room function into two

88df1b8

Separate creating a room with generated id from creating a room with the given one.

Add NonEmptyString scalar

b8616e4

Premwoik added 2 commits March 3, 2022 00:06

Use NonEmptyString for ID arg in createRoom queries

458d82c

Apply minor review comments

52f77be

Premwoik force-pushed the graphql/muc-light-api-user branch from 34fb70f to 52f77be Compare March 3, 2022 09:26

This comment was marked as outdated.

Sign in to view

chrzaszcz approved these changes Mar 3, 2022

View reviewed changes

chrzaszcz merged commit 08f95fa into feature/graphql Mar 3, 2022

chrzaszcz deleted the graphql/muc-light-api-user branch March 3, 2022 10:24

chrzaszcz added this to the 6.0.0 milestone Dec 12, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement GraphQL MUC Light user queries #3563

Implement GraphQL MUC Light user queries #3563

Premwoik commented Feb 25, 2022 •

edited

codecov bot commented Feb 25, 2022 •

edited

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

mongoose-im commented Mar 1, 2022 •

edited

chrzaszcz left a comment

This comment was marked as outdated.

mongoose-im commented Mar 3, 2022 •

edited

chrzaszcz left a comment

Implement GraphQL MUC Light user queries #3563

Implement GraphQL MUC Light user queries #3563

Conversation

Premwoik commented Feb 25, 2022 • edited

codecov bot commented Feb 25, 2022 • edited

Codecov Report

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

mongoose-im commented Mar 1, 2022 • edited

chrzaszcz left a comment

Choose a reason for hiding this comment

This comment was marked as outdated.

mongoose-im commented Mar 3, 2022 • edited

chrzaszcz left a comment

Choose a reason for hiding this comment

Premwoik commented Feb 25, 2022 •

edited

codecov bot commented Feb 25, 2022 •

edited

mongoose-im commented Mar 1, 2022 •

edited

mongoose-im commented Mar 3, 2022 •

edited