Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put mod_sic opts in a map with defaults #3568

Merged
merged 1 commit into from
Mar 2, 2022
Merged

Conversation

gustawlippa
Copy link
Contributor

No description provided.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Mar 1, 2022

small_tests_24 / small_tests / 8f8b8ab
Reports root / small


small_tests_23 / small_tests / 8f8b8ab
Reports root / small


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 8f8b8ab
Reports root/ big
OK: 2727 / Failed: 0 / User-skipped: 239 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 8f8b8ab
Reports root/ big
OK: 2727 / Failed: 0 / User-skipped: 239 / Auto-skipped: 0


dynamic_domains_mysql_redis_24 / mysql_redis / 8f8b8ab
Reports root/ big
OK: 2710 / Failed: 0 / User-skipped: 256 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 8f8b8ab
Reports root/ big
OK: 2727 / Failed: 0 / User-skipped: 239 / Auto-skipped: 0


ldap_mnesia_23 / ldap_mnesia / 8f8b8ab
Reports root/ big
OK: 1510 / Failed: 0 / User-skipped: 392 / Auto-skipped: 0


ldap_mnesia_24 / ldap_mnesia / 8f8b8ab
Reports root/ big
OK: 1510 / Failed: 0 / User-skipped: 392 / Auto-skipped: 0


internal_mnesia_24 / internal_mnesia / 8f8b8ab
Reports root/ big
OK: 1551 / Failed: 0 / User-skipped: 351 / Auto-skipped: 0


pgsql_mnesia_23 / pgsql_mnesia / 8f8b8ab
Reports root/ big
OK: 3101 / Failed: 0 / User-skipped: 248 / Auto-skipped: 0


elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 8f8b8ab
Reports root/ big
OK: 1844 / Failed: 0 / User-skipped: 367 / Auto-skipped: 0


mysql_redis_24 / mysql_redis / 8f8b8ab
Reports root/ big
OK: 3096 / Failed: 0 / User-skipped: 253 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 8f8b8ab
Reports root/ big
OK: 3101 / Failed: 0 / User-skipped: 248 / Auto-skipped: 0


mssql_mnesia_24 / odbc_mssql_mnesia / 8f8b8ab
Reports root/ big
OK: 3101 / Failed: 0 / User-skipped: 248 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / 8f8b8ab
Reports root/ big
OK: 1690 / Failed: 0 / User-skipped: 366 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Mar 1, 2022

Codecov Report

Merging #3568 (8f8b8ab) into master (efd6bec) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3568      +/-   ##
==========================================
- Coverage   81.14%   81.14%   -0.01%     
==========================================
  Files         421      421              
  Lines       32306    32305       -1     
==========================================
- Hits        26216    26214       -2     
- Misses       6090     6091       +1     
Impacted Files Coverage Δ
src/mod_sic.erl 76.47% <100.00%> (-1.31%) ⬇️
src/event_pusher/mod_event_pusher_sns.erl 83.11% <0.00%> (-11.69%) ⬇️
src/http_upload/mod_http_upload.erl 94.62% <0.00%> (-2.16%) ⬇️
src/ejabberd_sm.erl 84.59% <0.00%> (-0.33%) ⬇️
src/pubsub/mod_pubsub.erl 73.31% <0.00%> (+0.17%) ⬆️
src/ejabberd_c2s.erl 88.97% <0.00%> (+0.29%) ⬆️
src/offline/mod_offline.erl 77.17% <0.00%> (+1.08%) ⬆️
src/mam/mod_mam_rdbms_arch_async.erl 97.75% <0.00%> (+1.12%) ⬆️
...bal_distrib/mod_global_distrib_hosts_refresher.erl 73.58% <0.00%> (+1.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efd6bec...8f8b8ab. Read the comment docs.

Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👍

@chrzaszcz chrzaszcz merged commit 859121a into master Mar 2, 2022
@chrzaszcz chrzaszcz deleted the mod_sic-map-config branch March 2, 2022 07:45
@Premwoik Premwoik added this to the 5.1.0 milestone May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants