Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate segmented cache to maps #3572

Merged
merged 1 commit into from
Mar 4, 2022
Merged

Migrate segmented cache to maps #3572

merged 1 commit into from
Mar 4, 2022

Conversation

NelsonVides
Copy link
Collaborator

Muclight still takes lists as opts, so in the small tests there's a bit of duplication that will need to be removed when muclight is migrated, so that mam caches and muclight caches test similarly. Otherwise, this does the job.

@mongoose-im

This comment was marked as outdated.

@codecov
Copy link

codecov bot commented Mar 4, 2022

Codecov Report

Merging #3572 (d48e84b) into master (1f31dc4) will decrease coverage by 0.00%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3572      +/-   ##
==========================================
- Coverage   81.01%   81.00%   -0.01%     
==========================================
  Files         424      424              
  Lines       32337    32339       +2     
==========================================
- Hits        26198    26197       -1     
- Misses       6139     6142       +3     
Impacted Files Coverage Δ
src/mongoose_user_cache.erl 97.43% <66.66%> (-2.57%) ⬇️
src/mod_cache_users.erl 95.83% <100.00%> (+0.18%) ⬆️
src/muc_light/mod_muc_light.erl 85.71% <100.00%> (+0.10%) ⬆️
src/muc_light/mod_muc_light_cache.erl 85.71% <100.00%> (ø)
src/inbox/mod_inbox_rdbms_async.erl 63.79% <0.00%> (-3.45%) ⬇️
src/http_upload/mod_http_upload.erl 94.62% <0.00%> (-2.16%) ⬇️
...bal_distrib/mod_global_distrib_hosts_refresher.erl 71.69% <0.00%> (-1.89%) ⬇️
src/pubsub/mod_pubsub.erl 73.13% <0.00%> (-0.06%) ⬇️
src/mod_muc_log.erl 78.11% <0.00%> (ø)
src/mod_roster.erl 78.75% <0.00%> (+0.23%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f31dc4...d48e84b. Read the comment docs.

test/batches_SUITE.erl Outdated Show resolved Hide resolved
@NelsonVides NelsonVides force-pushed the cache_maps branch 2 times, most recently from ddc4ae0 to a47d0e3 Compare March 4, 2022 15:30
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

test/config_parser_SUITE.erl Show resolved Hide resolved
@mongoose-im

This comment was marked as outdated.

@mongoose-im

This comment was marked as outdated.

@mongoose-im

This comment was marked as outdated.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Mar 4, 2022

small_tests_24 / small_tests / d48e84b
Reports root / small


small_tests_23 / small_tests / d48e84b
Reports root / small


dynamic_domains_mysql_redis_24 / mysql_redis / d48e84b
Reports root/ big
OK: 2756 / Failed: 0 / User-skipped: 150 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / d48e84b
Reports root/ big
OK: 2773 / Failed: 0 / User-skipped: 133 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / d48e84b
Reports root/ big
OK: 2773 / Failed: 0 / User-skipped: 133 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / d48e84b
Reports root/ big
OK: 2773 / Failed: 0 / User-skipped: 133 / Auto-skipped: 0


ldap_mnesia_24 / ldap_mnesia / d48e84b
Reports root/ big
OK: 1504 / Failed: 0 / User-skipped: 399 / Auto-skipped: 0


ldap_mnesia_23 / ldap_mnesia / d48e84b
Reports root/ big
OK: 1504 / Failed: 0 / User-skipped: 399 / Auto-skipped: 0


internal_mnesia_24 / internal_mnesia / d48e84b
Reports root/ big
OK: 1545 / Failed: 0 / User-skipped: 358 / Auto-skipped: 0


elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / d48e84b
Reports root/ big
OK: 1846 / Failed: 0 / User-skipped: 366 / Auto-skipped: 0


pgsql_mnesia_23 / pgsql_mnesia / d48e84b
Reports root/ big
OK: 3147 / Failed: 0 / User-skipped: 142 / Auto-skipped: 0


mysql_redis_24 / mysql_redis / d48e84b
Reports root/ big
OK: 3142 / Failed: 0 / User-skipped: 147 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / d48e84b
Reports root/ big
OK: 3147 / Failed: 0 / User-skipped: 142 / Auto-skipped: 0


mssql_mnesia_24 / odbc_mssql_mnesia / d48e84b
Reports root/ big
OK: 3147 / Failed: 0 / User-skipped: 142 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / d48e84b
Reports root/ big
OK: 1692 / Failed: 0 / User-skipped: 365 / Auto-skipped: 0

@chrzaszcz chrzaszcz merged commit 625d726 into master Mar 4, 2022
@chrzaszcz chrzaszcz deleted the cache_maps branch March 4, 2022 19:08
@Premwoik Premwoik added this to the 5.1.0 milestone May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants