Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put push_service_mongoosepush opts in a map with defaults #3577

Merged
merged 1 commit into from
Mar 15, 2022

Conversation

gustawlippa
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Mar 7, 2022

Codecov Report

Merging #3577 (c3bd5ed) into master (35dd227) will increase coverage by 0.03%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3577      +/-   ##
==========================================
+ Coverage   81.01%   81.05%   +0.03%     
==========================================
  Files         424      424              
  Lines       32337    32330       -7     
==========================================
+ Hits        26199    26204       +5     
+ Misses       6138     6126      -12     
Impacted Files Coverage Δ
src/mod_push_service_mongoosepush.erl 85.18% <66.66%> (+1.57%) ⬆️
src/cassandra/mongoose_cassandra.erl 77.77% <0.00%> (-3.71%) ⬇️
src/inbox/mod_inbox_rdbms_async.erl 65.51% <0.00%> (-3.45%) ⬇️
src/cassandra/mongoose_cassandra_worker.erl 65.72% <0.00%> (-2.82%) ⬇️
src/logger/mongoose_log_filter.erl 78.08% <0.00%> (-1.37%) ⬇️
src/ejabberd_c2s.erl 88.67% <0.00%> (-0.30%) ⬇️
src/mod_muc.erl 74.77% <0.00%> (-0.23%) ⬇️
src/pubsub/mod_pubsub.erl 73.19% <0.00%> (-0.12%) ⬇️
src/mod_muc_log.erl 78.11% <0.00%> (ø)
src/pubsub/mod_pubsub_db_rdbms.erl 95.34% <0.00%> (+0.25%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35dd227...c3bd5ed. Read the comment docs.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Mar 7, 2022

small_tests_24 / small_tests / c3bd5ed
Reports root / small


small_tests_23 / small_tests / c3bd5ed
Reports root / small


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / c3bd5ed
Reports root/ big
OK: 2773 / Failed: 0 / User-skipped: 133 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / c3bd5ed
Reports root/ big
OK: 2773 / Failed: 0 / User-skipped: 133 / Auto-skipped: 0


ldap_mnesia_23 / ldap_mnesia / c3bd5ed
Reports root/ big
OK: 1504 / Failed: 0 / User-skipped: 399 / Auto-skipped: 0


ldap_mnesia_24 / ldap_mnesia / c3bd5ed
Reports root/ big
OK: 1504 / Failed: 0 / User-skipped: 399 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / c3bd5ed
Reports root/ big
OK: 2773 / Failed: 0 / User-skipped: 133 / Auto-skipped: 0


internal_mnesia_24 / internal_mnesia / c3bd5ed
Reports root/ big
OK: 1545 / Failed: 0 / User-skipped: 358 / Auto-skipped: 0


dynamic_domains_mysql_redis_24 / mysql_redis / c3bd5ed
Reports root/ big
OK: 2756 / Failed: 0 / User-skipped: 150 / Auto-skipped: 0


pgsql_mnesia_23 / pgsql_mnesia / c3bd5ed
Reports root/ big
OK: 3147 / Failed: 0 / User-skipped: 142 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / c3bd5ed
Reports root/ big
OK: 3147 / Failed: 0 / User-skipped: 142 / Auto-skipped: 0


elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / c3bd5ed
Reports root/ big
OK: 1846 / Failed: 0 / User-skipped: 366 / Auto-skipped: 0


mysql_redis_24 / mysql_redis / c3bd5ed
Reports root/ big
OK: 3142 / Failed: 0 / User-skipped: 147 / Auto-skipped: 0


mssql_mnesia_24 / odbc_mssql_mnesia / c3bd5ed
Reports root/ big
OK: 3147 / Failed: 0 / User-skipped: 142 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / c3bd5ed
Reports root/ big
OK: 1692 / Failed: 0 / User-skipped: 365 / Auto-skipped: 0

@gustawlippa gustawlippa marked this pull request as ready for review March 7, 2022 13:56
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@chrzaszcz chrzaszcz merged commit 3a875ec into master Mar 15, 2022
@chrzaszcz chrzaszcz deleted the mod_push_service_mongoosepush-map-config branch March 15, 2022 16:20
@Premwoik Premwoik added this to the 5.1.0 milestone May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants