Inbox/extend queries #3597
Inbox/extend queries #3597
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Codecov Report
@@ Coverage Diff @@
## inbox/small_refactor #3597 +/- ##
========================================================
+ Coverage 80.82% 80.86% +0.04%
========================================================
Files 426 426
Lines 32378 32394 +16
========================================================
+ Hits 26169 26197 +28
+ Misses 6209 6197 -12
Continue to review full report at Codecov.
|
NelsonVides
force-pushed
the
inbox/small_refactor
branch
from
82585d8
to
86285b9
Compare
This is useful for example when a conversation is entered, through some link, to any point in the far past of the conversation, instead of at the bottom. The inbox might be desired in a two-column layout, like in many phone apps when displayed horizontally, but if loading from MAM at some point far in the past, in a conversation whose inbox entry wasn't already loaded (old conversation, pagination), building the right inbox snippet would take many round-trips.
NelsonVides
force-pushed
the
inbox/extend_queries
branch
from
182088f
to
de8d0c9
Compare
|
small_tests_24 / small_tests / de8d0c9 small_tests_23 / small_tests / de8d0c9 dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / de8d0c9 dynamic_domains_mysql_redis_24 / mysql_redis / de8d0c9 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / de8d0c9 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / de8d0c9 ldap_mnesia_23 / ldap_mnesia / de8d0c9 ldap_mnesia_24 / ldap_mnesia / de8d0c9 internal_mnesia_24 / internal_mnesia / de8d0c9 pgsql_mnesia_23 / pgsql_mnesia / de8d0c9 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / de8d0c9 mysql_redis_24 / mysql_redis / de8d0c9 pgsql_mnesia_24 / pgsql_mnesia / de8d0c9 mssql_mnesia_24 / odbc_mssql_mnesia / de8d0c9 service_mongoose_system_metrics_SUITE:system_metrics_are_reported_to_configurable_google_analytics{error,
{{assertEqual,
[{module,service_mongoose_system_metrics_SUITE},
{line,428},
{expression,"ActualTrackingIds"},
{expected,[<<"UA-151671255-1">>,<<"UA-EXTRA-TRACKING-ID">>]},
{value,[<<"UA-151671255-1">>]}]},
[{service_mongoose_system_metrics_SUITE,
events_are_reported_to_tracking_ids,1,
[{file,
"/home/circleci/project/big_tests/tests/service_mongoose_system_metrics_SUITE.erl"},
{line,428}]},
{service_mongoose_system_metrics_SUITE,
system_metrics_are_reported_to_configurable_google_analytics,1,
[{file,
"/home/circleci/project/big_tests/tests/service_mongoose_system_metrics_SUITE.erl"},
{line,230}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}}riak_mnesia_24 / riak_mnesia / de8d0c9 mssql_mnesia_24 / odbc_mssql_mnesia / de8d0c9 |
| @@ -167,15 +173,26 @@ clear_inbox(HostType, LUser, LServer) -> | |||
| Res = execute_delete(HostType, LUser, LServer), | |||
| check_result(Res). | |||
|
|
|||
| -spec get_entry_properties(HosType :: mongooseim:host_type(), | |||
| -spec get_full_entry(HostType :: mongooseim:host_type(), | |||
| InboxEntryKey :: mod_inbox:entry_key()) -> | |||
There was a problem hiding this comment.
| InboxEntryKey :: mod_inbox:entry_key()) -> | |
| InboxEntryKey :: mod_inbox:entry_key()) -> |
This is useful for example when a conversation is entered, through some
link, to any point in the far past of the conversation, instead of at
the bottom. The inbox might be desired in a two-column layout, like in
many phone apps when displayed horizontally, but if loading from MAM at
some point far in the past, in a conversation whose inbox entry wasn't
already loaded (old conversation, pagination), building the right inbox
snippet would take many round-trips.