Put mod_jingle_sip options in a map with defaults #3600
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3600 +/- ##
==========================================
- Coverage 80.89% 80.89% -0.01%
==========================================
Files 426 426
Lines 32250 32252 +2
==========================================
Hits 26090 26090
- Misses 6160 6162 +2
Continue to review full report at Codecov.
|
|
small_tests_24 / small_tests / 6959d03 small_tests_23 / small_tests / 6959d03 dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 6959d03 dynamic_domains_mysql_redis_24 / mysql_redis / 6959d03 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 6959d03 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 6959d03 ldap_mnesia_24 / ldap_mnesia / 6959d03 ldap_mnesia_23 / ldap_mnesia / 6959d03 internal_mnesia_24 / internal_mnesia / 6959d03 pgsql_mnesia_23 / pgsql_mnesia / 6959d03 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 6959d03 pgsql_mnesia_24 / pgsql_mnesia / 6959d03 mysql_redis_24 / mysql_redis / 6959d03 mssql_mnesia_24 / odbc_mssql_mnesia / 6959d03 riak_mnesia_24 / riak_mnesia / 6959d03 |
|
small_tests_24 / small_tests / fa30cf8 small_tests_23 / small_tests / fa30cf8 dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / fa30cf8 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / fa30cf8 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / fa30cf8 ldap_mnesia_24 / ldap_mnesia / fa30cf8 ldap_mnesia_23 / ldap_mnesia / fa30cf8 internal_mnesia_24 / internal_mnesia / fa30cf8 pgsql_mnesia_23 / pgsql_mnesia / fa30cf8 pgsql_mnesia_24 / pgsql_mnesia / fa30cf8 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / fa30cf8 mssql_mnesia_24 / odbc_mssql_mnesia / fa30cf8 mysql_redis_24 / mysql_redis / fa30cf8 riak_mnesia_24 / riak_mnesia / fa30cf8 |
gustawlippa
force-pushed
the
mod_jingle_sip-map-config
branch
2 times, most recently
from
188642d
to
4837817
Compare
|
small_tests_24 / small_tests / 188642d small_tests_23 / small_tests / 188642d dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 188642d dynamic_domains_mysql_redis_24 / mysql_redis / 188642d dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 188642d ldap_mnesia_23 / ldap_mnesia / 188642d dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 188642d ldap_mnesia_24 / ldap_mnesia / 188642d internal_mnesia_24 / internal_mnesia / 188642d elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 188642d pgsql_mnesia_24 / pgsql_mnesia / 188642d pgsql_mnesia_23 / pgsql_mnesia / 188642d mysql_redis_24 / mysql_redis / 188642d mssql_mnesia_24 / odbc_mssql_mnesia / 188642d riak_mnesia_24 / riak_mnesia / 188642d |
This comment was marked as outdated.
This comment was marked as outdated.
gustawlippa
force-pushed
the
mod_jingle_sip-map-config
branch
from
4837817
to
bb5a3d5
Compare
|
small_tests_24 / small_tests / bb5a3d5 small_tests_23 / small_tests / bb5a3d5 dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / bb5a3d5 dynamic_domains_mysql_redis_24 / mysql_redis / bb5a3d5 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / bb5a3d5 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / bb5a3d5 ldap_mnesia_23 / ldap_mnesia / bb5a3d5 ldap_mnesia_24 / ldap_mnesia / bb5a3d5 internal_mnesia_24 / internal_mnesia / bb5a3d5 pgsql_mnesia_23 / pgsql_mnesia / bb5a3d5 pgsql_mnesia_24 / pgsql_mnesia / bb5a3d5 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / bb5a3d5 mysql_redis_24 / mysql_redis / bb5a3d5 mssql_mnesia_24 / odbc_mssql_mnesia / bb5a3d5 riak_mnesia_24 / riak_mnesia / bb5a3d5 |
Co-authored-by: Paweł Chrząszcz <pawel.chrzaszcz@erlang-solutions.com>
|
small_tests_24 / small_tests / c0f8f92 small_tests_23 / small_tests / c0f8f92 dynamic_domains_mysql_redis_24 / mysql_redis / c0f8f92 dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / c0f8f92 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / c0f8f92 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / c0f8f92 ldap_mnesia_23 / ldap_mnesia / c0f8f92 ldap_mnesia_24 / ldap_mnesia / c0f8f92 internal_mnesia_24 / internal_mnesia / c0f8f92 pgsql_mnesia_24 / pgsql_mnesia / c0f8f92 mysql_redis_24 / mysql_redis / c0f8f92 pgsql_mnesia_23 / pgsql_mnesia / c0f8f92 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / c0f8f92 mssql_mnesia_24 / odbc_mssql_mnesia / c0f8f92 riak_mnesia_24 / riak_mnesia / c0f8f92 small_tests_24 / small_tests / c0f8f92 small_tests_23 / small_tests / c0f8f92 dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / c0f8f92 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / c0f8f92 dynamic_domains_mysql_redis_24 / mysql_redis / c0f8f92 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / c0f8f92 ldap_mnesia_23 / ldap_mnesia / c0f8f92 ldap_mnesia_24 / ldap_mnesia / c0f8f92 internal_mnesia_24 / internal_mnesia / c0f8f92 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / c0f8f92 pgsql_mnesia_24 / pgsql_mnesia / c0f8f92 pgsql_mnesia_23 / pgsql_mnesia / c0f8f92 mysql_redis_24 / mysql_redis / c0f8f92 mssql_mnesia_24 / odbc_mssql_mnesia / c0f8f92 muc_SUITE:hibernation:hibernated_room_can_be_queried_for_archive{error,{{assertion_failed,assert,is_groupchat_message,
[<<"Restorable message">>],
undefined,"undefined"},
[{escalus_new_assert,assert_true,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{muc_SUITE,wait_for_mam_result,3,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4383}]},
{muc_SUITE,'-hibernated_room_can_be_queried_for_archive/1-fun-0-',3,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4124}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{muc_SUITE,hibernated_room_can_be_queried_for_archive,1,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4120}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}}riak_mnesia_24 / riak_mnesia / c0f8f92 |
|
small_tests_24 / small_tests / e17c1b6 small_tests_23 / small_tests / e17c1b6 dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / e17c1b6 dynamic_domains_mysql_redis_24 / mysql_redis / e17c1b6 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / e17c1b6 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / e17c1b6 ldap_mnesia_23 / ldap_mnesia / e17c1b6 ldap_mnesia_24 / ldap_mnesia / e17c1b6 internal_mnesia_24 / internal_mnesia / e17c1b6 pgsql_mnesia_23 / pgsql_mnesia / e17c1b6 bosh_SUITE:essential_https:accept_higher_hold_value{error,
{{assertEqual,
[{module,bosh_SUITE},
{line,251},
{expression,"get_bosh_sessions ( )"},
{expected,[]},
{value,
[{bosh_session,<<"082b7591884537cdc67f8be55e35ad20da6468b2">>,
<8576.6962.0>}]}]},
[{bosh_SUITE,'-accept_higher_hold_value/1-fun-2-',0,
[{file,"/home/circleci/project/big_tests/tests/bosh_SUITE.erl"},
{line,251}]},
{bosh_SUITE,accept_higher_hold_value,1,
[{file,"/home/circleci/project/big_tests/tests/bosh_SUITE.erl"},
{line,251}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1754}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1263}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1195}]}]}}pgsql_mnesia_24 / pgsql_mnesia / e17c1b6 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / e17c1b6 mssql_mnesia_24 / odbc_mssql_mnesia / e17c1b6 mysql_redis_24 / mysql_redis / e17c1b6 riak_mnesia_24 / riak_mnesia / e17c1b6 pgsql_mnesia_23 / pgsql_mnesia / e17c1b6 |
Put options in a map with defaults.
Added a possibility to configure options that were used in the code, and documented these new options. However, these are not tested yet, and from what I understand, without host types the username-phone mapping won't work great.