Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder MAM's filter_local_packet order #3623

Merged
merged 1 commit into from
Apr 4, 2022
Merged

Conversation

NelsonVides
Copy link
Collaborator

This way, MAM's executed earlier, and a MAM-id is assigned earlier, so
that it can be used elsewhere in subsequent hooks, like inbox.

This way, MAM's executed earlier, and a MAM-id is assigned earlier, so
that it can be used elsewhere in subsequent hooks.
@codecov
Copy link

codecov bot commented Apr 3, 2022

Codecov Report

Merging #3623 (90e3b31) into master (a4606d5) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3623   +/-   ##
=======================================
  Coverage   80.95%   80.95%           
=======================================
  Files         426      426           
  Lines       32127    32127           
=======================================
+ Hits        26007    26010    +3     
+ Misses       6120     6117    -3     
Impacted Files Coverage Δ
src/mam/mod_mam.erl 89.11% <ø> (ø)
..._distrib/mod_global_distrib_outgoing_conns_sup.erl 80.00% <0.00%> (-8.00%) ⬇️
src/elasticsearch/mongoose_elasticsearch.erl 76.92% <0.00%> (-7.70%) ⬇️
src/mam/mod_mam_elasticsearch_arch.erl 85.08% <0.00%> (-1.76%) ⬇️
src/inbox/mod_inbox_rdbms_async.erl 68.11% <0.00%> (-1.45%) ⬇️
src/logger/mongoose_log_filter.erl 78.08% <0.00%> (-1.37%) ⬇️
src/pubsub/mod_pubsub.erl 73.01% <0.00%> (-0.13%) ⬇️
src/mod_muc_log.erl 63.21% <0.00%> (ø)
src/pubsub/mod_pubsub_db_mnesia.erl 92.85% <0.00%> (+0.42%) ⬆️
src/rdbms/mongoose_rdbms.erl 63.63% <0.00%> (+1.09%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4606d5...90e3b31. Read the comment docs.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Apr 3, 2022

small_tests_24 / small_tests / 90e3b31
Reports root / small


small_tests_23 / small_tests / 90e3b31
Reports root / small


dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 90e3b31
Reports root/ big
OK: 2858 / Failed: 0 / User-skipped: 133 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 90e3b31
Reports root/ big
OK: 2858 / Failed: 0 / User-skipped: 133 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 90e3b31
Reports root/ big
OK: 2858 / Failed: 0 / User-skipped: 133 / Auto-skipped: 0


dynamic_domains_mysql_redis_24 / mysql_redis / 90e3b31
Reports root/ big
OK: 2841 / Failed: 0 / User-skipped: 150 / Auto-skipped: 0


ldap_mnesia_23 / ldap_mnesia / 90e3b31
Reports root/ big
OK: 1506 / Failed: 0 / User-skipped: 401 / Auto-skipped: 0


ldap_mnesia_24 / ldap_mnesia / 90e3b31
Reports root/ big
OK: 1506 / Failed: 0 / User-skipped: 401 / Auto-skipped: 0


internal_mnesia_24 / internal_mnesia / 90e3b31
Reports root/ big
OK: 1547 / Failed: 0 / User-skipped: 360 / Auto-skipped: 0


elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 90e3b31
Reports root/ big
OK: 1854 / Failed: 0 / User-skipped: 368 / Auto-skipped: 0


pgsql_mnesia_23 / pgsql_mnesia / 90e3b31
Reports root/ big
OK: 3232 / Failed: 0 / User-skipped: 142 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 90e3b31
Reports root/ big
OK: 3232 / Failed: 0 / User-skipped: 142 / Auto-skipped: 0


mysql_redis_24 / mysql_redis / 90e3b31
Reports root/ big
OK: 3227 / Failed: 0 / User-skipped: 147 / Auto-skipped: 0


mssql_mnesia_24 / odbc_mssql_mnesia / 90e3b31
Reports root/ big
OK: 3232 / Failed: 0 / User-skipped: 142 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / 90e3b31
Reports root/ big
OK: 1697 / Failed: 0 / User-skipped: 367 / Auto-skipped: 0

Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@chrzaszcz chrzaszcz merged commit c9c8717 into master Apr 4, 2022
@chrzaszcz chrzaszcz deleted the filter_local_packet_order branch April 4, 2022 06:01
@Premwoik Premwoik added this to the 5.1.0 milestone May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants