-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GraphQL - Use enum in cowboy handler configuration and provide test #3648
GraphQL - Use enum in cowboy handler configuration and provide test #3648
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
f89a200
to
301af23
Compare
Codecov Report
@@ Coverage Diff @@
## feature/graphql #3648 +/- ##
===================================================
- Coverage 81.85% 81.83% -0.03%
===================================================
Files 480 480
Lines 33342 33342
===================================================
- Hits 27292 27284 -8
- Misses 6050 6058 +8
Continue to review full report at Codecov.
|
small_tests_24 / small_tests / 301af23 small_tests_23 / small_tests / 301af23 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 301af23 dynamic_domains_mysql_redis_24 / mysql_redis / 301af23 dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 301af23 ldap_mnesia_24 / ldap_mnesia / 301af23 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 301af23 ldap_mnesia_23 / ldap_mnesia / 301af23 internal_mnesia_24 / internal_mnesia / 301af23 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 301af23 pgsql_mnesia_24 / pgsql_mnesia / 301af23 mysql_redis_24 / mysql_redis / 301af23 pgsql_mnesia_23 / pgsql_mnesia / 301af23 mssql_mnesia_24 / odbc_mssql_mnesia / 301af23 pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription{error,
{{badmatch,
[{xmlel,<<"message">>,
[{<<"from">>,
<<"alice_unsubscribe_after_presence_unsubscription_2092@localhost">>},
{<<"to">>,
<<"bob_unsubscribe_after_presence_unsubscription_2092@localhost/res1">>},
{<<"type">>,<<"headline">>}],
[{xmlel,<<"event">>,
[{<<"xmlns">>,
<<"http://jabber.org/protocol/pubsub#event">>}],
[{xmlel,<<"items">>,
[{<<"node">>,<<"lHYoZRr7RV7GMkYiv1yKwQ==">>}],
[{xmlel,<<"item">>,
[{<<"id">>,<<"salmon">>}],
[{xmlel,<<"entry">>,
[{<<"xmlns">>,
<<"http://www.w3.org/2005/Atom">>}],
[]}]}]}]},
{xmlel,<<"headers">>,
[{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
[]}]}]},
[{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
[{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
{line,384}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} riak_mnesia_24 / riak_mnesia / 301af23 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
This PR addresses comments from Paweł in the PR about merging HTTP handlers config rework.
#3646 (comment)
#3646 (comment)