Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQL - Use enum in cowboy handler configuration and provide test #3648

Merged
merged 1 commit into from
May 25, 2022

Conversation

Premwoik
Copy link
Contributor

This PR addresses comments from Paweł in the PR about merging HTTP handlers config rework.

#3646 (comment)

#3646 (comment)

@mongoose-im

This comment was marked as outdated.

@Premwoik Premwoik force-pushed the graphql/use-enum-in-handler-config branch from f89a200 to 301af23 Compare May 17, 2022 07:37
@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #3648 (301af23) into feature/graphql (bfc1ee0) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@                 Coverage Diff                 @@
##           feature/graphql    #3648      +/-   ##
===================================================
- Coverage            81.85%   81.83%   -0.03%     
===================================================
  Files                  480      480              
  Lines                33342    33342              
===================================================
- Hits                 27292    27284       -8     
- Misses                6050     6058       +8     
Impacted Files Coverage Δ
src/graphql/mongoose_graphql_cowboy_handler.erl 94.18% <100.00%> (+1.16%) ⬆️
src/cassandra/mongoose_cassandra.erl 77.77% <0.00%> (-3.71%) ⬇️
src/pubsub/nodetree_tree.erl 87.87% <0.00%> (-3.04%) ⬇️
src/cassandra/mongoose_cassandra_worker.erl 65.72% <0.00%> (-2.82%) ⬇️
src/pubsub/node_flat.erl 74.21% <0.00%> (-0.40%) ⬇️
src/pubsub/mod_pubsub_db_rdbms.erl 95.34% <0.00%> (-0.26%) ⬇️
src/mod_muc_room.erl 78.53% <0.00%> (-0.17%) ⬇️
src/ejabberd_c2s.erl 88.71% <0.00%> (-0.08%) ⬇️
src/mod_muc_log.erl 63.21% <0.00%> (ø)
src/pubsub/node_pep.erl 79.62% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfc1ee0...301af23. Read the comment docs.

@mongoose-im
Copy link
Collaborator

mongoose-im commented May 17, 2022

small_tests_24 / small_tests / 301af23
Reports root / small


small_tests_23 / small_tests / 301af23
Reports root / small


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 301af23
Reports root/ big
OK: 3086 / Failed: 0 / User-skipped: 133 / Auto-skipped: 0


dynamic_domains_mysql_redis_24 / mysql_redis / 301af23
Reports root/ big
OK: 3069 / Failed: 0 / User-skipped: 150 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 301af23
Reports root/ big
OK: 3086 / Failed: 0 / User-skipped: 133 / Auto-skipped: 0


ldap_mnesia_24 / ldap_mnesia / 301af23
Reports root/ big
OK: 1689 / Failed: 0 / User-skipped: 444 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 301af23
Reports root/ big
OK: 3086 / Failed: 0 / User-skipped: 133 / Auto-skipped: 0


ldap_mnesia_23 / ldap_mnesia / 301af23
Reports root/ big
OK: 1689 / Failed: 0 / User-skipped: 444 / Auto-skipped: 0


internal_mnesia_24 / internal_mnesia / 301af23
Reports root/ big
OK: 1735 / Failed: 0 / User-skipped: 398 / Auto-skipped: 0


elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 301af23
Reports root/ big
OK: 2049 / Failed: 0 / User-skipped: 399 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 301af23
Reports root/ big
OK: 3460 / Failed: 0 / User-skipped: 142 / Auto-skipped: 0


mysql_redis_24 / mysql_redis / 301af23
Reports root/ big
OK: 3455 / Failed: 0 / User-skipped: 147 / Auto-skipped: 0


pgsql_mnesia_23 / pgsql_mnesia / 301af23
Reports root/ big
OK: 3460 / Failed: 0 / User-skipped: 142 / Auto-skipped: 0


mssql_mnesia_24 / odbc_mssql_mnesia / 301af23
Reports root/ big
OK: 3471 / Failed: 1 / User-skipped: 142 / Auto-skipped: 0

pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription
{error,
  {{badmatch,
     [{xmlel,<<"message">>,
        [{<<"from">>,
        <<"alice_unsubscribe_after_presence_unsubscription_2092@localhost">>},
         {<<"to">>,
        <<"bob_unsubscribe_after_presence_unsubscription_2092@localhost/res1">>},
         {<<"type">>,<<"headline">>}],
        [{xmlel,<<"event">>,
           [{<<"xmlns">>,
           <<"http://jabber.org/protocol/pubsub#event">>}],
           [{xmlel,<<"items">>,
            [{<<"node">>,<<"lHYoZRr7RV7GMkYiv1yKwQ==">>}],
            [{xmlel,<<"item">>,
               [{<<"id">>,<<"salmon">>}],
               [{xmlel,<<"entry">>,
                  [{<<"xmlns">>,
                  <<"http://www.w3.org/2005/Atom">>}],
                  []}]}]}]},
         {xmlel,<<"headers">>,
           [{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
           []}]}]},
   [{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
      [{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
       {line,384}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1292}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1224}]}]}}

Report log


riak_mnesia_24 / riak_mnesia / 301af23
Reports root/ big
OK: 1896 / Failed: 0 / User-skipped: 394 / Auto-skipped: 0

@Premwoik Premwoik marked this pull request as ready for review May 17, 2022 08:27
@Premwoik Premwoik requested a review from chrzaszcz May 17, 2022 08:27
Copy link
Contributor

@JanuszJakubiec JanuszJakubiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@arcusfelis arcusfelis merged commit 66f476b into feature/graphql May 25, 2022
@arcusfelis arcusfelis deleted the graphql/use-enum-in-handler-config branch May 25, 2022 10:34
@chrzaszcz chrzaszcz added this to the 6.0.0 milestone Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants