Mam jid rfc trust

[NelsonVides]

It's just like mam_jid_rfc, but uses jid:from_binary_noprep/1 for decoding. If only MIM inserted jids in this field, and we know that MIM only inserted already normalised jids, when reading we only need to build the jid record, but not normalize (stringprep) all its fields. Can save some (tiny bit of) time.

[codecov]

Codecov Report

Merging #3682 (330bd81) into master (330bd81) will not change coverage.
The diff coverage is n/a.

❗ Current head 330bd81 differs from pull request most recent head 579538f. Consider uploading reports for the commit 579538f to get more accurate results

@@           Coverage Diff           @@
##           master    #3682   +/-   ##
=======================================
  Coverage   81.10%   81.10%           
=======================================
  Files         433      433           
  Lines       31882    31882           
=======================================
  Hits        25858    25858           
  Misses       6024     6024           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 330bd81...579538f. Read the comment docs.

[mongoose-im]

small_tests_24 / small_tests / 579538f
Reports root / small

---

small_tests_25 / small_tests / 579538f
Reports root / small

---

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 579538f
Reports root/ big
OK: 2825 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

---

dynamic_domains_mysql_redis_25 / mysql_redis / 579538f
Reports root/ big
OK: 2808 / Failed: 0 / User-skipped: 105 / Auto-skipped: 0

---

ldap_mnesia_24 / ldap_mnesia / 579538f
Reports root/ big
OK: 1508 / Failed: 0 / User-skipped: 401 / Auto-skipped: 0

---

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 579538f
Reports root/ big
OK: 2825 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

---

ldap_mnesia_25 / ldap_mnesia / 579538f
Reports root/ big
OK: 1508 / Failed: 0 / User-skipped: 401 / Auto-skipped: 0

---

internal_mnesia_25 / internal_mnesia / 579538f
Reports root/ big
OK: 1593 / Failed: 0 / User-skipped: 316 / Auto-skipped: 0

---

pgsql_mnesia_24 / pgsql_mnesia / 579538f
Reports root/ big
OK: 3199 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

---

pgsql_mnesia_25 / pgsql_mnesia / 579538f
Reports root/ big
OK: 3199 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

---

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 579538f
Reports root/ big
OK: 1876 / Failed: 0 / User-skipped: 324 / Auto-skipped: 0

---

mysql_redis_25 / mysql_redis / 579538f
Reports root/ big
OK: 3194 / Failed: 0 / User-skipped: 102 / Auto-skipped: 0

---

mssql_mnesia_25 / odbc_mssql_mnesia / 579538f
Reports root/ big
OK: 3211 / Failed: 1 / User-skipped: 97 / Auto-skipped: 0

muc_SUITE:hibernation:hibernated_room_can_be_queried_for_archive

{error,{{assertion_failed,assert,is_groupchat_message,
              [<<"Restorable message">>],
              undefined,"undefined"},
    [{escalus_new_assert,assert_true,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
                {line,84}]},
     {muc_SUITE,wait_for_mam_result,3,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4383}]},
     {muc_SUITE,'-hibernated_room_can_be_queried_for_archive/1-fun-0-',3,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4124}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {muc_SUITE,hibernated_room_can_be_queried_for_archive,1,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4120}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1223}]}]}}

Report log

---

riak_mnesia_24 / riak_mnesia / 579538f
Reports root/ big
OK: 1731 / Failed: 0 / User-skipped: 323 / Auto-skipped: 0

[chrzaszcz]

It all looks good, but a simple question: why not call it mam_jid_rfc_noprep to make it obvious?

[NelsonVides]

It all looks good, but a simple question: why not call it mam_jid_rfc_noprep to make it obvious?

Dunno, I thought of trust just because the jids would need to be trusted they were already normalised, but no real reason here. Wanna change the name? :)