Fix muc persistent room #3707
Fix muc persistent room #3707
Conversation
When the rooms are persistent by default, creation of an instant room should result in saving it into the DB. This was not covered by tests - and it was not working. Also: - Remove reduntant empty lines - Remove test repetition
This was a bug - the room was not saved. Also: minor refactoring
|
small_tests_24 / small_tests / 14afdb3 small_tests_25 / small_tests / 14afdb3 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 14afdb3 ldap_mnesia_24 / ldap_mnesia / 14afdb3 dynamic_domains_mysql_redis_25 / mysql_redis / 14afdb3 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 14afdb3 ldap_mnesia_25 / ldap_mnesia / 14afdb3 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 14afdb3 muc_SUITE:register:user_unregisters_nick{error,
{{assertion_failed,assert,is_iq_result,
[{xmlel,<<"iq">>,
[{<<"type">>,<<"set">>},
{<<"id">>,<<"8dc3b60c0815f90d6c25fcdae42e9031">>},
{<<"to">>,<<"groupchats.domain.example.com">>}],
[{xmlel,<<"query">>,
[{<<"xmlns">>,<<"jabber:iq:register">>}],
[{xmlel,<<"x">>,
[{<<"xmlns">>,<<"jabber:x:data">>},
{<<"type">>,<<"submit">>}],
[{xmlel,<<"field">>,
[{<<"type">>,<<"hidden">>},
{<<"var">>,<<"FORM_TYPE">>}],
[{xmlel,<<"value">>,[],
[{xmlcdata,<<"jabber:iq:register">>}]}]},
{xmlel,<<"field">>,
[{<<"type">>,<<"text-single">>},
{<<"var">>,<<"nick">>}],
[{xmlel,<<"value">>,[],
[{xmlcdata,
<<"thirdwitch1room-c19e66ce63">>}]}]}]}]}]}],
{xmlel,<<"iq">>,
[{<<"from">>,<<"groupchats.domain.example.com">>},
{<<"to">>,
<<"alice_user_unregisters_nick_1982@domain.example.com/res1">>},
{<<"type">>,<<"error">>},
{<<"xml:lang">>,<<"en">>},
{<<"id">>,<<"8dc3b60c0815f90d6c25fcdae42e9031">>}],
[{xmlel,<<"query">>,
[{<<"xmlns">>,<<"jabber:iq:register">>}],
[{xmlel,<<"x">>,
[{<<"xmlns">>,<<"jabber:x:data">>},
{<<"type">>,<<"submit">>}],
[{xmlel,<<"field">>,
[{<<"type">>,<<"hidden">>},
{<<"var">...internal_mnesia_25 / internal_mnesia / 14afdb3 pgsql_mnesia_24 / pgsql_mnesia / 14afdb3 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 14afdb3 pgsql_mnesia_25 / pgsql_mnesia / 14afdb3 riak_mnesia_24 / riak_mnesia / 14afdb3 mysql_redis_25 / mysql_redis / 14afdb3 mssql_mnesia_25 / odbc_mssql_mnesia / 14afdb3 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 14afdb3 |
Codecov Report
@@ Coverage Diff @@
## master #3707 +/- ##
==========================================
+ Coverage 82.10% 82.13% +0.02%
==========================================
Files 513 513
Lines 33644 33643 -1
==========================================
+ Hits 27624 27632 +8
+ Misses 6020 6011 -9
Continue to review full report at Codecov.
|
This PR addresses #3705: an instant persistent room was not stored in the DB.
Added missing test, and fixed the bug.