Use wpool for notify_loop in mod_pubsub #3726

arcusfelis · 2022-08-09T14:00:15Z

This PR addresses MIM-1687.

Proposed changes include:

A wpool
Config options
We use consistent hashing to find a worker

mongoose-im · 2022-08-09T14:08:33Z

small_tests_24 / small_tests / bfc2e1b
Reports root / small

small_tests_25 / small_tests / bfc2e1b
Reports root / small

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / bfc2e1b
Reports root/ big
OK: 3340 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

ldap_mnesia_24 / ldap_mnesia / bfc2e1b
Reports root/ big
OK: 1897 / Failed: 0 / User-skipped: 513 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / bfc2e1b
Reports root/ big
OK: 3323 / Failed: 0 / User-skipped: 105 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / bfc2e1b
Reports root/ big
OK: 1897 / Failed: 0 / User-skipped: 513 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / bfc2e1b
Reports root/ big
OK: 3340 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / bfc2e1b
Reports root/ big
OK: 3348 / Failed: 1 / User-skipped: 88 / Auto-skipped: 0

disco_and_caps_SUITE:disco_with_caps:user_can_query_friend_resources

{error,{{assertion_failed,assert_many,false,[is_roster_set],[],[]},
    [{escalus_new_assert,assert_true,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
                {line,84}]},
     {escalus_story,'-make_all_clients_friends/1-fun-0-',2,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,108}]},
     {escalus_utils,'-each_with_index/3-fun-0-',3,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
             {line,87}]},
     {lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
     {escalus_utils,'-each_with_index/3-fun-0-',3,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
             {line,87}]},
     {lists,foldl,3,[{file,"lists.erl"},{line,1350}]},
     {escalus_utils,distinct_pairs,2,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
             {line,60}]},
     {escalus_story,make_all_clients_friends,1,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,106}]}]}}

Report log

pgsql_mnesia_24 / pgsql_mnesia / bfc2e1b
Reports root/ big
OK: 3714 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / bfc2e1b
Reports root/ big
OK: 2018 / Failed: 0 / User-skipped: 392 / Auto-skipped: 0

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / bfc2e1b
Reports root/ big
OK: 2314 / Failed: 0 / User-skipped: 387 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / bfc2e1b
Reports root/ big
OK: 3714 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / bfc2e1b
Reports root/ big
OK: 3709 / Failed: 0 / User-skipped: 102 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / bfc2e1b
Reports root/ big
OK: 3725 / Failed: 1 / User-skipped: 97 / Auto-skipped: 0

pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription

{error,{{assertion_failed,assert_many,false,[is_presence],[],[]},
    [{escalus_new_assert,assert_true,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
                {line,84}]},
     {escalus_story,'-make_all_clients_friends/1-fun-0-',2,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,109}]},
     {escalus_utils,'-each_with_index/3-fun-0-',3,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
             {line,87}]},
     {lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
     {escalus_utils,'-each_with_index/3-fun-0-',3,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
             {line,87}]},
     {lists,foldl,3,[{file,"lists.erl"},{line,1350}]},
     {escalus_utils,distinct_pairs,2,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
             {line,60}]},
     {escalus_story,make_all_clients_friends,1,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,106}]}]}}

Report log

riak_mnesia_24 / riak_mnesia / bfc2e1b
Reports root/ big
OK: 2175 / Failed: 0 / User-skipped: 380 / Auto-skipped: 0

codecov · 2022-08-09T14:18:18Z

Codecov Report

Merging #3726 (8a4f083) into master (3b4b32e) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3726      +/-   ##
==========================================
- Coverage   82.24%   82.22%   -0.02%     
==========================================
  Files         523      523              
  Lines       33801    33794       -7     
==========================================
- Hits        27799    27787      -12     
- Misses       6002     6007       +5

Impacted Files	Coverage Δ
src/pubsub/mod_pubsub.erl	`73.18% <100.00%> (-0.18%)`	⬇️
src/mam/mod_mam_muc_rdbms_arch_async.erl	`82.85% <0.00%> (-2.86%)`	⬇️
src/mod_roster_riak.erl	`96.92% <0.00%> (-1.54%)`	⬇️
src/mod_roster.erl	`78.94% <0.00%> (-0.48%)`	⬇️
src/ejabberd_c2s.erl	`88.93% <0.00%> (-0.30%)`	⬇️
src/mod_muc_room.erl	`78.51% <0.00%> (-0.18%)`	⬇️
src/mod_muc_log.erl	`62.82% <0.00%> (ø)`
src/pubsub/mod_pubsub_db_rdbms.erl	`95.34% <0.00%> (+0.25%)`	⬆️
src/logger/mongoose_log_filter.erl	`79.45% <0.00%> (+1.36%)`	⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

mongoose-im · 2022-08-09T16:12:48Z

small_tests_24 / small_tests / 772f587
Reports root / small

small_tests_25 / small_tests / 772f587
Reports root / small

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 772f587
Reports root/ big
OK: 3340 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

ldap_mnesia_24 / ldap_mnesia / 772f587
Reports root/ big
OK: 1897 / Failed: 0 / User-skipped: 513 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 772f587
Reports root/ big
OK: 3340 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / 772f587
Reports root/ big
OK: 3322 / Failed: 1 / User-skipped: 105 / Auto-skipped: 0

mam_SUITE:rdbms_async_cache_prefs_cases:end_per_group

{error,
 {{badrpc,
   {'EXIT',
  {{start_child_failed,
    {error,
     {{shutdown,
     {failed_to_start_child,'pm_mam_async_pool_test type',
      {shutdown,
       {failed_to_start_child,
      'wpool_pool-pm_mam_async_pool_test type-process-sup',
      {shutdown,
       {failed_to_start_child,
        'wpool_pool-pm_mam_async_pool_test type-6',
        {already_started,<9142.9055.1>}}}}}}},
    {child,undefined,'pm_mam_sup_async_pool_test type',
     {mongoose_async_pools,start_link,
      [<<"test type">>,pm_mam,
       #{batch_name => insert_mam_messages30,batch_size => 30,
       enabled => true,
       flush_callback => fun mod_mam_rdbms_arch_async:flush/2,
       flush_extra =>
        #{batch_name => insert_mam_messages30,batch_size => 30,
        enabled => true,flush_interval => 2000,pool_size => 16},
       flush_interval => 2000,pool_size => 16,pool_type => batch}]},
     transient,false,infinity,supervisor,
     [mongoose_async_pools]}}},
    #{id => 'pm_mam_sup_async_pool_test type',restart => transient,
    start =>
     {mongoose_async_pools,start_link,
      [<<"test type">>,pm_mam,
       #{batch_name => insert_mam_messages30,batch_size => 30,
       enabled => true,
       flush_callback => fun mod_mam_rdbms_arch_async:flush/2,
       flush_extra =>
        #{batch_name => insert_mam_messages30,batch_size => 30,
        enabled => true,flush_interval => 2000,pool_size => 16},
       flush_interval => 2000,pool_size => 16,pool_type => batch}]},
    type =>...

Report log

mam_SUITE:rdbms_async_cache_disabled_retraction:mam06:retract_message

{error,{{archive_size,1,[{times,200,0}]},
    [{mongoose_helper,do_wait_until,2,
              [{file,"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
               {line,371}]},
     {mam_SUITE,'-test_retract_message/1-fun-0-',4,
          [{file,"/home/circleci/project/big_tests/tests/mam_SUITE.erl"},
           {line,1717}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1223}]}]}}

Report log

ldap_mnesia_25 / ldap_mnesia / 772f587
Reports root/ big
OK: 1897 / Failed: 0 / User-skipped: 513 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / 772f587
Reports root/ big
OK: 2018 / Failed: 0 / User-skipped: 392 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 772f587
Reports root/ big
OK: 3340 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 772f587
Reports root/ big
OK: 2314 / Failed: 0 / User-skipped: 387 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / 772f587
Reports root/ big
OK: 3724 / Failed: 2 / User-skipped: 97 / Auto-skipped: 0

mam_SUITE:rdbms_async_pool_disabled_text_search:end_per_group

{error,
 {{badrpc,
   {'EXIT',
  {{start_child_failed,
    {error,
     {{shutdown,
     {failed_to_start_child,pm_mam_async_pool_localhost,
      {shutdown,
       {failed_to_start_child,
      'wpool_pool-pm_mam_async_pool_localhost-process-sup',
      {shutdown,
       {failed_to_start_child,
        'wpool_pool-pm_mam_async_pool_localhost-1',
        {already_started,<8842.18910.1>}}}}}}},
    {child,undefined,pm_mam_sup_async_pool_localhost,
     {mongoose_async_pools,start_link,
      [<<"localhost">>,pm_mam,
       #{batch_name => insert_mam_messages30,batch_size => 30,
       enabled => true,
       flush_callback => fun mod_mam_rdbms_arch_async:flush/2,
       flush_extra =>
        #{batch_name => insert_mam_messages30,batch_size => 30,
        enabled => true,flush_interval => 2000,pool_size => 16},
       flush_interval => 2000,pool_size => 16,pool_type => batch}]},
     transient,false,infinity,supervisor,
     [mongoose_async_pools]}}},
    #{id => pm_mam_sup_async_pool_localhost,restart => transient,
    start =>
     {mongoose_async_pools,start_link,
      [<<"localhost">>,pm_mam,
       #{batch_name => insert_mam_messages30,batch_size => 30,
       enabled => true,
       flush_callback => fun mod_mam_rdbms_arch_async:flush/2,
       flush_extra =>
        #{batch_name => insert_mam_messages30,batch_size => 30,
        enabled => true,flush_interval => 2000,pool_size => 16},
       flush_interval => 2000,pool_size => 16,pool_type => batch}]},
    type => supe...

Report log

mam_SUITE:rdbms_async_pool_disabled_retraction:mam06:retract_message

{error,{{archive_size,1,[{times,200,0}]},
    [{mongoose_helper,do_wait_until,2,
              [{file,"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
               {line,371}]},
     {mam_SUITE,'-test_retract_message/1-fun-0-',4,
          [{file,"/home/circleci/project/big_tests/tests/mam_SUITE.erl"},
           {line,1717}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1292}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1224}]}]}}

Report log

pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription

{error,
  {{badmatch,
     [{xmlel,<<"message">>,
        [{<<"from">>,
        <<"alice_unsubscribe_after_presence_unsubscription_2442@localhost">>},
         {<<"to">>,
        <<"bob_unsubscribe_after_presence_unsubscription_2442@localhost/res1">>},
         {<<"type">>,<<"headline">>}],
        [{xmlel,<<"event">>,
           [{<<"xmlns">>,
           <<"http://jabber.org/protocol/pubsub#event">>}],
           [{xmlel,<<"items">>,
            [{<<"node">>,<<"kMBSKiCP50M4Rp9UdpqP9w==">>}],
            [{xmlel,<<"item">>,
               [{<<"id">>,<<"salmon">>}],
               [{xmlel,<<"entry">>,
                  [{<<"xmlns">>,
                  <<"http://www.w3.org/2005/Atom">>}],
                  []}]}]}]},
         {xmlel,<<"headers">>,
           [{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
           []}]}]},
   [{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
      [{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
       {line,384}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1292}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1224}]}]}}

Report log

mysql_redis_25 / mysql_redis / 772f587
Reports root/ big
OK: 3720 / Failed: 1 / User-skipped: 102 / Auto-skipped: 0

pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription

{error,
  {{badmatch,
     [{xmlel,<<"message">>,
        [{<<"from">>,
        <<"alice_unsubscribe_after_presence_unsubscription_2196@localhost">>},
         {<<"to">>,
        <<"bob_unsubscribe_after_presence_unsubscription_2196@localhost/res1">>},
         {<<"type">>,<<"headline">>}],
        [{xmlel,<<"event">>,
           [{<<"xmlns">>,
           <<"http://jabber.org/protocol/pubsub#event">>}],
           [{xmlel,<<"items">>,
            [{<<"node">>,<<"izUDxxwg5aNhbVIMBWQt9A==">>}],
            [{xmlel,<<"item">>,
               [{<<"id">>,<<"salmon">>}],
               [{xmlel,<<"entry">>,
                  [{<<"xmlns">>,
                  <<"http://www.w3.org/2005/Atom">>}],
                  []}]}]}]},
         {xmlel,<<"headers">>,
           [{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
           []}]}]},
   [{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
      [{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
       {line,384}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log

pgsql_mnesia_25 / pgsql_mnesia / 772f587
Reports root/ big
OK: 3714 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / 772f587
Reports root/ big
OK: 3714 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / 772f587
Reports root/ big
OK: 2175 / Failed: 0 / User-skipped: 380 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / 772f587
Reports root/ big
OK: 3323 / Failed: 0 / User-skipped: 105 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / 772f587
Reports root/ big
OK: 3714 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / 772f587
Reports root/ big
OK: 3323 / Failed: 0 / User-skipped: 105 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / 772f587
Reports root/ big
OK: 3725 / Failed: 1 / User-skipped: 97 / Auto-skipped: 0

pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription

{error,
  {{badmatch,
     [{xmlel,<<"message">>,
        [{<<"from">>,
        <<"alice_unsubscribe_after_presence_unsubscription_2262@localhost">>},
         {<<"to">>,
        <<"bob_unsubscribe_after_presence_unsubscription_2262@localhost/res1">>},
         {<<"type">>,<<"headline">>}],
        [{xmlel,<<"event">>,
           [{<<"xmlns">>,
           <<"http://jabber.org/protocol/pubsub#event">>}],
           [{xmlel,<<"items">>,
            [{<<"node">>,<<"FK3dkVnhoWORNTA/ArEs5A==">>}],
            [{xmlel,<<"item">>,
               [{<<"id">>,<<"salmon">>}],
               [{xmlel,<<"entry">>,
                  [{<<"xmlns">>,
                  <<"http://www.w3.org/2005/Atom">>}],
                  []}]}]}]},
         {xmlel,<<"headers">>,
           [{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
           []}]}]},
   [{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
      [{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
       {line,384}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1292}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1224}]}]}}

Report log

chrzaszcz

Looks good in general, I only have minor comments.

chrzaszcz · 2022-08-12T11:59:46Z

src/pubsub/mod_pubsub.erl

-               Plugins) ->
+init_state(ServerHost, #{last_item_cache := LastItemCache, max_items_node := MaxItemsNode,
+                         pep_mapping := PepMapping, ignore_pep_from_offline := PepOffline,
+                         access_createnode := Access, plugins := Plugins}, Plugins) ->


The code before this change worked if a plugin failed to initialize, but now it would crash. Is it intentional?

not really, I just does not understand the code 100% :) could change to the old behaviour though

So maybe remove plugins := Plugins to avoid this unexpected pattern-matching?

tricky, there are these gen_server calls to get plugins (see plugins/1 function) instead of calling opts instead.
And gen_server is a pretty heavy operation.

Is there an use case for a plugin failing to start?
Maybe we could crash the module start function if the plugin crashes instead?

For me this is out of scope of this PR - so why not keep the functionality as it was before?

chrzaszcz · 2022-08-12T12:00:15Z

src/pubsub/mod_pubsub.erl

+          send_last_pubsub_items_for_plugin(Host, PluginType, Recipient)
+      end, Plugins).


Minor: indentation is inconsistent here.

good, I need to fix vim config on my new laptop finally :)

mongoose-im · 2022-08-22T14:04:47Z

small_tests_24 / small_tests / 8a4f083
Reports root / small

small_tests_25 / small_tests / 8a4f083
Reports root / small

ldap_mnesia_24 / ldap_mnesia / 8a4f083
Reports root/ big
OK: 1897 / Failed: 0 / User-skipped: 513 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 8a4f083
Reports root/ big
OK: 3340 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 8a4f083
Reports root/ big
OK: 3340 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / 8a4f083
Reports root/ big
OK: 3323 / Failed: 0 / User-skipped: 105 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / 8a4f083
Reports root/ big
OK: 1897 / Failed: 0 / User-skipped: 513 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 8a4f083
Reports root/ big
OK: 3340 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / 8a4f083
Reports root/ big
OK: 3714 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / 8a4f083
Reports root/ big
OK: 2018 / Failed: 0 / User-skipped: 392 / Auto-skipped: 0

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 8a4f083
Reports root/ big
OK: 2314 / Failed: 0 / User-skipped: 387 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / 8a4f083
Reports root/ big
OK: 3714 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / 8a4f083
Reports root/ big
OK: 3709 / Failed: 0 / User-skipped: 102 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / 8a4f083
Reports root/ big
OK: 3722 / Failed: 1 / User-skipped: 97 / Auto-skipped: 0

disco_and_caps_SUITE:disco_with_caps:user_can_query_friend_resources

{error,{{assertion_failed,assert_many,false,[is_roster_set],[],[]},
    [{escalus_new_assert,assert_true,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
                {line,84}]},
     {escalus_story,'-make_all_clients_friends/1-fun-0-',2,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,108}]},
     {escalus_utils,'-each_with_index/3-fun-0-',3,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
             {line,87}]},
     {lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
     {escalus_utils,'-each_with_index/3-fun-0-',3,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
             {line,87}]},
     {lists,foldl,3,[{file,"lists.erl"},{line,1350}]},
     {escalus_utils,distinct_pairs,2,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
             {line,60}]},
     {escalus_story,make_all_clients_friends,1,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,106}]}]}}

Report log

riak_mnesia_24 / riak_mnesia / 8a4f083
Reports root/ big
OK: 2175 / Failed: 0 / User-skipped: 380 / Auto-skipped: 0

chrzaszcz

Looks good 👍

Use wpool for notify_loop in mod_pubsub

772f587

arcusfelis force-pushed the pubsub-wpool branch from bfc2e1b to 772f587 Compare August 9, 2022 16:04

mongoose-im mentioned this pull request Aug 9, 2022

CI build failures summary - part 2 #3685

Closed

This comment was marked as outdated.

Sign in to view

arcusfelis added the waiting-for-review label Aug 12, 2022

chrzaszcz reviewed Aug 12, 2022

View reviewed changes

arcusfelis added 2 commits August 22, 2022 10:50

Get all options before calling the worker

3dbf5f8

Address the review comments

8a4f083

arcusfelis requested a review from chrzaszcz August 22, 2022 16:44

chrzaszcz reviewed Aug 23, 2022

View reviewed changes

chrzaszcz approved these changes Aug 23, 2022

View reviewed changes

chrzaszcz merged commit 6ac0a55 into master Aug 23, 2022

chrzaszcz deleted the pubsub-wpool branch August 23, 2022 06:51

chrzaszcz added this to the 6.0.0 milestone Dec 12, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use wpool for notify_loop in mod_pubsub #3726

Use wpool for notify_loop in mod_pubsub #3726

arcusfelis commented Aug 9, 2022

mongoose-im commented Aug 9, 2022 •

edited

codecov bot commented Aug 9, 2022 •

edited

mongoose-im commented Aug 9, 2022 •

edited

This comment was marked as outdated.

chrzaszcz left a comment

chrzaszcz Aug 12, 2022

arcusfelis Aug 12, 2022

chrzaszcz Aug 12, 2022 •

edited

arcusfelis Aug 12, 2022

chrzaszcz Aug 22, 2022

chrzaszcz Aug 12, 2022

arcusfelis Aug 12, 2022

mongoose-im commented Aug 22, 2022 •

edited

chrzaszcz left a comment

		send_last_pubsub_items_for_plugin(Host, PluginType, Recipient)
		end, Plugins).

Use wpool for notify_loop in mod_pubsub #3726

Use wpool for notify_loop in mod_pubsub #3726

Conversation

arcusfelis commented Aug 9, 2022

mongoose-im commented Aug 9, 2022 • edited

codecov bot commented Aug 9, 2022 • edited

Codecov Report

mongoose-im commented Aug 9, 2022 • edited

This comment was marked as outdated.

chrzaszcz left a comment

Choose a reason for hiding this comment

chrzaszcz Aug 12, 2022

Choose a reason for hiding this comment

arcusfelis Aug 12, 2022

Choose a reason for hiding this comment

chrzaszcz Aug 12, 2022 • edited

Choose a reason for hiding this comment

arcusfelis Aug 12, 2022

Choose a reason for hiding this comment

chrzaszcz Aug 22, 2022

Choose a reason for hiding this comment

chrzaszcz Aug 12, 2022

Choose a reason for hiding this comment

arcusfelis Aug 12, 2022

Choose a reason for hiding this comment

mongoose-im commented Aug 22, 2022 • edited

chrzaszcz left a comment

Choose a reason for hiding this comment

mongoose-im commented Aug 9, 2022 •

edited

codecov bot commented Aug 9, 2022 •

edited

mongoose-im commented Aug 9, 2022 •

edited

chrzaszcz Aug 12, 2022 •

edited

mongoose-im commented Aug 22, 2022 •

edited