Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reusable code for domain admin tests #3740

Merged
merged 1 commit into from
Aug 25, 2022

Conversation

jacekwegr
Copy link
Contributor

Merged execute_auth and execute_domain_admin functions so both types of admins can use execute_command

@mongoose-im

This comment was marked as outdated.

@codecov
Copy link

codecov bot commented Aug 24, 2022

Codecov Report

Merging #3740 (6944340) into master (42a04dc) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3740      +/-   ##
==========================================
- Coverage   82.67%   82.64%   -0.04%     
==========================================
  Files         529      529              
  Lines       33947    33947              
==========================================
- Hits        28067    28055      -12     
- Misses       5880     5892      +12     
Impacted Files Coverage Δ
src/cassandra/mongoose_cassandra.erl 77.77% <0.00%> (-3.71%) ⬇️
src/cassandra/mongoose_cassandra_worker.erl 66.03% <0.00%> (-2.84%) ⬇️
src/mod_muc.erl 74.41% <0.00%> (-0.24%) ⬇️
src/pubsub/mod_pubsub.erl 72.99% <0.00%> (-0.19%) ⬇️
src/mod_muc_room.erl 78.51% <0.00%> (-0.18%) ⬇️
src/mod_muc_log.erl 62.82% <0.00%> (ø)
src/inbox/mod_inbox_rdbms_async.erl 72.05% <0.00%> (ø)
src/ejabberd.erl 55.00% <0.00%> (+10.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Merged the execute_auth and execute_domain_admin functions so both types of admins can use execute_command
@jacekwegr jacekwegr force-pushed the reuse-code-for-domain-admin-tests branch from 6efe220 to 6944340 Compare August 25, 2022 08:22
@mongoose-im
Copy link
Collaborator

mongoose-im commented Aug 25, 2022

small_tests_24 / small_tests / 6944340
Reports root / small


small_tests_25 / small_tests / 6944340
Reports root / small


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 6944340
Reports root/ big
OK: 3554 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


ldap_mnesia_24 / ldap_mnesia / 6944340
Reports root/ big
OK: 1941 / Failed: 0 / User-skipped: 529 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 6944340
Reports root/ big
OK: 3554 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / 6944340
Reports root/ big
OK: 1941 / Failed: 0 / User-skipped: 529 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / 6944340
Reports root/ big
OK: 3537 / Failed: 0 / User-skipped: 105 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 6944340
Reports root/ big
OK: 3554 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / 6944340
Reports root/ big
OK: 2062 / Failed: 0 / User-skipped: 408 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 6944340
Reports root/ big
OK: 3928 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 6944340
Reports root/ big
OK: 2402 / Failed: 0 / User-skipped: 403 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / 6944340
Reports root/ big
OK: 3928 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


mssql_mnesia_25 / odbc_mssql_mnesia / 6944340
Reports root/ big
OK: 3928 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


mysql_redis_25 / mysql_redis / 6944340
Reports root/ big
OK: 3923 / Failed: 0 / User-skipped: 102 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / 6944340
Reports root/ big
OK: 2241 / Failed: 0 / User-skipped: 396 / Auto-skipped: 0

@jacekwegr jacekwegr marked this pull request as ready for review August 25, 2022 09:19
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@chrzaszcz chrzaszcz merged commit 918421a into master Aug 25, 2022
@chrzaszcz chrzaszcz deleted the reuse-code-for-domain-admin-tests branch August 25, 2022 14:10
@chrzaszcz chrzaszcz added this to the 6.0.0 milestone Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants