c2s/mod_last #3750

NelsonVides · 2022-09-03T14:33:54Z

No description provided.

mongoose-im · 2022-09-20T14:15:05Z

ldap_mnesia_24 / ldap_mnesia / 49e6f5b
Reports root/ big
OK: 793 / Failed: 0 / User-skipped: 425 / Auto-skipped: 0

small_tests_24 / small_tests / 49e6f5b
Reports root / small

ldap_mnesia_25 / ldap_mnesia / 49e6f5b
Reports root/ big
OK: 793 / Failed: 0 / User-skipped: 425 / Auto-skipped: 0

small_tests_25 / small_tests / 49e6f5b
Reports root / small

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 49e6f5b
Reports root/ big
OK: 2532 / Failed: 0 / User-skipped: 52 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / 49e6f5b
Reports root/ big
OK: 853 / Failed: 0 / User-skipped: 365 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / 49e6f5b
Reports root/ big
OK: 2600 / Failed: 0 / User-skipped: 61 / Auto-skipped: 0

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 49e6f5b
Reports root/ big
OK: 1189 / Failed: 0 / User-skipped: 364 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 49e6f5b
Reports root/ big
OK: 2532 / Failed: 0 / User-skipped: 52 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / 49e6f5b
Reports root/ big
OK: 2593 / Failed: 1 / User-skipped: 66 / Auto-skipped: 1

metrics_session_SUITE:session_global:session_global

{error,
  {{totalSessionCount,
     {value,1},
     [{times,25,
        {error,
          {badmatch,{value,0}},
          [{metrics_helper,assert_counter,3,
             [{file,
              "/home/circleci/project/big_tests/tests/metrics_helper.erl"},
            {line,36}]},
           {mongoose_helper,do_wait_until,2,
             [{file,
              "/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
            {line,374}]},
           {escalus_story,story,4,
             [{file,
              "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
            {line,72}]},
           {test_server,ts_tc,3,
             [{file,"test_server.erl"},{line,1782}]},
           {test_server,run_test_case_eval1,6,
             [{file,"test_server.erl"},{line,1291}]},
           {test_server,run_test_case_eval,9,
             [{file,"test_server.erl"},{line,1223}]}]}}]},
   [{mongoose_helper,do_wait_until,2,
      [{file,"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
       {line,371}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log

pgsql_mnesia_25 / pgsql_mnesia / 49e6f5b
Reports root/ big
OK: 2600 / Failed: 0 / User-skipped: 61 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / 49e6f5b
Reports root/ big
OK: 2515 / Failed: 0 / User-skipped: 69 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 49e6f5b
Reports root/ big
OK: 2532 / Failed: 0 / User-skipped: 52 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / 49e6f5b
Reports root/ big
OK: 1036 / Failed: 0 / User-skipped: 349 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / 49e6f5b
Reports root/ big
OK: 2600 / Failed: 0 / User-skipped: 61 / Auto-skipped: 0

codecov · 2022-09-20T14:15:55Z

Codecov Report

Base: 57.75% // Head: 57.80% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (7985965) compared to base (6a2100c).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@                   Coverage Diff                    @@
##           feature/mongoose_c2s    #3750      +/-   ##
========================================================
+ Coverage                 57.75%   57.80%   +0.05%     
========================================================
  Files                       536      536              
  Lines                     34809    34822      +13     
========================================================
+ Hits                      20103    20129      +26     
+ Misses                    14706    14693      -13

Impacted Files	Coverage Δ
src/mod_last.erl	`85.00% <100.00%> (+11.86%)`	⬆️
src/elasticsearch/mongoose_elasticsearch.erl	`76.92% <0.00%> (-7.70%)`	⬇️
src/pubsub/node_pep.erl	`68.51% <0.00%> (-5.56%)`	⬇️
src/cassandra/mongoose_cassandra.erl	`77.77% <0.00%> (-3.71%)`	⬇️
src/cassandra/mongoose_cassandra_worker.erl	`66.03% <0.00%> (-2.84%)`	⬇️
src/mam/mod_mam_elasticsearch_arch.erl	`86.60% <0.00%> (-1.79%)`	⬇️
src/pubsub/mod_pubsub_db_rdbms.erl	`68.99% <0.00%> (-0.52%)`	⬇️
src/mod_roster.erl	`71.29% <0.00%> (+0.23%)`	⬆️
src/mod_muc_room.erl	`46.84% <0.00%> (+0.96%)`	⬆️
src/inbox/mod_inbox_rdbms_async.erl	`73.52% <0.00%> (+1.47%)`	⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

chrzaszcz

I added a few comments, please provide PR descriptions.

chrzaszcz · 2022-09-22T08:13:36Z

src/mod_last.erl

@@ -46,6 +46,7 @@
         session_cleanup/5,
         remove_domain/3,
         remove_unused_backend_opts/1]).
+-export([user_receive_iq/3]).


Minor: why is this one exported separately? The above are already IQ and hook handlers (two types of handlers), and they are exported together. So it looks like a minor inconsistency.

chrzaszcz · 2022-09-22T08:21:48Z

src/mod_last.erl

+    {From, To, _} = mongoose_acc:packet(Acc),
+    case {To#jid.lresource, can_respond(HostType, From, To)} of
+        {<<>>, _} ->
+            {ok, Acc};


Is this clause reachable? Wouldn't it be caught by the IQ handler?

Actually, that is true!

The XMPP core itself says that IQs to a user without specifying the resource must be handled by the server on their behalf: https://www.rfc-editor.org/rfc/rfc6120#section-10.5.3.2

src/mod_last.erl

arcusfelis

looks good

This module now implements a handler for an online user receiving an IQ, which used to be in `ejabberd_c2s:handle_routed_iq/4`. This happens when the IQ is directed to a full JID with a resource, but it still needs to check if it is allowed to be routed, according to XEP-0012 saying: > if the requesting entity is not authorized to view the user's presence > information (normally via a presence subscription as defined in XMPP > IM), the user's server MUST NOT deliver the IQ-get to an available > resource but instead MUST return a <forbidden/> error in response to > the last activity request. https://xmpp.org/extensions/xep-0012.html#online

mongoose-im · 2022-09-23T09:31:48Z

small_tests_24 / small_tests / 7985965
Reports root / small

ldap_mnesia_24 / ldap_mnesia / 7985965
Reports root/ big
OK: 794 / Failed: 0 / User-skipped: 425 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / 7985965
Reports root/ big
OK: 794 / Failed: 0 / User-skipped: 425 / Auto-skipped: 0

small_tests_25 / small_tests / 7985965
Reports root / small

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 7985965
Reports root/ big
OK: 2533 / Failed: 0 / User-skipped: 52 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / 7985965
Reports root/ big
OK: 2601 / Failed: 0 / User-skipped: 61 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / 7985965
Reports root/ big
OK: 854 / Failed: 0 / User-skipped: 365 / Auto-skipped: 0

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 7985965
Reports root/ big
OK: 1190 / Failed: 0 / User-skipped: 364 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 7985965
Reports root/ big
OK: 2532 / Failed: 1 / User-skipped: 52 / Auto-skipped: 0

service_mongoose_system_metrics_SUITE:system_metrics_are_reported_to_configurable_google_analytics

{error,
  {{assertEqual,
     [{module,service_mongoose_system_metrics_SUITE},
      {line,470},
      {expression,"ActualTrackingIds"},
      {expected,[<<"UA-151671255-1">>,<<"UA-EXTRA-TRACKING-ID">>]},
      {value,[<<"UA-151671255-1">>]}]},
   [{service_mongoose_system_metrics_SUITE,
      events_are_reported_to_tracking_ids,1,
      [{file,
         "/home/circleci/project/big_tests/tests/service_mongoose_system_metrics_SUITE.erl"},
       {line,470}]},
    {service_mongoose_system_metrics_SUITE,
      system_metrics_are_reported_to_configurable_google_analytics,1,
      [{file,
         "/home/circleci/project/big_tests/tests/service_mongoose_system_metrics_SUITE.erl"},
       {line,204}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log

dynamic_domains_mysql_redis_25 / mysql_redis / 7985965
Reports root/ big
OK: 2516 / Failed: 0 / User-skipped: 69 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / 7985965
Reports root/ big
OK: 2601 / Failed: 0 / User-skipped: 61 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / 7985965
Reports root/ big
OK: 2594 / Failed: 1 / User-skipped: 66 / Auto-skipped: 1

metrics_session_SUITE:session_global:session_global

{error,
  {{totalSessionCount,
     {value,1},
     [{times,25,
        {error,
          {badmatch,{value,0}},
          [{metrics_helper,assert_counter,3,
             [{file,
              "/home/circleci/project/big_tests/tests/metrics_helper.erl"},
            {line,36}]},
           {mongoose_helper,do_wait_until,2,
             [{file,
              "/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
            {line,374}]},
           {escalus_story,story,4,
             [{file,
              "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
            {line,72}]},
           {test_server,ts_tc,3,
             [{file,"test_server.erl"},{line,1782}]},
           {test_server,run_test_case_eval1,6,
             [{file,"test_server.erl"},{line,1291}]},
           {test_server,run_test_case_eval,9,
             [{file,"test_server.erl"},{line,1223}]}]}}]},
   [{mongoose_helper,do_wait_until,2,
      [{file,"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
       {line,371}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 7985965
Reports root/ big
OK: 2533 / Failed: 0 / User-skipped: 52 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / 7985965
Reports root/ big
OK: 2598 / Failed: 3 / User-skipped: 61 / Auto-skipped: 0

service_domain_db_SUITE:db:db_get_all_static

{error,
  {{badrpc,{'EXIT',{timeout,{gen_server,call,[service_domain_db,ping]}}}},
   [{distributed_helper,rpc,
      [#{node => mongooseim@localhost},service_domain_db,sync_local,[]],
      [{file,
         "/home/circleci/project/big_tests/tests/distributed_helper.erl"},
       {line,117}]},
    {service_domain_db_SUITE,sync_local,1,
      [{file,
         "/home/circleci/project/big_tests/tests/service_domain_db_SUITE.erl"},
       {line,1205}]},
    {service_domain_db_SUITE,sync,0,
      [{file,
         "/home/circleci/project/big_tests/tests/service_domain_db_SUITE.erl"},
       {line,1184}]},
    {service_domain_db_SUITE,db_get_all_static,1,
      [{file,
         "/home/circleci/project/big_tests/tests/service_domain_db_SUITE.erl"},
       {line,356}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log

service_domain_db_SUITE:db:db_get_all_dynamic

{error,
  {{badrpc,timeout},
   [{distributed_helper,rpc,
      [#{node => mongooseim@localhost},service_domain_db,sync_local,[]],
      [{file,
         "/home/circleci/project/big_tests/tests/distributed_helper.erl"},
       {line,117}]},
    {service_domain_db_SUITE,sync_local,1,
      [{file,
         "/home/circleci/project/big_tests/tests/service_domain_db_SUITE.erl"},
       {line,1205}]},
    {service_domain_db_SUITE,sync,0,
      [{file,
         "/home/circleci/project/big_tests/tests/service_domain_db_SUITE.erl"},
       {line,1184}]},
    {service_domain_db_SUITE,db_get_all_dynamic,1,
      [{file,
         "/home/circleci/project/big_tests/tests/service_domain_db_SUITE.erl"},
       {line,366}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log

service_domain_db_SUITE:db:db_out_of_sync_restarts_service

{error,
  {{badrpc,timeout},
   [{distributed_helper,rpc,
      [#{node => ejabberd2@localhost},service_domain_db,sync_local,[]],
      [{file,
         "/home/circleci/project/big_tests/tests/distributed_helper.erl"},
       {line,117}]},
    {service_domain_db_SUITE,sync_local,1,
      [{file,
         "/home/circleci/project/big_tests/tests/service_domain_db_SUITE.erl"},
       {line,1205}]},
    {service_domain_db_SUITE,db_out_of_sync_restarts_service,1,
      [{file,
         "/home/circleci/project/big_tests/tests/service_domain_db_SUITE.erl"},
       {line,634}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log

riak_mnesia_24 / riak_mnesia / 7985965
Reports root/ big
OK: 1037 / Failed: 0 / User-skipped: 349 / Auto-skipped: 0

chrzaszcz

Looks good 👍
There are random CI failures, but the docker image would not build anyway (failing small tests as expected).

NelsonVides added the mongoose_c2s label Sep 3, 2022

NelsonVides changed the title ~~mod_last~~ c2s/mod_last Sep 3, 2022

This comment was marked as outdated.

Sign in to view

NelsonVides force-pushed the c2s/presences branch from 7b68709 to 2a5694a Compare September 3, 2022 14:43

NelsonVides force-pushed the c2s/last branch from 10e4f53 to 9b9f2da Compare September 3, 2022 14:45

This comment was marked as outdated.

Sign in to view

mongoose-im mentioned this pull request Sep 3, 2022

CI build failures summary - part 2 #3685

Closed

NelsonVides force-pushed the c2s/presences branch 3 times, most recently from c6105e8 to 7b8e99c Compare September 7, 2022 15:54

NelsonVides force-pushed the c2s/presences branch 4 times, most recently from 1edaa0f to 4152aa9 Compare September 20, 2022 12:59

NelsonVides force-pushed the c2s/last branch from 9b9f2da to b5a0c35 Compare September 20, 2022 13:14

This comment was marked as outdated.

Sign in to view

Base automatically changed from c2s/presences to feature/mongoose_c2s September 20, 2022 13:51

NelsonVides force-pushed the c2s/last branch from b5a0c35 to 49e6f5b Compare September 20, 2022 14:06

NelsonVides marked this pull request as ready for review September 20, 2022 14:23

chrzaszcz reviewed Sep 22, 2022

View reviewed changes

arcusfelis approved these changes Sep 23, 2022

View reviewed changes

NelsonVides added 3 commits September 23, 2022 11:16

Reenable newly passing suites

1bfd414

Test asking a direct user for last status

7985965

NelsonVides force-pushed the c2s/last branch from 49e6f5b to 7985965 Compare September 23, 2022 09:23

chrzaszcz approved these changes Sep 23, 2022

View reviewed changes

chrzaszcz merged commit 5f5c26e into feature/mongoose_c2s Sep 23, 2022

chrzaszcz deleted the c2s/last branch September 23, 2022 09:49

jacekwegr added this to the 6.1.0 milestone Apr 27, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

c2s/mod_last #3750

c2s/mod_last #3750

NelsonVides commented Sep 3, 2022

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

mongoose-im commented Sep 20, 2022 •

edited

codecov bot commented Sep 20, 2022 •

edited

chrzaszcz left a comment

chrzaszcz Sep 22, 2022

chrzaszcz Sep 22, 2022

NelsonVides Sep 23, 2022

NelsonVides Sep 23, 2022

arcusfelis left a comment

mongoose-im commented Sep 23, 2022 •

edited

chrzaszcz left a comment •

edited

c2s/mod_last #3750

c2s/mod_last #3750

Conversation

NelsonVides commented Sep 3, 2022

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

mongoose-im commented Sep 20, 2022 • edited

codecov bot commented Sep 20, 2022 • edited

Codecov Report

chrzaszcz left a comment

Choose a reason for hiding this comment

chrzaszcz Sep 22, 2022

Choose a reason for hiding this comment

chrzaszcz Sep 22, 2022

Choose a reason for hiding this comment

NelsonVides Sep 23, 2022

Choose a reason for hiding this comment

NelsonVides Sep 23, 2022

Choose a reason for hiding this comment

arcusfelis left a comment

Choose a reason for hiding this comment

mongoose-im commented Sep 23, 2022 • edited

chrzaszcz left a comment • edited

Choose a reason for hiding this comment

mongoose-im commented Sep 20, 2022 •

edited

codecov bot commented Sep 20, 2022 •

edited

mongoose-im commented Sep 23, 2022 •

edited

chrzaszcz left a comment •

edited