Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes graphql suites #3783

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Fixes graphql suites #3783

merged 1 commit into from
Oct 4, 2022

Conversation

kamilwaz
Copy link
Contributor

@kamilwaz kamilwaz commented Oct 3, 2022

Fixes graphql suites.

@kamilwaz kamilwaz changed the base branch from master to feature/mongoose_c2s October 3, 2022 08:14
@mongoose-im
Copy link
Collaborator

mongoose-im commented Oct 3, 2022

small_tests_24 / small_tests / 0a21d19
Reports root / small


ldap_mnesia_24 / ldap_mnesia / 0a21d19
Reports root/ big
OK: 838 / Failed: 0 / User-skipped: 427 / Auto-skipped: 0


small_tests_25 / small_tests / 0a21d19
Reports root / small


ldap_mnesia_25 / ldap_mnesia / 0a21d19
Reports root/ big
OK: 838 / Failed: 0 / User-skipped: 427 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / 0a21d19
Reports root/ big
OK: 900 / Failed: 0 / User-skipped: 365 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 0a21d19
Reports root/ big
OK: 2579 / Failed: 0 / User-skipped: 52 / Auto-skipped: 0


elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 0a21d19
Reports root/ big
OK: 1236 / Failed: 0 / User-skipped: 364 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 0a21d19
Reports root/ big
OK: 2579 / Failed: 0 / User-skipped: 52 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / 0a21d19
Reports root/ big
OK: 2560 / Failed: 2 / User-skipped: 69 / Auto-skipped: 0

graphql_session_SUITE:admin_session:admin_session_http:admin_count_sessions
{error,
  {{assertEqual,
     [{module,graphql_session_SUITE},
      {line,126},
      {expression,"Number"},
      {expected,3},
      {value,0}]},
   [{graphql_session_SUITE,admin_count_sessions_story,4,
      [{file,
         "/home/circleci/project/big_tests/tests/graphql_session_SUITE.erl"},
       {line,126}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log

graphql_session_SUITE:admin_session:admin_session_cli:admin_count_sessions
{error,
  {{assertEqual,
     [{module,graphql_session_SUITE},
      {line,126},
      {expression,"Number"},
      {expected,3},
      {value,0}]},
   [{graphql_session_SUITE,admin_count_sessions_story,4,
      [{file,
         "/home/circleci/project/big_tests/tests/graphql_session_SUITE.erl"},
       {line,126}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log


pgsql_mnesia_25 / pgsql_mnesia / 0a21d19
Reports root/ big
OK: 2647 / Failed: 0 / User-skipped: 61 / Auto-skipped: 0


mysql_redis_25 / mysql_redis / 0a21d19
Reports root/ big
OK: 2637 / Failed: 4 / User-skipped: 66 / Auto-skipped: 1

graphql_session_SUITE:admin_session:admin_session_http:admin_count_sessions
{error,
  {{assertEqual,
     [{module,graphql_session_SUITE},
      {line,126},
      {expression,"Number"},
      {expected,3},
      {value,0}]},
   [{graphql_session_SUITE,admin_count_sessions_story,4,
      [{file,
         "/home/circleci/project/big_tests/tests/graphql_session_SUITE.erl"},
       {line,126}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log

graphql_session_SUITE:admin_session:admin_session_cli:admin_count_sessions
{error,
  {{assertEqual,
     [{module,graphql_session_SUITE},
      {line,126},
      {expression,"Number"},
      {expected,3},
      {value,0}]},
   [{graphql_session_SUITE,admin_count_sessions_story,4,
      [{file,
         "/home/circleci/project/big_tests/tests/graphql_session_SUITE.erl"},
       {line,126}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log

metrics_session_SUITE:session_global:session_global
{error,
  {{totalSessionCount,
     {value,1},
     [{times,25,
        {error,
          {badmatch,{value,0}},
          [{metrics_helper,assert_counter,3,
             [{file,
              "/home/circleci/project/big_tests/tests/metrics_helper.erl"},
            {line,36}]},
           {mongoose_helper,do_wait_until,2,
             [{file,
              "/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
            {line,374}]},
           {escalus_story,story,4,
             [{file,
              "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
            {line,72}]},
           {test_server,ts_tc,3,
             [{file,"test_server.erl"},{line,1782}]},
           {test_server,run_test_case_eval1,6,
             [{file,"test_server.erl"},{line,1291}]},
           {test_server,run_test_case_eval,9,
             [{file,"test_server.erl"},{line,1223}]}]}}]},
   [{mongoose_helper,do_wait_until,2,
      [{file,"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
       {line,371}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log

rest_SUITE:admin:session_can_be_kicked
{error,{test_case_failed,[70,97,105,108,58,32,
              [60,60,
               "\"alice_session_can_be_kicked_1475@localhost/res1\"",
               62,62],
              32,105,110,32,
              [91,
               [[60,60,
               "\"alice_session_can_be_kicked_1475@localhost/res1\"",
               62,62],
              44,10,
              [32,32,
               [32,
                [32,[32,"   ",32,32,32],32,"   ",32,32,32],
                32,
                [32,"   ",32,32,32],
                32,"   ",32,32,32],
               32,
               [32,[32,"   ",32,32,32],32,"   ",32,32,32],
               32,
               [32,"   ",32,32,32],
               32,"   ",32,32,32],
              [60,60,
               "\"alice_messages_can_be_paginated_1477@localhost/res1\"",
               62,62]],
               93]]}}

Report log


riak_mnesia_24 / riak_mnesia / 0a21d19
Reports root/ big
OK: 1081 / Failed: 0 / User-skipped: 351 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 0a21d19
Reports root/ big
OK: 2577 / Failed: 1 / User-skipped: 52 / Auto-skipped: 1

last_SUITE:valid_queries:last_offline_user
{error,
  {{assertion_failed,assert,is_iq_result,
     {xmlel,<<"presence">>,
       [{<<"from">>,<<"alice_unnamed_848@domain.example.com/res1">>},
        {<<"to">>,<<"alice_unnamed_848@domain.example.com/res1">>},
        {<<"type">>,<<"unavailable">>}],
       [{xmlel,<<"status">>,[],[{xmlcdata,<<"Unknown condition">>}]}]},
     "<presence from='alice_unnamed_848@domain.example.com/res1' to='alice_unnamed_848@domain.example.com/res1' type='unavailable'><status>Unknown condition</status></presence>"},
   [{escalus_new_assert,assert_true,2,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
       {line,84}]},
    {escalus_session,session,1,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
       {line,131}]},
    {escalus_session,session,2,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
       {line,273}]},
    {escalus_connection,connection_step,2,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
       {line,160}]},
    {lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
    {escalus_connection,start,2,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
       {line,144}]},
    {escalus_client,start,3,
      [{file,
         "/home/circleci/project/big_tests/_b...

Report log


mssql_mnesia_25 / odbc_mssql_mnesia / 0a21d19
Reports root/ big
OK: 2647 / Failed: 0 / User-skipped: 61 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Base: 68.11% // Head: 63.11% // Decreases project coverage by -4.99% ⚠️

Coverage data is based on head (55d5805) compared to base (121cdf9).
Patch coverage: 81.81% of modified lines in pull request are covered.

❗ Current head 55d5805 differs from pull request most recent head 09404bc. Consider uploading reports for the commit 09404bc to get more accurate results

Additional details and impacted files
@@                   Coverage Diff                    @@
##           feature/mongoose_c2s    #3783      +/-   ##
========================================================
- Coverage                 68.11%   63.11%   -5.00%     
========================================================
  Files                       536      536              
  Lines                     35005    34878     -127     
========================================================
- Hits                      23842    22014    -1828     
- Misses                    11163    12864    +1701     
Impacted Files Coverage Δ
src/c2s/mongoose_c2s_socket.erl 23.94% <33.33%> (+0.41%) ⬆️
src/mod_presence.erl 86.24% <78.94%> (+1.22%) ⬆️
src/c2s/mongoose_c2s.erl 64.28% <100.00%> (-0.02%) ⬇️
src/ejabberd_sm.erl 76.94% <100.00%> (-0.26%) ⬇️
src/ejabberd_sm_redis.erl 94.64% <100.00%> (-0.28%) ⬇️
src/mongoose_session_api.erl 83.33% <100.00%> (+65.27%) ⬆️
src/amp_strategy.erl 0.00% <0.00%> (-95.66%) ⬇️
src/pubsub/mod_pubsub_cache_backend.erl 0.00% <0.00%> (-91.67%) ⬇️
src/pubsub/mod_pubsub_cache_rdbms.erl 0.00% <0.00%> (-90.91%) ⬇️
src/privacy/mod_privacy_riak.erl 0.00% <0.00%> (-76.48%) ⬇️
... and 78 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Oct 3, 2022

ldap_mnesia_24 / ldap_mnesia / c7686af
Reports root/ big
OK: 846 / Failed: 0 / User-skipped: 430 / Auto-skipped: 0


small_tests_24 / small_tests / c7686af
Reports root / small


ldap_mnesia_25 / ldap_mnesia / c7686af
Reports root/ big
OK: 846 / Failed: 0 / User-skipped: 430 / Auto-skipped: 0


small_tests_25 / small_tests / c7686af
Reports root / small


pgsql_mnesia_24 / pgsql_mnesia / c7686af
Reports root/ big
OK: 2658 / Failed: 0 / User-skipped: 61 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / c7686af
Reports root/ big
OK: 908 / Failed: 0 / User-skipped: 368 / Auto-skipped: 0


elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / c7686af
Reports root/ big
OK: 1244 / Failed: 0 / User-skipped: 367 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / c7686af
Reports root/ big
OK: 2590 / Failed: 0 / User-skipped: 52 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / c7686af
Reports root/ big
OK: 2573 / Failed: 0 / User-skipped: 69 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / c7686af
Reports root/ big
OK: 2658 / Failed: 0 / User-skipped: 61 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / c7686af
Reports root/ big
OK: 2590 / Failed: 0 / User-skipped: 52 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / c7686af
Reports root/ big
OK: 1089 / Failed: 0 / User-skipped: 354 / Auto-skipped: 0


mysql_redis_25 / mysql_redis / c7686af
Reports root/ big
OK: 2653 / Failed: 0 / User-skipped: 66 / Auto-skipped: 0


mssql_mnesia_25 / odbc_mssql_mnesia / c7686af
Reports root/ big
OK: 2658 / Failed: 0 / User-skipped: 61 / Auto-skipped: 0

@mongoose-im
Copy link
Collaborator

mongoose-im commented Oct 3, 2022

ldap_mnesia_24 / ldap_mnesia / 55d5805
Reports root/ big
OK: 846 / Failed: 0 / User-skipped: 430 / Auto-skipped: 0


small_tests_24 / small_tests / 55d5805
Reports root / small


ldap_mnesia_25 / ldap_mnesia / 55d5805
Reports root/ big
OK: 846 / Failed: 0 / User-skipped: 430 / Auto-skipped: 0


small_tests_25 / small_tests / 55d5805
Reports root / small


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 55d5805
Reports root/ big
OK: 2590 / Failed: 0 / User-skipped: 52 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / 55d5805
Reports root/ big
OK: 908 / Failed: 0 / User-skipped: 368 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 55d5805
Reports root/ big
OK: 2658 / Failed: 0 / User-skipped: 61 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 55d5805
Reports root/ big
OK: 2590 / Failed: 0 / User-skipped: 52 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / 55d5805
Reports root/ big
OK: 2573 / Failed: 0 / User-skipped: 69 / Auto-skipped: 0


mysql_redis_25 / mysql_redis / 55d5805
Reports root/ big
OK: 2653 / Failed: 0 / User-skipped: 66 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / 55d5805
Reports root/ big
OK: 2658 / Failed: 0 / User-skipped: 61 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 55d5805
Reports root/ big
OK: 2590 / Failed: 0 / User-skipped: 52 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / 55d5805
Reports root/ big
OK: 1089 / Failed: 0 / User-skipped: 354 / Auto-skipped: 0

Copy link
Collaborator

@NelsonVides NelsonVides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent code! Only needs rebasing to solve conflicts, and a small whitespace not needed.

@@ -172,3 +174,9 @@ is_ssl(#c2s_socket{transport = Transport}) ->
-spec get_ip(socket()) -> term().
get_ip(#c2s_socket{ip = Ip}) ->
Ip.

-spec get_conn_type(socket()) -> conntype().

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary white line.

@kamilwaz kamilwaz changed the title Fixes graphql_session suite Fixes graphql suites Oct 4, 2022
@kamilwaz kamilwaz force-pushed the c2s/graphql branch 2 times, most recently from b4c6695 to f8a72fe Compare October 4, 2022 07:30
@mongoose-im
Copy link
Collaborator

mongoose-im commented Oct 4, 2022

small_tests_24 / small_tests / 09404bc
Reports root / small


ldap_mnesia_24 / ldap_mnesia / 09404bc
Reports root/ big
OK: 1251 / Failed: 0 / User-skipped: 434 / Auto-skipped: 0


small_tests_25 / small_tests / 09404bc
Reports root / small


ldap_mnesia_25 / ldap_mnesia / 09404bc
Reports root/ big
OK: 1251 / Failed: 0 / User-skipped: 434 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 09404bc
Reports root/ big
OK: 2916 / Failed: 0 / User-skipped: 68 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 09404bc
Reports root/ big
OK: 2916 / Failed: 0 / User-skipped: 68 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 09404bc
Reports root/ big
OK: 3161 / Failed: 0 / User-skipped: 79 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / 09404bc
Reports root/ big
OK: 1313 / Failed: 0 / User-skipped: 372 / Auto-skipped: 0


elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 09404bc
Reports root/ big
OK: 1651 / Failed: 0 / User-skipped: 369 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 09404bc
Reports root/ big
OK: 2916 / Failed: 0 / User-skipped: 68 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / 09404bc
Reports root/ big
OK: 3161 / Failed: 0 / User-skipped: 79 / Auto-skipped: 0


mssql_mnesia_25 / odbc_mssql_mnesia / 09404bc
Reports root/ big
OK: 3160 / Failed: 1 / User-skipped: 79 / Auto-skipped: 0

service_domain_db_SUITE:db:db_event_could_appear_with_lower_id
{error,
  {{badmatch,534},
   [{service_domain_db_SUITE,db_event_could_appear_with_lower_id,1,
      [{file,
         "/home/circleci/project/big_tests/tests/service_domain_db_SUITE.erl"},
       {line,698}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log


mysql_redis_25 / mysql_redis / 09404bc
Reports root/ big
OK: 3156 / Failed: 0 / User-skipped: 84 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / 09404bc
Reports root/ big
OK: 1496 / Failed: 0 / User-skipped: 356 / Auto-skipped: 0


mssql_mnesia_25 / odbc_mssql_mnesia / 09404bc
Reports root/ big
OK: 3161 / Failed: 0 / User-skipped: 79 / Auto-skipped: 0

@kamilwaz kamilwaz marked this pull request as ready for review October 4, 2022 08:08
Copy link
Collaborator

@NelsonVides NelsonVides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent 👌🏽

@NelsonVides NelsonVides merged commit 0ff33d6 into feature/mongoose_c2s Oct 4, 2022
@NelsonVides NelsonVides deleted the c2s/graphql branch October 4, 2022 08:25
@jacekwegr jacekwegr added this to the 6.1.0 milestone Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants